https://bugzilla.redhat.com/show_bug.cgi?id=828998
Bug ID: 828998 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: drupal6-media_vimeo - Vimeo Video Module for Drupal6 Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: ansilva@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://people.redhat.com/~ansilva/drupal6-media_vimeo.spec SRPM URL: http://people.redhat.com/~ansilva/drupal6-media_vimeo-1.1-3.fc16.src.rpm Description: This module adds support for videos by the Vimeo provider to Embedded Media Field Fedora Account System Username: afsilva
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com Whiteboard| |NotReady
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- After quick review, missing "drupal6-emvideo" dependency
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #1)
After quick review, missing "drupal6-emvideo" dependency
Nevermind! I missed that emvideo was a sub-module of emfield. I'm hoping to get the drupal packaging spec updated so virtual provides should be listed.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #3 from Anderson Silva ansilva@redhat.com --- So, are you ok with this package? Do you need me to do something for it?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 701894 --> https://bugzilla.redhat.com/attachment.cgi?id=701894&action=edit drupal6-media_vimeo-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 828998
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 701895 --> https://bugzilla.redhat.com/attachment.cgi?id=701895&action=edit phpci.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Shawn Iwinski shawn.iwinski@gmail.com --- ===== SHOULD items =====
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream.
I believe this is because of a license update in the actual license file? Has upstream been made aware of the needed update?
[!]: Packages should try to preserve timestamps of original installed files.
Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command.
No blockers.
===== APPROVED =====
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Anderson Silva ansilva@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Anderson Silva ansilva@redhat.com --- New Package SCM Request ======================= Package Name: drupal6-media_vimeo Short Description: This module adds support for videos by the Vimeo provider to Embedded Media Field Owners: siwinski afsilva Branches: f17 f18 f19 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #12 from Shawn Iwinski shawn.iwinski@gmail.com --- Package Change Request ====================== Package Name: drupal6-media_vimeo New Branches: el5 Owners: ansilva siwinski InitialCC:
Adding el5 branch to follow most other drupal6 packages.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-01 18:25:46
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828998
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- drupal6-media_vimeo-1.1-3.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org