[Bug 2176391] New: Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Bug ID: 2176391
           Summary: Review Request: vcdimager - VideoCD (pre-)mastering
                    and ripping tool
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-14.fc39.src.rpm
Description:
VCDImager allows you to create VideoCD BIN/CUE CD images from MPEG
files. These can be burned with cdrdao or any other program capable of
burning BIN/CUE files.

Also included is VCDRip which does the reverse operation, that is to
rip MPEG streams from images or burned VideoCDs and to show
information about a VideoCD.

Fedora Account System Username: xavierb

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.gnu.org/software
                   |                            |/vcdimager/

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5613857
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #3 from Neal Gompa  ---
Initial spec review:
> Requires(post):  info
> Requires(preun): info

This is only needed for EL7. EL8 and newer have file triggers so this should be
dropped for them.
> find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'

This should be %{buildroot} for consistency
> %post libs -p /sbin/ldconfig
> %postun libs -p /sbin/ldconfig

This is only needed for EL7. If you want to have EL7 compatibility, please
switch to "%ldconfig_scriptlets libs" instead, so it becomes a no-op on EL8+
and Fedora.
> %post
> for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
>   /sbin/install-info %{_infodir}/${infofile} %{_infodir}/dir 2>/dev/null || :
> done
>
> %preun
> if [ $1 -eq 0 ]; then
>   for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
>     /sbin/install-info --delete %{_infodir}/${infofile} %{_infodir}/dir \
>       2>/dev/null || :
>   done
> fi

This is only needed for EL7. EL8 and newer have file triggers so this should be
dropped for them.
> %{_bindir}/*
> %{_mandir}/man1/*

This kind of globbing is not explicit/specific enough, there's no way to tell
if the package may add conflicting binaries.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #4 from Xavier Bachelot  ---
Thanks Neal.

All fixed in :
Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-15.fc39.src.rpm

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #5 from Neal Gompa  ---
Oh I missed one...
> License: GPLv2+

This needs to be "GPL-2.0-or-later" now.

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #6 from Neal Gompa  ---
> %{_mandir}/man1/cdxa2mpeg.1.gz
> %{_mandir}/man1/vcd-info.1.gz
> %{_mandir}/man1/vcdimager.1.gz
> %{_mandir}/man1/vcdxbuild.1.gz
> %{_mandir}/man1/vcdxgen.1.gz
> %{_mandir}/man1/vcdxminfo.1.gz
> %{_mandir}/man1/vcdxrip.1.gz

Please use "1*" here, because we don't guarantee gzipped man pages

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #7 from Jakub Kadlčík  ---
Created attachment 1949028
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949028&action=edit
The .spec file difference from Copr build 5613857 to 5614851

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #8 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614851
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #9 from Xavier Bachelot  ---
Fixed License: to use SPDX and manpages to use a glob instead of fixed .gz.

Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-16.fc39.src.rpm

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #10 from Jakub Kadlčík  ---
Created attachment 1949047
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949047&action=edit
The .spec file difference from Copr build 5614851 to 5614984

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #11 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614984
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #12 from Neal Gompa  ---
This looks great now.

PACKAGE APPROVED.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #13 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/vcdimager

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #14 from Fedora Update System  ---
FEDORA-2023-706a02d681 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-706a02d681

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #15 from Fedora Update System  ---
FEDORA-EPEL-2023-967aa197e2 has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-967aa197e2

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #16 from Fedora Update System  ---
FEDORA-2023-bbd85c941a has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-bbd85c941a

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #17 from Fedora Update System  ---
FEDORA-2023-0b053c84b8 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b053c84b8

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #18 from Fedora Update System  ---
FEDORA-EPEL-2023-c71897b5ef has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c71897b5ef

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-03-13 00:17:43

--- Comment #19 from Fedora Update System  ---
FEDORA-2023-706a02d681 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #20 from Fedora Update System  ---
FEDORA-EPEL-2023-c71897b5ef has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #21 from Fedora Update System  ---
FEDORA-2023-bbd85c941a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #22 from Fedora Update System  ---
FEDORA-2023-0b053c84b8 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

https://bugzilla.redhat.com/show_bug.cgi?id=2176391

--- Comment #23 from Fedora Update System  ---
FEDORA-EPEL-2023-967aa197e2 has been pushed to the Fedora EPEL 8 stable
repository.
If problem still persists, please make note of it in this bug report.