[Bug 1373243] New: Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Bug ID: 1373243
           Summary: Review Request: perl-Test-Filename - Portable filename
                    comparison
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://smani.fedorapeople.org/review/perl-Test-Filename.spec
SRPM URL:
https://smani.fedorapeople.org/review/perl-Test-Filename-0.03-1.fc26.src.rpm
Description: Portable filename comparison
Fedora Account System Username: smani

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1373244

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1373244
[Bug 1373244] Review Request: perl-Path-Iterator-Rule - Iterative,
recursive file finder

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are usable. Ok.
Source archive is original (SHA-256:
6a450cc4c6281ed1129f32a1c0741f228967feda2e32a2915ff621c36525fcbe). Ok.
Summary verified from lib/Test/Filename.pm. Ok.
Description verified from lib/Test/Filename.pm. Ok.
License verified from README, LICENSE, and lib/Test/Filename.pm. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Package `Todo' file and `examples' directory as documentation.
TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30'
(Makefile.PL:7).

FIX: Build-require `findutils' (perl-Test-Filename.spec:43).
FIX: Build-require `perl(strict)' (Makefile.PL:2).
FIX: Build-require `perl(File::Find)' (t/00-compile.t:10).

All tests pass. Ok.

$ rpmlint perl-Test-Filename.spec
../SRPMS/perl-Test-Filename-0.03-1.fc26.src.rpm
../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Sep  6 08:46
/usr/share/doc/perl-Test-Filename
-rw-r--r--    1 root    root                      465 Jan 31  2013
/usr/share/doc/perl-Test-Filename/Changes
-rw-r--r--    1 root    root                     2806 Jan 31  2013
/usr/share/doc/perl-Test-Filename/README
drwxr-xr-x    2 root    root                        0 Sep  6 08:46
/usr/share/licenses/perl-Test-Filename
-rw-r--r--    1 root    root                    11503 Jan 31  2013
/usr/share/licenses/perl-Test-Filename/LICENSE
-r--r--r--    1 root    root                     2450 Sep  6 08:46
/usr/share/man/man3/Test::Filename.3pm.gz
drwxr-xr-x    2 root    root                        0 Sep  6 08:46
/usr/share/perl5/vendor_perl/Test
-r--r--r--    1 root    root                     3667 Jan 31  2013
/usr/share/perl5/vendor_perl/Test/Filename.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm
| sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(Test::Builder::Module)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm
| sort -f | uniq -c
      1 perl(Test::Filename) = 0.03
      1 perl-Test-Filename = 0.03-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=15513386). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items, consider fixing `TODO' items, and provide a new
spec file.
Resolution: Package NOT approved.

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #2 from Sandro Mani  ---
Spec URL: https://smani.fedorapeople.org/review/perl-Test-Filename.spec
SRPM URL:
https://smani.fedorapeople.org/review/perl-Test-Filename-0.03-2.fc26.src.rpm

%changelog
* Tue Sep 06 2016 Sandro Mani  - 0.03-2
- BR: findutils, perl(File::Find), perl(strict)
- BR: perl(ExtUtils::MakeMaker) >= 6.30
- Add to %%doc: Todo, examples

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar  ---
Spec file changes:

--- perl-Test-Filename.spec.old 2016-09-05 16:36:19.000000000 +0200
+++ perl-Test-Filename.spec     2016-09-06 09:59:51.000000000 +0200
@@ -1,6 +1,6 @@
 Name:           perl-Test-Filename
 Version:        0.03
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Portable filename comparison
 License:        ASL 2.0

@@ -9,13 +9,16 @@
 BuildArch:      noarch

BuildRequires:  make
+BuildRequires:  findutils
 BuildRequires:  perl
 BuildRequires:  perl-generators
 BuildRequires:  perl(English)
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
+BuildRequires:  perl(File::Find)
 BuildRequires:  perl(File::Spec::Functions)
 BuildRequires:  perl(File::Temp)
 BuildRequires:  perl(Path::Tiny)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::Builder::Module)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Tester)
@@ -48,12 +51,17 @@

%files
-%doc Changes README
+%doc Changes README Todo examples
 %license LICENSE
 %{perl_vendorlib}/*
 %{_mandir}/man3/Test::Filename*.*

%changelog
+* Tue Sep 06 2016 Sandro Mani  - 0.03-2
+- BR: findutils, perl(File::Find), perl(strict)
+- BR: perl(ExtUtils::MakeMaker) >= 6.30
+- Add to %%doc: Todo, examples
+
 * Mon Sep 05 2016 Sandro Mani  - 0.03-1
 - Initial package
> TODO: Package `Todo' file and `examples' directory as documentation.

-%doc Changes README
+%doc Changes README Todo examples
Ok.
> TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30'
> (Makefile.PL:7).

-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
Ok.
> FIX: Build-require `findutils' (perl-Test-Filename.spec:43).

+BuildRequires:  findutils
Ok.
> FIX: Build-require `perl(strict)' (Makefile.PL:2).

+BuildRequires:  perl(strict)
Ok.
> FIX: Build-require `perl(File::Find)' (t/00-compile.t:10).

+BuildRequires:  perl(File::Find)
Ok.

$ rpmlint perl-Test-Filename.spec
../SRPMS/perl-Test-Filename-0.03-2.fc26.src.rpm
../RPMS/noarch/perl-Test-Filename-0.03-2.fc26.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=15515888). Ok.

Package is good.
Resolution: Package APPROVED.

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #4 from Sandro Mani  ---
Many thanks!

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Filename

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #6 from Fedora Update System  ---
perl-Test-Filename-0.03-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c075fd371d

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  ---
perl-Test-Filename-0.03-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c075fd371d

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

--- Comment #8 from Fedora Update System  ---
perl-Test-Filename-0.03-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-09-10 17:00:07