https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Bug ID: 1666295 Summary: Review Request: perl-Data-Binary - Simple detection of binary versus text in strings Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: paul@city-fan.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Data-Binary/branches/fedo...
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Data-Binary/perl-Data-Binary-0.01-...
Description: This simple module provides string equivalents to the -T / -B operators. Since these only work on file names and file handles, this module provides the same functions but on strings.
Note that the actual implementation is currently different, basically because the -T / -B functions are in C/XS, and this module is written in pure Perl. For now, anyway.
Fedora Account System Username: pghmcfc
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1666227
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1666227 [Bug 1666227] Upgrade perl-Module-CPANTS-Analyse to 0.99
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok
FIX: URL is wrong. It is link to Data-UUID. Please replace it with https://metacpan.org/release/Data-Binary
Source0 is ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Encode) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c 1 perl(Data::Binary) = 0.01 1 perl-Data-Binary = 0.01-1.fc30 Binary provides are Ok.
$ rpmlint ./perl-Data-Binary* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok
Please correct 'FIX' issue.
Otherwise the package looks good. Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #2 from Paul Howarth paul@city-fan.org --- Thanks Jitka, copy and paste error there, will fix on import.
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Binary
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-eb5fbe3e83
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-01-24 03:31:51
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1666295
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Data-Binary-0.01-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org