[Bug 2156960] New: Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Bug ID: 2156960
           Summary: Review Request: rust-wu-diff - Compute differences
                    between two slices using wu(the O(NP)) algorithm
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://salimma.fedorapeople.org/rust-wu-diff.spec
SRPM URL: https://salimma.fedorapeople.org/rust-wu-diff-0.1.2-1.fc37.src.rpm

Description:
Compute differences between two slices using wu(the O(NP)) algorithm.

Fedora Account System Username: salimma

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2156961
                   |                            |(ITP-rust-difftastic)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2156961
[Bug 2156961] ITP: rust-difftastic - Structural diff that understands syntax

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Davide Cavalca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Davide Cavalca  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #2 from Michel Alexandre Salim  ---
Thanks!

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ set -gx C wu-diff

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ set -gx B 2156960

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50070

src/fedora/pkgs-sig-rust took 4s
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50071

src/fedora/pkgs-sig-rust took 7s
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50072
https://pagure.io/releng/fedora-scm-requests/issue/50073

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #3 from Kevin Fenzi  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-wu-diff

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Fabio Valentini  ---
> package builds and installs without errors on rawhide

Have you actually checked this or did you only paste my review template?
One of the built packages fails to install with a missing dependency:

Error: 
 Problem: conflicting requests
  - nothing provides (crate(clippy/default) >= 0.0.209 with
crate(clippy/default) < 0.0.210~) needed by
rust-wu-diff+clippy-devel-0.1.2-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
not only best candidate packages)
WARNING: Failed install built packages

i.e. the optional dependency on "clippy" (which is the ancient version of the
clippy toolchain component which hasn't been distributed as a separate crate
for over four years) needs to be removed

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #5 from Michel Alexandre Salim  ---
Thanks for catching that! Dependency dropped

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-01-08 01:20:07

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2156960] Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=2156960

--- Comment #12 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.