https://bugzilla.redhat.com/show_bug.cgi?id=1727773
Bug ID: 1727773 Summary: Review Request: radiotray-ng - An Internet radio player for Linux Product: Fedora Version: 30 Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Vascom/radiotray-ng/master/radiotray-ng.sp... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4657/36124657/radiotray-ng-0....
Description: It is reborn of Radio Tray - an online radio streaming player.
Homepage https://github.com/ebruck/radiotray-ng
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
Artem ego.cordatus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ego.cordatus@gmail.com Assignee|nobody@fedoraproject.org |ego.cordatus@gmail.com Flags| |fedora-review?
--- Comment #1 from Artem ego.cordatus@gmail.com --- 1. Replace: Source0: %{url}/archive/v%{version}.tar.gz with Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
2. Express -devel package in BR with 'pkg-config'
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
--- Comment #2 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/radiotray-ng/master/radiotray-ng.sp... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6233/36126233/radiotray-ng-0....
Done.
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
--- Comment #3 from Artem ego.cordatus@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package must not depend on deprecated() packages. Note: python2 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons Attribution-NoDerivatives Public License (v3.0)", "GPL (v3 or later)". 57 files have unknown license. Detailed output of licensecheck in /home/tim/1727773-radiotray-ng/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in radiotray-ng [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: radiotray-ng-0.2.6-1.fc31.x86_64.rpm radiotray-ng-debuginfo-0.2.6-1.fc31.x86_64.rpm radiotray-ng-debugsource-0.2.6-1.fc31.x86_64.rpm radiotray-ng-0.2.6-1.fc31.src.rpm radiotray-ng.x86_64: W: no-manual-page-for-binary radiotray-ng radiotray-ng.x86_64: W: no-manual-page-for-binary rt2rtng radiotray-ng.x86_64: W: no-manual-page-for-binary rtng-bookmark-editor 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (debuginfo) ------------------- Checking: radiotray-ng-debuginfo-0.2.6-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/ebruck/radiotray-ng/archive/v0.2.6.tar.gz : CHECKSUM(SHA256) this package : 05e1b9ac7342b276fff6395a38719264f9bc47b28aadd4938c5bbe3303c67553 CHECKSUM(SHA256) upstream package : 05e1b9ac7342b276fff6395a38719264f9bc47b28aadd4938c5bbe3303c67553
Requires -------- radiotray-ng (rpmlib, GLIBC filtered): /usr/bin/python2.7 hicolor-icon-theme libappindicator3.so.1()(64bit) libboost_filesystem.so.1.69.0()(64bit) libboost_log.so.1.69.0()(64bit) libboost_program_options.so.1.69.0()(64bit) libboost_thread.so.1.69.0()(64bit) libbsd.so.0()(64bit) libbsd.so.0(LIBBSD_0.2)(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libgiomm-2.4.so.1()(64bit) libglib-2.0.so.0()(64bit) libglibmm-2.4.so.1()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjsoncpp.so.21()(64bit) libm.so.6()(64bit) libnotify.so.4()(64bit) libpthread.so.0()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) libxdg-basedir.so.1()(64bit) rtld(GNU_HASH)
radiotray-ng-debuginfo (rpmlib, GLIBC filtered):
radiotray-ng-debugsource (rpmlib, GLIBC filtered):
Provides -------- radiotray-ng: application() application(radiotray-ng.desktop) application(rtng-bookmark-editor.desktop) metainfo() metainfo(radiotray-ng.appdata.xml) radiotray-ng radiotray-ng(x86-64)
radiotray-ng-debuginfo: debuginfo(build-id) radiotray-ng-debuginfo radiotray-ng-debuginfo(x86-64)
radiotray-ng-debugsource: radiotray-ng-debugsource radiotray-ng-debugsource(x86-64)
Diff spec file in url and in SRPM --------------------------------- --- /home/tim/1727773-radiotray-ng/srpm/radiotray-ng.spec 2019-07-08 10:36:09.582522037 +0300 +++ /home/tim/1727773-radiotray-ng/srpm-unpacked/radiotray-ng.spec 2019-07-08 09:38:47.000000000 +0300 @@ -32,4 +32,5 @@ # Correct build flags sed -i 's|-Wno-deprecated-declarations -Wall -Wextra -Werror -Wpedantic|%{optflags}|' CMakeLists.txt +# sed -i 's|FLAGS_RELEASE} -s|FLAGS_RELEASE}|' CMakeLists.txt sed -i '/execute_process(COMMAND lsb_release/d' package/CMakeLists.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
--- Comment #4 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/radiotray-ng/master/radiotray-ng.sp... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7137/36127137/radiotray-ng-0....
Removed python2 dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
Artem ego.cordatus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags|fedora-review? |fedora-review+
--- Comment #5 from Artem ego.cordatus@gmail.com --- Now LGTM. Package approved.
Package Review ==============
Rpmlint ------- Checking: radiotray-ng-0.2.6-2.fc31.x86_64.rpm radiotray-ng-debuginfo-0.2.6-2.fc31.x86_64.rpm radiotray-ng-debugsource-0.2.6-2.fc31.x86_64.rpm radiotray-ng-0.2.6-2.fc31.src.rpm radiotray-ng.x86_64: W: no-manual-page-for-binary radiotray-ng radiotray-ng.x86_64: W: no-manual-page-for-binary rtng-bookmark-editor 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Source checksums ---------------- https://github.com/ebruck/radiotray-ng/archive/v0.2.6/radiotray-ng-0.2.6.tar... : CHECKSUM(SHA256) this package : 05e1b9ac7342b276fff6395a38719264f9bc47b28aadd4938c5bbe3303c67553 CHECKSUM(SHA256) upstream package : 05e1b9ac7342b276fff6395a38719264f9bc47b28aadd4938c5bbe3303c67553
Requires -------- radiotray-ng (rpmlib, GLIBC filtered): hicolor-icon-theme libappindicator3.so.1()(64bit) libboost_filesystem.so.1.69.0()(64bit) libboost_log.so.1.69.0()(64bit) libboost_program_options.so.1.69.0()(64bit) libboost_thread.so.1.69.0()(64bit) libbsd.so.0()(64bit) libbsd.so.0(LIBBSD_0.2)(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libgiomm-2.4.so.1()(64bit) libglib-2.0.so.0()(64bit) libglibmm-2.4.so.1()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjsoncpp.so.21()(64bit) libm.so.6()(64bit) libnotify.so.4()(64bit) libpthread.so.0()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) libxdg-basedir.so.1()(64bit) rtld(GNU_HASH)
Provides -------- radiotray-ng: application() application(radiotray-ng.desktop) application(rtng-bookmark-editor.desktop) metainfo() metainfo(radiotray-ng.appdata.xml) radiotray-ng radiotray-ng(x86-64)
radiotray-ng-debuginfo: debuginfo(build-id) radiotray-ng-debuginfo radiotray-ng-debuginfo(x86-64)
radiotray-ng-debugsource: radiotray-ng-debugsource radiotray-ng-debugsource(x86-64)
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/radiotray-ng
https://bugzilla.redhat.com/show_bug.cgi?id=1727773
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-07-09 06:01:35
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com