[Bug 2371335] New: Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Bug ID: 2371335
           Summary: Review Request: nodejs-postcss-url - PostCSS plugin to
                    rebase, inline or copy on url()
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/nikromen/fedora-pre-relea...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/nikromen/fedora-pre-relea...

Description:
PostCSS plugin to rebase, inline or copy on url()

Fedora Account System Username:
nikromen

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Jiří Kyjovský  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2360489

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2360489
[Bug 2360489] Review Request: anubis - Weighs the soul of incoming HTTP
requests using proof-of-work to stop AI crawlers

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/postcss/
                   |                            |%{npm_name}

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9150229
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- License file LICENSE.md is not marked as %license
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #2 from Jakub Kadlčík  ---
> License file LICENSE.md is not marked as %license
>
> Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...

I don't know about this. I can't see any LICENSE.md file anywhere. Maybe a
false-positive?
> %check

The example spec file at
https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_example_...
runs tests with

# Run tests/
    ./node_modules/.bin/tap test/*.js

but our tarball doesn't have the test directory. Upstream has it but not the
npm registry tarball. I would keep the spec as is.

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #3 from Jakub Kadlčík  ---
> License:        ISC AND MIT

There used to be a rule that if a package has multiple licenses, there should
be a "license breakdown" in a comment above the License field. It seems the
requirement was dropped accidentally -
https://gitlab.com/fedora/legal/fedora-legal-docs/-/issues/64

Let's play it safe. Can you please do the breakdown?

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Jiří Kyjovský  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/nikromen/fedora-pre-relea...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/nikromen/fedora-pre-relea...

Description:
PostCSS plugin to rebase, inline or copy on url()

Fedora Account System Username:
nikromen

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #4 from Jiří Kyjovský  ---
> I don't know about this. I can't see any LICENSE.md file anywhere. Maybe a false-positive?

This ale seems to me like false positive.
> Let's play it safe. Can you please do the breakdown?

Thanks for looking to it, updated.

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #5 from Jakub Kadlčík  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.md is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "*No copyright* ISC License and/or MIT License", "ISC
     License", "*No copyright* ISC License". 104 files have unknown
     license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/nodejs-postcss-url/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 7278 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define _description PostCSS
     plugin to rebase, inline or copy on url()
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.

Rpmlint
-------
Checking: nodejs-postcss-url-10.1.3-1.fc43.noarch.rpm
          nodejs-postcss-url-10.1.3-1.fc43.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpy11egkuk')]
checks: 32, packages: 2

nodejs-postcss-url.noarch: E: spelling-error ('rebase', 'Summary(en_US) rebase
-> rebate, debase, re base')
nodejs-postcss-url.noarch: E: spelling-error ('rebase', '%description -l en_US
rebase -> rebate, debase, re base')
nodejs-postcss-url.src: E: spelling-error ('rebase', 'Summary(en_US) rebase ->
rebate, debase, re base')
nodejs-postcss-url.src: E: spelling-error ('rebase', '%description -l en_US
rebase -> rebate, debase, re base')
nodejs-postcss-url.noarch: W: only-non-binary-in-usr-lib
nodejs-postcss-url.spec: W: invalid-url Source2: postcss-url-10.1.3-nm-dev.tgz
nodejs-postcss-url.spec: W: invalid-url Source1: postcss-url-10.1.3-nm-prod.tgz
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules/.bin
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/.bin
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/.bin
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/.package-lock.json
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/balanced-match/.github
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/balanced-match/.github
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/concat-map/.travis.yml
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/cuint/.npmignore
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/make-dir/node_modules/.bin
nodejs-postcss-url.noarch: W: hidden-file-or-dir
/usr/lib/node_modules_22/postcss-url/node_modules_prod/make-dir/node_modules/.bin
nodejs-postcss-url.noarch: W: files-duplicate
/usr/lib/node_modules_22/postcss-url/node_modules_prod/cuint/lib/uint32.js
/usr/lib/node_modules_22/postcss-url/node_modules_prod/cuint/build/uint32.js
nodejs-postcss-url.noarch: W: files-duplicate
/usr/lib/node_modules_22/postcss-url/node_modules_prod/cuint/lib/uint64.js
/usr/lib/node_modules_22/postcss-url/node_modules_prod/cuint/build/uint64.js
nodejs-postcss-url.noarch: W: files-duplicate
/usr/lib/node_modules_22/postcss-url/node_modules_prod/minimatch/LICENSE
/usr/lib/node_modules_22/postcss-url/node_modules_prod/make-dir/node_modules/semver/LICENSE
 2 packages and 0 specfiles checked; 4 errors, 16 warnings, 8 filtered, 4
badness; has taken 0.6 s

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s 
(none): E: there is no installed rpm "nodejs-postcss-url".
There are no files to process nor additional arguments.
Nothing to do, aborting.

Source checksums
----------------
https://registry.npmjs.org/postcss-url/-/postcss-url-10.1.3.tgz :
  CHECKSUM(SHA256) this package     :
0518bc6d66f0d33550bb93fc9253c855683bc0e20afdd9fa6205291b4cae3c77
  CHECKSUM(SHA256) upstream package :
0518bc6d66f0d33550bb93fc9253c855683bc0e20afdd9fa6205291b4cae3c77

Requires
--------
nodejs-postcss-url (rpmlib, GLIBC filtered):
    /usr/bin/node
    nodejs

Provides
--------
nodejs-postcss-url:
    bundled(nodejs-balanced-match)
    bundled(nodejs-brace-expansion)
    bundled(nodejs-concat-map)
    bundled(nodejs-cuint)
    bundled(nodejs-make-dir)
    bundled(nodejs-mime)
    bundled(nodejs-minimatch)
    bundled(nodejs-semver)
    bundled(nodejs-xxhashjs)
    nodejs-postcss-url
    npm(postcss-url)

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
nodejs-postcss-url --mock-config
/var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Python, Haskell, SugarActivity, Perl, fonts, C/C++, Ocaml,
PHP, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #6 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-postcss-url

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #7 from Fedora Update System  ---
FEDORA-2025-1dce6d2b0d (nodejs-postcss-url-10.1.3-1.fc41) has been submitted as
an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dce6d2b0d

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #8 from Fedora Update System  ---
FEDORA-2025-7781db5809 (nodejs-postcss-url-10.1.3-1.fc42) has been submitted as
an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7781db5809

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #9 from Fedora Update System  ---
FEDORA-2025-7781db5809 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2025-7781db5809 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7781db5809

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2371335] Review Request: nodejs-postcss-url - PostCSS plugin to rebase, inline or copy on url()

https://bugzilla.redhat.com/show_bug.cgi?id=2371335

--- Comment #10 from Fedora Update System  ---
FEDORA-2025-1dce6d2b0d has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2025-1dce6d2b0d *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dce6d2b0d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.