[Bug 1809927] New: Review Request: python-aiostream - Generator-based operators for asynchronous iteration
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Bug ID: 1809927 Summary: Review Request: python-aiostream - Generator-based operators for asynchronous iteration Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream-0.4.1-1.fc31.sr...
Project URL: https://github.com/vxgmichel/aiostream
Description: aiostream provides a collection of stream operators that can be combined to create asynchronous pipelines of operations.
It can be seen as an asynchronous version of itertools, although some aspects are slightly different. Essentially, all the provided operators return a unified interface called a stream.
A stream is an enhanced asynchronous iterable providing the following features:
- Operator pipe-lining - using pipe symbol | - Repeatability - every iteration creates a different iterator - Safe iteration context - using async with and the stream method - Simplified execution - get the last element from a stream using await - Slicing and indexing - using square brackets [] - Concatenation - using addition symbol +
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42171096
rpmlint output: $ rpmlint python-aiostream-0.4.1-1.fc31.src.rpm python-aiostream.src: W: spelling-error %description -l en_US itertools -> iterators python-aiostream.src: W: spelling-error %description -l en_US iterable -> alterable, tolerable, iterate python-aiostream.src: W: spelling-error %description -l en_US async -> sync, a sync 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint python3-aiostream-0.4.1-1.fc31.noarch.rpm python3-aiostream.noarch: W: spelling-error %description -l en_US itertools -> iterators python3-aiostream.noarch: W: spelling-error %description -l en_US iterable -> alterable, tolerable, iterate python3-aiostream.noarch: W: spelling-error %description -l en_US async -> sync, a sync 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - You must install the LICENSE with %license in %files
%license LICENSE
- Missing packages for the tests:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.qsWK1s + umask 022 + cd /builddir/build/BUILD + cd aiostream-0.4.1 + /usr/bin/python3 setup.py test WARNING: The pip package is not available, falling back to EasyInstall for handling setup_requires/test_requires; this is deprecated and will be removed in a future version. Download error on https://pypi.org/simple/pytest-runner/: [Errno -2] Name or service not known -- Some packages may not be found! Couldn't find index page for 'pytest-runner' (maybe misspelled?) Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found! No local packages or working download links found for pytest-runner Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/setuptools/installer.py", line 62, in fetch_build_egg pkg_resources.get_distribution('pip') File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 482, in get_distribution dist = get_provider(dist) File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 358, in get_provider return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0] File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 901, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 787, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The 'pip' distribution was not found and is required by the application During handling of the above exception, another exception occurred: Traceback (most recent call last): File "setup.py", line 14, in <module> setup( File "/usr/lib/python3.8/site-packages/setuptools/__init__.py", line 143, in setup _install_setup_requires(attrs) File "/usr/lib/python3.8/site-packages/setuptools/__init__.py", line 138, in _install_setup_requires dist.fetch_build_eggs(dist.setup_requires) File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 684, in fetch_build_eggs resolved_dists = pkg_resources.working_set.resolve( File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 781, in resolve dist = best[req.key] = env.best_match( File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1066, in best_match return self.obtain(req, installer) File "/usr/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1078, in obtain return installer(requirement) File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 743, in fetch_build_egg return fetch_build_egg(self, req) File "/usr/lib/python3.8/site-packages/setuptools/installer.py", line 70, in fetch_build_egg return _legacy_fetch_build_egg(dist, req) File "/usr/lib/python3.8/site-packages/setuptools/installer.py", line 53, in _legacy_fetch_build_egg return cmd.easy_install(req) File "/usr/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 686, in easy_install raise DistutilsError(msg) distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
BuildRequires: python3-pytest-runner
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 45 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python- aiostream/review-python-aiostream/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-aiostream-0.4.1-1.fc33.noarch.rpm python-aiostream-0.4.1-1.fc33.src.rpm python3-aiostream.noarch: W: spelling-error %description -l en_US itertools -> iterators python3-aiostream.noarch: W: spelling-error %description -l en_US iterable -> alterable, tolerable, iterate python3-aiostream.noarch: W: spelling-error %description -l en_US async -> sync, a sync python-aiostream.src: W: spelling-error %description -l en_US itertools -> iterators python-aiostream.src: W: spelling-error %description -l en_US iterable -> alterable, tolerable, iterate python-aiostream.src: W: spelling-error %description -l en_US async -> sync, a sync 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for your feedback.
(In reply to Robert-André Mauchin from comment #1)
- You must install the LICENSE with %license in %files
%license LICENSE
Added
BuildRequires: python3-pytest-runner
Added
%changelog * Mon Mar 23 2020 Fabian Affolter mail@fabian-affolter.ch - 0.4.1-2 - Add missing BR - Add LICENSE file (rhbz#1809927)
Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream-0.4.1-2.fc31.sr...
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #4 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiostream
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-6ca6c609db has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6ca6c609db
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-e2a91f1c23 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e2a91f1c23
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-e2a91f1c23 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e2a91f1c23 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e2a91f1c23
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-6ca6c609db has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-6ca6c609db *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6ca6c609db
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-04-05 00:15:28
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-6ca6c609db has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1809927
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-e2a91f1c23 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com