Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884497
Bug ID: 884497 Summary: Review request: perl-Math-BigInt - Arbitrary size integer/float math package Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Reporter: mmaslano@redhat.com
SPEC: http://mmaslano.fedorapeople.org/review/perl-Math-BigInt.spec SRPM: http://mmaslano.fedorapeople.org/review/perl-Math-BigInt-1.997-1.fc18.src.rp... Description: All operators (including basic math operations) are overloaded if you declare your big integers as documented. Operations with overloaded operators preserve the arguments which is exactly what you expect. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4762700
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884497
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884497
--- Comment #1 from Petr Šabata psabata@redhat.com --- Issues:
1. This module is provided by the perl package and needs to be subpackaged first to resolve the conflicts.
2. Either buildrequires perl(inc::Module::Install) or explicitly list inc/* dependencies.
3. Buildrequire the package (lib/*) dependencies. This is required since you run the test suite.
4. The same applies to the test suite dependencies (t/*).
5. Require MODULE_COMPAT macro.
6. Your %__provides_exclude macro doesn't make much sense. In case you wanted to exlude unversioned Math::BigInt provides, change 'requires' further on the line to 'provides' too.
7. Require undetected runtime deps (Carp, Exporter, File::Spec)
8. The description is an incomplete sentence.
https://bugzilla.redhat.com/show_bug.cgi?id=884497
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com
--- Comment #2 from Petr Pisar ppisar@redhat.com --- The CPAN package is older (0.997) than modules in the latest stable perl:
$ corelist -v 5.18.1 |grep Math::BigInt Math::BigInt 1.9991 Math::BigInt::Calc 1.997 Math::BigInt::CalcEmu 1.998 Math::BigInt::FastCalc 0.30 Math::BigInt::Trace 0.32
I guess there is no point in creating standalone package. Though we could sub-package it.
https://bugzilla.redhat.com/show_bug.cgi?id=884497
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Last Closed| |2013-12-04 07:46:03
--- Comment #3 from Marcela Mašláňová mmaslano@redhat.com --- Ok, closing now.
https://bugzilla.redhat.com/show_bug.cgi?id=884497
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1277203
https://bugzilla.redhat.com/show_bug.cgi?id=884497
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
package-review@lists.fedoraproject.org