[Bug 1438089] New: Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Bug ID: 1438089 Summary: Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go-3.13...
Description: Production-Grade Reliable-UDP Library for golang
Fedora Account System Username: decathorpe
I can't provide a koji scratch build yet, since some dependencies are not yet available on fedora (marked as blocker bugs). With local builds (present dependencies) I had to disable tests, since they hit "too many open files" errors in mock chroots, where I can't set "ulimit -n 102400" - or something like that.
This go package is one of the new dependencies of syncthing 0.14.25.
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1427634 Depends On| |1437471
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1427634 [Bug 1427634] Review Request: syncthing - Continuous File Synchronization https://bugzilla.redhat.com/show_bug.cgi?id=1437471 [Bug 1437471] Review Request: golang-github-klauspost-reedsolomon - Reed-Solomon Erasure Coding in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- I've updated the packaging for the latest stable version of the golang package.
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go-3.15...
Additionally, I've reported the test failures upstream, maybe they can be resolved: https://github.com/xtaci/kcp-go/issues/40
https://bugzilla.redhat.com/show_bug.cgi?id=1438089 Bug 1438089 depends on bug 1437471, which changed state.
Bug 1437471 Summary: Review Request: golang-github-klauspost-reedsolomon - Reed-Solomon Erasure Coding in Go https://bugzilla.redhat.com/show_bug.cgi?id=1437471
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- The failing test needs more than 1024 open sockets to succeed, which results in more open files than fedora's default setting (1024) allows. As a result, I have disabled that test with a patch.
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #3 from Athos Ribeiro athoscribeiro@gmail.com --- Hi Fabio,
The package looks good!
Before approving it, do you have any comments on the images provided by upstream? In special, shannon.jpg. I did not find a license tag nor the original file.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. github-xtaci-kcp-go-devel , golang-github-xtaci-kcp-go-unit-test-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-xtaci-kcp-go-devel-3.15-1.fc27.noarch.rpm golang-github-xtaci-kcp-go-unit-test-devel-3.15-1.fc27.x86_64.rpm golang-github-xtaci-kcp-go-3.15-1.fc27.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- golang-github-xtaci-kcp-go-devel (rpmlib, GLIBC filtered): golang(github.com/klauspost/reedsolomon) golang(github.com/pkg/errors) golang(golang.org/x/crypto/blowfish) golang(golang.org/x/crypto/cast5) golang(golang.org/x/crypto/pbkdf2) golang(golang.org/x/crypto/salsa20) golang(golang.org/x/crypto/tea) golang(golang.org/x/crypto/twofish) golang(golang.org/x/crypto/xtea) golang(golang.org/x/net/ipv4)
golang-github-xtaci-kcp-go-unit-test-devel (rpmlib, GLIBC filtered): golang-github-xtaci-kcp-go-devel
Provides -------- golang-github-xtaci-kcp-go-devel: golang(github.com/xtaci/kcp-go) golang-github-xtaci-kcp-go-devel
golang-github-xtaci-kcp-go-unit-test-devel: golang-github-xtaci-kcp-go-unit-test-devel golang-github-xtaci-kcp-go-unit-test-devel(x86-64)
Source checksums ---------------- https://github.com/xtaci/kcp-go/archive/e820b1bd15f3e98fabd014eab5585b5cf55d... : CHECKSUM(SHA256) this package : 07e4d14459b2888ef6e579ce3f019a0abac56b2e21ff26e8ee75f302d31071a5 CHECKSUM(SHA256) upstream package : 07e4d14459b2888ef6e579ce3f019a0abac56b2e21ff26e8ee75f302d31071a5
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- All pictures are only referenced and used by the README.md file. They aren't part of the produced binary RPMs, only of the upstream source tarball.
I found the original image source (Photo by Alfred Eisenstaedt/The LIFE Picture Collection/Getty Images), and the picture was taken in 1963.
I'm not sure how to proceed here, since the pictures aren't used by my packaging at all - do I have to produce a "special" tarball that differs from upstream's sources, just because of a file that I don't use anyway?
Blocking FE-Legal to get a definitive answer (because I'd rather not create a downstream tarball for no good reason).
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com
--- Comment #5 from Tom "spot" Callaway tcallawa@redhat.com --- Yeah, Getty Images does not mess around with licensing. You need to remove this image from the source tarball and use a "clean" tarball. I'd also strongly recommend that you open an issue with upstream to ask them to remove that jpg.
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Tom, thanks for looking into this!
I just informed upstream that they might want to stop using/distributing the picture [1].
If this can be resolved upstream soon-ish, I'll update the upstream tarball to a snapshot not containing the picture. If not, I'll write a script for generating a "clean" tarball.
[1]: https://github.com/xtaci/kcp-go/issues/42
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|182235 (FE-Legal) |
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Upstream has removed the picture in question, unblocking FE-Legal.
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go-3.15...
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from Athos Ribeiro athoscribeiro@gmail.com --- Package looks good now.
Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #9 from Fabio Valentini decathorpe@gmail.com --- Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #10 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-xtaci-kcp-g...
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bbbfd7ca0f
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-55a467330b
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2141376bf0
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bbbfd7ca0f
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2141376bf0
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-55a467330b
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-05-19 15:03:55
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com