[Bug 599506] New: Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-war-plugin - Maven WAR Plugin

https://bugzilla.redhat.com/show_bug.cgi?id=599506

Summary: Review Request: maven-war-plugin - Maven WAR Plugin
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-p...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-p...
Description: Builds a Web Application Archive (WAR) file from the project
output and its dependencies.

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2226988

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

--- Comment #1 from Weinan Li  2010-06-03 08:02:34 EDT ---
The above scratch build is incorrect, please use this one:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2227001

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #2 from Alexander Kurtakov  2010-06-04 10:09:14 EDT ---
I'll take this one.

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

--- Comment #3 from Alexander Kurtakov  2010-06-04 10:24:05 EDT ---
Review:

FIXIT: rpmlint must be run on every package. Output:
maven-war-plugin.noarch: W: incoherent-version-in-changelog 0:2.1-0.1.b1
['2.1-0.1.b1.fc13', '2.1-0.1.b1']
Fix it.

maven-war-plugin.noarch: W: no-documentation
maven-war-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-war-plugin

False positives.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.    
OK: Provides/Obsoletes are good.

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

--- Comment #4 from Weinan Li  2010-06-07 04:27:06 EDT ---
- Fix incoherent version in changelog

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-p...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-p...
Description: Builds a Web Application Archive (WAR) file from the project
output and its dependencies.

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2234872

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Alexander Kurtakov  2010-06-07 04:42:41 EDT ---
Thanks,
This package is APPROVED.

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

--- Comment #6 from Weinan Li  2010-06-07 05:21:56 EDT ---
New Package CVS Request
=======================
Package Name: maven-war-plugin
Short Description: Builds a Web Application Archive (WAR) file from the project
output and its dependencies.
Owners: weli
Branches: 
InitialCC:

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

Weinan Li  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

--- Comment #7 from Kevin Fenzi  2010-06-07 17:10:44 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599506

Weinan Li  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE