[Bug 1804768] New: Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Bug ID: 1804768
           Summary: Review Request:  catatonit - A signal-forwarding
                    process manager for containers
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: ASSIGNED
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec
SRPM URL:
https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.4-1.src.rpm

Description:
Catatonit is a /sbin/init program for use within containers. It
forwards (almost) all signals to the spawned child, tears down
the container when the spawned child exits, and otherwise
cleans up other exited processes (zombies).

This is a reimplementation of other container init programs (such as
"tini" or "dumb-init"), but uses modern Linux facilities (such as
signalfd(2)) and has no additional features.

Fedora Account System Username: lsm5

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=41654500

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #1 from Olivier Samyn  ---
Once this is accepted, I suppose a patch to the podman package will be needed
to depend on this one.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #2 from Daniel Walsh  ---
Make sure it is a Recommends not a Requires.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Jindrich Novy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail])

--- Comment #3 from Jindrich Novy  ---
Looking at this in the spec:
---
# Make sure we *always* build a static binary. Otherwise we'll break containers

# that don't have the necessary shared libs.

file ./%{name} | grep 'statically linked'
---

Suggest to provide some human readable message in the build log: Why this has
to be statically linked. Then the spec comment is then not required.

FYI: The src.rpm link in the description doesn't work.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail])  |

--- Comment #4 from Lokesh Mandvekar  ---
Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec
SRPM URL:
https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.5-1.fc32.src.r...

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43891594

Jindrich, I'll post the SRPM somewhere else if this still doesn't work.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #5 from Lokesh Mandvekar  ---
Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec
SRPM URL:
https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.5-2.fc32.src.r...

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Jindrich Novy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Jindrich Novy  ---
LGTM. Thanks Lokesh!

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/catatonit

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2020-f8f80a3c1c has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #9 from Fedora Update System  ---
FEDORA-2020-9aeddd91c6 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System  ---
FEDORA-2020-f8f80a3c1c has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-f8f80a3c1c *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #11 from Fedora Update System  ---
FEDORA-2020-9aeddd91c6 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-9aeddd91c6 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2020-05-08 02:44:22

--- Comment #12 from Fedora Update System  ---
FEDORA-2020-f8f80a3c1c has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers

https://bugzilla.redhat.com/show_bug.cgi?id=1804768

--- Comment #13 from Fedora Update System  ---
FEDORA-2020-9aeddd91c6 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.