[Bug 967332] New: Review Request: rubygem-chardet - Character encoding auto-detection in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=967332
Bug ID: 967332 Summary: Review Request: rubygem-chardet - Character encoding auto-detection in Ruby Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: anujmorex@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-chardet/rubygem-chardet.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-chardet/rubygem-chardet-0.9.0-... Description: Character encoding auto-detection in Ruby Fedora Account System Username: anujmore
https://bugzilla.redhat.com/show_bug.cgi?id=967332
--- Comment #1 from Anuj More anujmorex@gmail.com --- Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-chardet/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=967332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jstribny@redhat.com Assignee|nobody@fedoraproject.org |jstribny@redhat.com
--- Comment #2 from Josef Stribny jstribny@redhat.com --- I will take it for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=967332
--- Comment #3 from Josef Stribny jstribny@redhat.com ---
From your spec file:
``` # URL: http://blog.vava.cn/ # This URL is mentioned in the Gem but doesn't open URL: https://github.com/janx/chardet ```
The original chardet gem is actually hosted on RubyForge[1] and maintained by Hui Zheng. The release is from 2006 and I don't see any new development or updates here.
The URL you are mentioning belongs to chardet2[2], which is pretty new, it's based on chardet and seems to be maintained.
Apart from that I am unsure whether is chardet Ruby 2.0 ready or not, since I can see that there is a commit regarding Ruby 2.0 compatibility in chardet2[3]. Fedora 19 will use Ruby 2.0 as a default and it would be pointless to package a sort-of dead project that wasn't tested on Ruby 2.0 (although backporting of the above mentioned commit could solve it).
Is there a reason to package this gem? Wouldn't be better to bring chardet2 to Fedora?
[1] http://rubyforge.org/projects/chardet/ [2] https://rubygems.org/gems/chardet2 [3] https://github.com/janx/chardet2/commit/32cc6147b2e519eb3bd777e0bc854b5bfac1...
https://bugzilla.redhat.com/show_bug.cgi?id=967332
--- Comment #4 from Anuj More anujmorex@gmail.com --- I discussed this with the maintainer yesterday: https://github.com/janx/chardet2/issues/9
The change in URL and the repo name was done less than 10 days ago, where as I packaged the Gem quite some time ago.
After a discussion with vondruch, I packaged this Gem again as chardet2, and it worked with no major changes made to this specfile.
https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-chardet2/ruby...
This runs fine on mock as well.
I was thinking of removing this request and filing another one for chardet2, but I was going to discuss this with the GitLab guys before doing that. Nevermind, though.
https://bugzilla.redhat.com/show_bug.cgi?id=967332
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- Anuj, as I see the upstream ticket, they are not really helpful unfortunately :/ They don't mind to propose even yet another fork, which is exactly the opposite of what we want. Could you please try to contact the original chardet author and try it the other way around? I.e. the original author will revive the development, or give them commit access and allow them to push new gems to rubygems.org. Thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=967332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anujmorex@gmail.com Flags| |needinfo?(anujmorex@gmail.c | |om)
https://bugzilla.redhat.com/show_bug.cgi?id=967332
John Skeoch jskeoch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jstribny@redhat.com |hhorak@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=967332
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Assignee|hhorak@redhat.com |vondruch@redhat.com Flags|needinfo?(anujmorex@gmail.c | |om) | Last Closed| |2016-01-04 03:59:38
--- Comment #7 from Vít Ondruch vondruch@redhat.com --- Closing this stalled review.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla