https://bugzilla.redhat.com/show_bug.cgi?id=1367115
Bug ID: 1367115 Summary: Review Request: valadoc - Documentation tool for the vala project Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: gergely@polonkai.eu QA Contact: extras-qa@fedoraproject.org CC: extras-qa@fedoraproject.org, gergely@polonkai.eu, guillaumepoiriermorency@gmail.com, i@cicku.me, package-review@lists.fedoraproject.org, projects.rg@smart.ms, rc040203@freenet.de, rgs@itevenworks.net, zbyszek@in.waw.pl Depends On: 988667 Blocks: 177841 (FE-NEEDSPONSOR), 1321473, 896193 (plank) External Bug ID: GNOME Desktop 703688,Launchpad 933000
+++ This bug was initially created as a clone of Bug #988667 +++
Spec URL: https://gergelypolonkai.fedorapeople.org/valadoc/valadoc.spec SRPM URL: https://gergelypolonkai.fedorapeople.org/valadoc/valadoc-0.30-1.fc23.src.rpm Description: Valadoc is a documentation generator for generating API documentation from Vala source code based on libvala. Fedora Account System Username: gergelypolonkai
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=896193 [Bug 896193] Review Request: plank - A port of docky to Vala https://bugzilla.redhat.com/show_bug.cgi?id=988667 [Bug 988667] Review Request: valadoc - Documentation tool for the vala project https://bugzilla.redhat.com/show_bug.cgi?id=1321473 [Bug 1321473] Review Request: diodon - Clipboard manager for GNOME, Cinnamon and other Gtk desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #1 from Gergely Polonkai gergely@polonkai.eu --- *** Bug 988667 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1367115 Bug 1367115 depends on bug 988667, which changed state.
Bug 988667 Summary: Review Request: valadoc - Documentation tool for the vala project https://bugzilla.redhat.com/show_bug.cgi?id=988667
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Created attachment 1191731 --> https://bugzilla.redhat.com/attachment.cgi?id=1191731&action=edit log from failed build in fedora-rawhide-x86_64 mock
I tried to build the updated package, but it fails because /builddir/build/BUILDROOT/valadoc-0.30-1.fc26.x86_64/usr/lib64/valadoc/drivers/ does not exist. First it fails in %install in find (because the directory does not exists). If I comment that out, it fails in %files: RPM build errors: File not found: /builddir/build/BUILDROOT/valadoc-0.30-1.fc26.x86_64/usr/lib64/valadoc/drivers/0.30.x/libdriver.so
Full build log attached.
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #3 from Gergely Polonkai gergely@polonkai.eu --- It's a bit strange, as the files are the same as in the old ticket… I will take a look into it and get back with the results.
Also, should I build on Fedora 24 now it is out? The old SRPM was built on F23.
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The SRPM doesn't need to be rebuilt: the result is (except in some special cases) the same, no matter what the build host.
The binary RPMs should be built on rawhide (in mock, see https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Mock_and_Koji).
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #5 from Gergely Polonkai gergely@polonkai.eu --- That's exactly the strange part, I had successful mock and koji builds. Still, I'm already looking into it, I hope I can provide a working package soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- It seems to be a vala version problem.
On F23: checking for valac... /usr/bin/valac checking whether /usr/bin/valac is at least version 0.15.1... yes checking for LIBGVC... yes checking for GLIB... yes checking for GMODULE... yes checking for LIBGEE... yes checking for CGRAPH... yes checking for LIBVALA_0_30_X... yes checking for LIBVALA_0_28_X... no checking for LIBVALA_0_26_X... no checking for LIBVALA_0_24_X... no checking for LIBVALA_0_22_X... no checking for LIBVALA_0_20_X... no checking for LIBVALA_0_18_X... no checking for LIBVALA_0_16_X... no
On F24+: checking whether /usr/bin/valac is at least version 0.15.1... yes checking for LIBGVC... yes checking for GLIB... yes checking for GMODULE... yes checking for LIBGEE... yes checking for CGRAPH... yes checking for LIBVALA_0_30_X... no checking for LIBVALA_0_28_X... no checking for LIBVALA_0_26_X... no checking for LIBVALA_0_24_X... no checking for LIBVALA_0_22_X... no checking for LIBVALA_0_20_X... no checking for LIBVALA_0_18_X... no checking for LIBVALA_0_16_X... no
And indeed, F24 has vala-0.32.1-1.fc24.x86_64.
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #7 from Gergely Polonkai gergely@polonkai.eu --- Yes, upstream has been already upgraded to 0.32, and as F24 already has Vala 0.32, maybe I should also upgrade this package (as valadoc follows vala's version numbers, obviously)
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Yep, looks like an upgrade is needed. Probably some recent git snapshot would be good.
https://bugzilla.redhat.com/show_bug.cgi?id=1367115
Feng Yu rainwoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rainwoodman@gmail.com
--- Comment #9 from Feng Yu rainwoodman@gmail.com --- Supprised to find valadoc is not in the Fedora repo yet. Any progress on this?
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla