[Bug 1193210] New: Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Bug ID: 1193210
           Summary: Review Request: sxc - Simple XML Compiler
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc20.src.rpm
Description:
SXC (Simple XML Compiler) allows you to created optimized parsers and
writers for XML. Through a declarative API you're able to tell SXC
what type of XML to expect and what actions to associate with it.

Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8954096

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #1 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc23.src.rpm

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #2 from Upstream Release Monitoring  ---
gil's scratch build of sxc-0.8-1.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11776097

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Paulo Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paulo.cesar.pereira.de.andr
                   |                            |[e-mail]
           Assignee|[e-mail]    |paulo.cesar.pereira.de.andr
                   |                            |[e-mail]
              Flags|                            |fedora-review?

--- Comment #3 from Paulo Andrade  ---
I will review this package in exchange for review of
https://bugzilla.redhat.com/show_bug.cgi?id=1278140

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Paulo Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Paulo Andrade  ---
Hi Gil,

There are files under Apache and BSD license, so,
license probably should be changed to:
CDDL and ASL 2.0 and BSD
See for example:
sxc-sxc-0.8/sxc-runtime/src/main/java/org/metatype/sxc/util/Base64.java
sxc-sxc-0.8/sxc-xpath/src/test/java/org/metatype/sxc/xpath/StreaxPerformance.java

Please comment about:
# https://gil.fedorapeople.org/dependency-report-plugin-1.0.3-1.fc19.src.rpm
# BuildRequires: mvn(org.codehaus.swizzle:dependency-report-plugin)
Does it mean it is an optional build requires dependency?

An issue I see in most mvn related packages is
every subpackage having a %license line, because there
is no clean information about a single common subpackage
that all others require. It looks weird that every
subpackage have the line:
%license LICENSE.txt

Please correct the license tag before pushing to git,
otherwise I consider the package approved.

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #5 from gil cattaneo  ---
(In reply to Paulo Andrade from comment #4)
> Hi Gil,

Hi Paulo,
> There are files under Apache and BSD license, so,
> license probably should be changed to:
> CDDL and ASL 2.0 and BSD
> See for example:
> sxc-sxc-0.8/sxc-runtime/src/main/java/org/metatype/sxc/util/Base64.java
> sxc-sxc-0.8/sxc-xpath/src/test/java/org/metatype/sxc/xpath/StreaxPerformance.
> java

The last one is a should be consider as test resources, and not interested in
the end of the package license.
Added for the sub packages sxc-runtime and sxc-javadoc license field CDDL and
ASL 2.0
> Please comment about:
> # https://gil.fedorapeople.org/dependency-report-plugin-1.0.3-1.fc19.src.rpm
> # BuildRequires: mvn(org.codehaus.swizzle:dependency-report-plugin)
> Does it mean it is an optional build requires dependency?

yes, should be consider as optional. Done
> An issue I see in most mvn related packages is
> every subpackage having a %license line, because there
> is no clean information about a single common subpackage
> that all others require. It looks weird that every
> subpackage have the line:
> %license LICENSE.txt
>
> Please correct the license tag before pushing to git,
> otherwise I consider the package approved.

Thanks for your quick review

Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc23.src.rpm

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #6 from gil cattaneo  ---
Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1784
https://admin.fedoraproject.org/pkgdb/package/requests/1785

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/sxc

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #8 from Fedora Update System  ---
sxc-0.8-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-555d019d06

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #9 from Fedora Update System  ---
sxc-0.8-1.fc23 has been pushed to the Fedora 23 testing repository. If problems
still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update sxc'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-555d019d06

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

--- Comment #10 from Fedora Update System  ---
sxc-0.8-1.fc23 has been pushed to the Fedora 23 stable repository. If problems
still persist, please make note of it in this bug report.

[Bug 1193210] Review Request: sxc - Simple XML Compiler

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193210

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2015-12-03 15:21:04