Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: yajl - Yet Another JSON Library
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Summary: Review Request: yajl - Yet Another JSON Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: berrange@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://berrange.fedorapeople.org/review/yajl.spec SRPM URL: http://berrange.fedorapeople.org/review/yajl-1.0.7-1.fc12.src.rpm Description: Yet Another JSON Library. YAJL is a small event-driven (SAX-style) JSON parser written in ANSI C, and a small validating JSON generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
--- Comment #1 from Daniel Berrange berrange@redhat.com 2009-12-07 12:51:55 EDT --- RPMLint from a Fedora 12 i686 host
$ rpmlint yajl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/berrange/rpm/SRPMS/yajl-1.0.7-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/berrange/rpm/RPMS/i686/yajl-1.0.7-1.fc12.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/berrange/rpm/RPMS/i686/yajl-devel-1.0.7-1.fc12.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
And a scratch build passes on all architectures
http://koji.fedoraproject.org/koji/taskinfo?taskID=1860375
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Steven Dake sdake@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sdake@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rjones@redhat.com AssignedTo|nobody@fedoraproject.org |rjones@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #2 from Richard W.M. Jones rjones@redhat.com 2009-12-08 05:13:37 EDT --- + rpmlint output (no errors or warnings) + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora 3 clause, new BSD, no advertising + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture built in Koji n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates /usr/include/yajl + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package COPYING ChangeLog README TODO + header files should be in -devel n/a static libraries should be in -static + libfoo.so must go in -devel + -devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 - use %global instead of %define
Optional:
n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock + the package should build into binary RPMs on all supported architectures - review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
---------
Please change %define githash ... to %global githash ... Apart from that, the package looks OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
--- Comment #3 from Daniel Berrange berrange@redhat.com 2009-12-08 08:51:32 EDT --- Updated s/define/global/
http://berrange.fedorapeople.org/review/yajl-1.0.7-2.fc12.src.rpm http://berrange.fedorapeople.org/review/yajl.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Richard W.M. Jones rjones@redhat.com 2009-12-08 09:34:09 EDT --- APPROVED by rjones.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Daniel Berrange berrange@redhat.com 2009-12-08 11:04:09 EDT --- New Package CVS Request ======================= Package Name: yajl Short Description: Yet Another JSON Library Owners: berrange Branches: F-12 InitialCC: virtmaint
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2009-12-09 12:50:09 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545132
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #7 from Daniel Berrange berrange@redhat.com 2009-12-09 19:25:37 EDT --- Built into rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla