[Bug 190007] New: Review Request: <main package name here>

List overview All Threads
Download

newer

older

[Bug 447159] New: Review Request:...

[Bug 454440] New: Review Request:...

Red Hat Bugzilla

26 Apr 2006 26 Apr '06

5:50 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

Summary: Review Request: <main package name here> Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: Fedora@FamilleCollet.com QAContact: fedora-package-review@redhat.com

Spec URL: http://remi.collet.free.fr/rpms/extras/php-pecl-zip.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pecl-zip-1.2.3-1.fc5.src.rpm Description: Zip is an extension to create and read zip files.

---------------------------------------- This is my first RPM proposal for extras.

I provides some useful RPM on my little repo which i think most could/should be include in the Extras.

Remi.

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by thread

Red Hat Bugzilla

26 Apr 26 Apr

5:55 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

paul@city-fan.org changed:

Red Hat Bugzilla

28 Apr 28 Apr

3:21 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From bdpepple@ameritech.net 2006-04-28 10:21 EST ------- Note: This is not a formal review.

1. Package doesn't build in Mock. Looks like your missing some BuildRequires. For information on Mock, refer to http://fedoraproject.org/wiki/Extras/MockTricks. 2. Duplicate BuildRequires: automake (by php-devel), php (by php-devel), autoconf (by php-devel), libtool & gcc-c++ (provided in base install in Mock)

Red Hat Bugzilla

10:18 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From Fedora@FamilleCollet.com 2006-04-28 17:18 EST ------- Thank for your comment.

Here is the new spec.

http://remi.collet.free.fr/rpms/extras/php-pecl-zip.spec http://remi.collet.free.fr/rpms/extras/php-pecl-zip-1.3.1-2.fc5.src.rpm

1/ upgrade to new version 2/ BuildRoot and Requires corrected 3/ Build with mock succed.

Red Hat Bugzilla

27 Jun 27 Jun

11:03 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

11:04 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

11:07 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

11:08 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

8:04 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

tibbs@math.uh.edu changed:

Red Hat Bugzilla

9:43 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

10:25 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From chris.stone@gmail.com 2006-06-27 17:17 EST ------- MUST ITEM CHECKLIST: - rpmlint output: W: php-pecl-zip invalid-license PHP License W: php-pecl-zip incoherent-version-in-changelog 1.3.0-8.fc5 1.3.1-2.fc5 W: php-pecl-zip invalid-license PHP License W: php-pecl-zip-debuginfo invalid-license PHP License

Fix Changelog version numbers. Do not put dist in version numbers unless the package is specific to that dist only.

The license file warnings are okay to ignore, rpmlint will recognize "PHP License" in a future release.

- package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source does not contain license file - spec file is in American English (and french) - spec file is legible - sources match upstream d78c8d076b8ced344b3950b1e5299411 zip-1.3.1.tgz - package successfully compiles and builds on FC-5 x86_64 - All build dependencies are listed in BuildRequires - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package owns all directories it creates - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages

MUST - Must add Provides: php-pecl(zip) - Must remove unneeded Requires: zlib

SHOULD - Investigate what package re2c is used for in this package and determine if it would be useful to add: configure: WARNING: You will need re2c 0.9.11 or later if you want to regenerate PHP parsers. - Attach the PHP License file as a source file and include it in %doc - Use %defattr(-,root,root,-) the defaults are the same

Red Hat Bugzilla

10:34 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

Red Hat Bugzilla

29 Jun 29 Jun

7:53 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From Fedora@FamilleCollet.com 2006-06-29 14:44 EST ------- I don't see any use of re2c in the makefile. Probably come from a generic pecl configure.

Here is new spec : SPEC : http://remi.collet.free.fr/rpms/extras/php-pecl-zip.spec SRPM : http://remi.collet.free.fr/rpms/extras/php-pecl-zip-1.4.1-1.fc5.src.rpm Mock : http://remi.collet.free.fr/rpms/extras/php-pecl-zip-build.log

Changes : - update to 1.4.1 - bundle the v3.01 PHP LICENSE file - Suppr. Requires zip, Add Provides php-pecl(zip) and php-zip - change defattr

php-zip is provided according to new PHP guidelines.

Red Hat Bugzilla

10:40 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

chris.stone@gmail.com changed:

------- Additional Comments From chris.stone@gmail.com 2006-06-29 17:32 EST ------- All items fixed.

Please add %{version}-%{release} to php-pecl(zip) in Provides or else let me know why it should not be there.

APPROVED

Red Hat Bugzilla

1 Jul 1 Jul

1:07 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From chris.stone@gmail.com 2006-06-30 19:58 EST ------- I think the Group tags for pecl and pear packages are completely reversed as they currently stand. I believe pecl packages should be Development/Libraries and pear packages should be Development/Languages. I'm waiting to hear back from Fedora-Packaging on this.

Red Hat Bugzilla

2 Jul 2 Jul

10:54 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From chris.stone@gmail.com 2006-07-02 17:45 EST ------- Don't let the group tag thing prevent you from checking this into cvs, or is there another reason why this has not been checked into cvs yet?

Red Hat Bugzilla

11:18 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From ville.skytta@iki.fi 2006-07-02 18:09 EST ------- https://www.redhat.com/archives/fedora-extras-list/2006-June/msg01130.html:

* As a result of the PHP guidelines not being approved, a moratorium was placed on all php packages. JasonTibbs announced this on the fedora-extras and fedora-maintainers lists.

Red Hat Bugzilla

11:19 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From ville.skytta@iki.fi 2006-07-02 18:11 EST ------- Comment 8 doesn't mean this can't be checked to CVS though, but that it shouldn't be shipped yet before the guidelines are finalized and approved.

Red Hat Bugzilla

3 Jul 3 Jul

6:14 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From chris.stone@gmail.com 2006-07-03 01:06 EST ------- After checking this into CVS, please add:

%define apiver %((phpize --version 2>/dev/null || echo 'PHP Api Version: 20041225' ) | sed -n '/PHP Api Version/ s/.*: *//p')

And change Requires: php to: Requires: php-api >= %{apiver}

Red Hat Bugzilla

10:01 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From Fedora@FamilleCollet.com 2006-07-03 16:53 EST ------- Approved version 1.4.1-1 push to CVS. Waiting for PHP guidelines being approved before building it and adding the suggestion (Comment #5 and #10)

Red Hat Bugzilla

27 Aug 27 Aug

6:55 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

------- Additional Comments From Fedora@FamilleCollet.com 2006-08-27 13:55 EST ------- Version 1.7.2 push to CVS and build for devel.

Red Hat Bugzilla

6:55 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

Fedora@FamilleCollet.com changed:

Red Hat Bugzilla

25 Mar 25 Mar

10:13 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

Fedora@FamilleCollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From Fedora@FamilleCollet.com 2007-03-25 05:13 EST ------- Package Change Request ====================== Package Name: php-pecl-zip New Branches: EL-5

Red Hat Bugzilla

6:36 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

dennis@ausil.us changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From dennis@ausil.us 2007-03-25 13:36 EST ------- branched for EL-5

Red Hat Bugzilla

10:17 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

ville.skytta@iki.fi changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

------- Additional Comments From ville.skytta@iki.fi 2007-03-25 17:17 EST ------- The entry added to owners.epel.list is malformed, it's missing a trailing "|" and causes tracebacks on commits.

https://admin.fedoraproject.org/tickets/customer.pl?Action=CustomerTicketZoo...

[...] Checking in sources; /cvs/extras/rpms/perl-Set-IntSpan/devel/sources,v <-- sources new revision: 1.6; previous revision: 1.5 done Traceback (most recent call last): File "/cvs/extras/CVSROOT/getnotifylist", line 26, in ? owners = owners.OwnerList(populate_all = 0) File "/cvs/extras/CVSROOT/owners.py", line 47, in __init__ self.populate_owners() File "/cvs/extras/CVSROOT/owners.py", line 121, in populate_owners parse_file(self.owners_epel_list) File "/cvs/extras/CVSROOT/owners.py", line 103, in parse_file (product, component, desc, owner, qa, cclist) = l.split("|") ValueError: unpack list of wrong size Running syncmail... Mailing cvsextras@fedora.redhat.com ... ...syncmail done. [...]

Red Hat Bugzilla

26 Mar 26 Mar

12:05 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007

dennis@ausil.us changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From dennis@ausil.us 2007-03-25 19:05 EST ------- thanks. fixed

Red Hat Bugzilla

8 Jul 8 Jul

5:08 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/show_bug.cgi?id=190007

bugzilla@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

9 Jul 9 Jul

7:44 p.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/show_bug.cgi?id=190007

fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

------- Additional Comments From fedora@famillecollet.com 2008-07-09 14:44 EST ------- Package Change Request ====================== Package Name: php-pecl-zip New Branches: EL-4

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

11 Jul 11 Jul

12:05 a.m.

New subject: [Bug 190007] Review Request: php-pecl-zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip Alias: php-pecl-zip

https://bugzilla.redhat.com/show_bug.cgi?id=190007

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-07-10 19:05 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

5998

Age (days ago)

6804

Last active (days ago)

package-review@lists.fedoraproject.org

28 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla