https://bugzilla.redhat.com/show_bug.cgi?id=1661657
Bug ID: 1661657 Summary: Review Request: helm - A free polyphonic synth with lots of modulation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@online.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/helm.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/helm-1.0.0-0.1.20180708gitabd...
Description: Helm is a free, cross-platform, polyphonic synthesizer that runs on GNU/Linux, Mac, and Windows as a standalone program and as a LV2/VST/AU/AAX plugin.
Features: 32 voice polyphony Interactive visual interface Powerful modulation system with live visual feedback Dual oscillators with cross modulation and up to 15 unison oscillators each Sub oscillator with shuffle wave-shaping Oscillator feedback and saturation for wave-shaping 12 different wave-forms Blending between 12 or 24dB low/band/high pass filter Low/Band/High Shelf filters 2 monophonic and 1 polyphonic LFO Step sequencer Lots of modulation sources including polyphonic after-touch Simple arpeggiator Effects: Formant filter, stutter, delay, distortion, reverb
Fedora Account System Username: martinkg
%changelog * Thu Dec 20 2018 Martin Gansser martinkg@fedoraproject.org - 1.0.0-0.1.20180708gitabdedd5 - Initial build
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #1 from MartinKG mgansser@online.de --- helm already exists in bugzilla as an orphaned package.
https://bugzilla.redhat.com/show_bug.cgi?id=1250833
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/mtytel/h | |elm
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #2 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I think you'll need to unbundle some of these things. For example, the fonts don't need to be shipped again in this package. And many of the things in the 'other licenses' comment should perhaps also be removed.
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #3 from MartinKG mgansser@online.de --- @Elliott helm does not provide font files in the binary package.
[martin@fc29 RPMS]$ rpm -q --provides x86_64/helm-1.0.0-0.1.20180708gitabdedd5.fc29.x86_64.rpm application() application(helm.desktop) helm = 1.0.0-0.1.20180708gitabdedd5.fc29 helm(x86-64) = 1.0.0-0.1.20180708gitabdedd5.fc29 mimehandler(text/helm)
[martin@fc29 RPMS]$ rpm -q --provides noarch/helm-common-1.0.0-0.1.20180708gitabdedd5.fc29.noarch.rpm helm-common = 1.0.0-0.1.20180708gitabdedd5.fc29
helm also compiles if the fonts directory has been deleted.
which parts in the 'other licenses' comment should be removed ?
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I don't mean removed from the comment; I mean unbundled. I see now that the JuceLibraryCode section is mostly pregenerated (which is preferred, but not required to be re-built from source), but things like JUCE or VST3_SDK are not. Standard stuff like the zlib directory definitely should be removed and built against the system.
The fonts are in fact built in to the result via JuceLibraryCode/BinaryData.cpp. I'm not sure what to do about that.
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) CC| |junk@therobinsonfamily.net
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- *** Bug 1250833 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #6 from Matthias Runge mrunge@redhat.com --- worth noting, that there is also a helm, the package manager for kubernetes, see https://helm.sh/
Question is, which one of these packages should carry the name "helm".
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #7 from Raphael Groner projects.rg@smart.ms --- Matthias, thanks for the hint to the other helm. Offtopic: Is there any official repository that can be used *without* that client? I read it's mostly a Microsoft thing. Maybe just a new placebo? "Helm is the best way to find, share, and use software built for Kubernetes."
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #8 from Raphael Groner projects.rg@smart.ms --- (In reply to Raphael Groner from comment #7)
Matthias, thanks for the hint to the other helm. Offtopic: Is there any official repository that can be used *without* that client?
Yes. Obviously, https://github.com/helm/charts
Product: Fedora Version: rawhide Component: Package Review
MartinKG mgansser@online.de has canceled Package Review package-review@lists.fedoraproject.org's request for MartinKG mgansser@online.de's needinfo: Bug 1661657: Review Request: helm - A free polyphonic synth with lots of modulation https://bugzilla.redhat.com/show_bug.cgi?id=1661657
--- Comment #10 from MartinKG mgansser@online.de --- (In reply to Matthias Runge from comment #6)
worth noting, that there is also a helm, the package manager for kubernetes, see https://helm.sh/
Question is, which one of these packages should carry the name "helm".
was already discussed here [1] (/usr/bin/helm conflict with Kubernetes helm #235): The developer answerd: Renaming the binary to Helm is enough to get around this
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mgansser@online.d | |e) |
--- Comment #10 from MartinKG mgansser@online.de --- (In reply to Matthias Runge from comment #6)
worth noting, that there is also a helm, the package manager for kubernetes, see https://helm.sh/
Question is, which one of these packages should carry the name "helm".
was already discussed here [1] (/usr/bin/helm conflict with Kubernetes helm #235): The developer answerd: Renaming the binary to Helm is enough to get around this
[1] https://github.com/mtytel/helm/issues/235
https://bugzilla.redhat.com/show_bug.cgi?id=1661657
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2020-10-29 12:51:48
package-review@lists.fedoraproject.org