https://bugzilla.redhat.com/show_bug.cgi?id=1839256
Bug ID: 1839256 Summary: Review Request: mingw-opencv - MinGW Windows OpenCV library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: manisandro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://smani.fedorapeople.org/review/mingw-opencv.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-opencv-4.2.0-1.fc33.src.rpm Description: MinGW Windows OpenCV library Fedora Account System Username: smani
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- # RUN opencv-clean.sh TO PREPARE TARBALLS FOR FEDORA
- You need to add the script as a Source
- My local build is failing with tons of errors. I'll try Koji.
Errors are like:
In file included from /builddir/build/BUILD/opencv-4.2.0/build_win32/modules/dnn/opencv-caffe.pb.cc:4: /builddir/build/BUILD/opencv-4.2.0/build_win32/modules/dnn/opencv-caffe.pb.h:21322:62: error: invalid use of incomplete type 'class opencv_caffe::PriorBoxParameter' 21322 | inline void PriorBoxParameter::_internal_set_step(float value) { | ^
/builddir/build/BUILD/opencv-4.2.0/build_win32/modules/dnn/opencv-caffe.pb.cc:985:51: error: incomplete type 'opencv_caffe::NonMaximumSuppressionParameter' used in nested name specifier 985 | ::opencv_caffe::NonMaximumSuppressionParameter::InitAsDefaultInstance(); | ^~~~~~~~~~~~~~~~~~~~~
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- It still fails with many errors on Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=46093212
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Maybe this is due to this part:
CMake Warning at /usr/share/cmake/Modules/FindProtobuf.cmake:500 (message): Protobuf compiler version 3.12.3 doesn't match library version 3.11.4 Call Stack (most recent call first): cmake/OpenCVFindProtobuf.cmake:26 (find_package) CMakeLists.txt:676 (include) -- Performing Test HAVE_C_WNO_UNUSED_VARIABLE -- Performing Test HAVE_C_WNO_UNUSED_VARIABLE - Success -- Performing Test HAVE_C_WNO_SHADOW -- Performing Test HAVE_C_WNO_SHADOW - Success -- ADE: Download: v0.1.1f.zip -- Try 1 failed
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Ok bumping mingw-protobuf to 3.12.3 seems co fix the issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- Another error:
error: File not found: /builddir/build/BUILDROOT/mingw-opencv-4.2.0-1.fc33.x86_64/usr/i686-w64-mingw32/sys-root/mingw/lib/python3.9/site-packages/cv2-cpython-38.dll Deprecated external dependency generator is used! File not found: /builddir/build/BUILDROOT/mingw-opencv-4.2.0-1.fc33.x86_64/usr/i686-w64-mingw32/sys-root/mingw/lib/python3.9/site-packages/cv2-cpython-38.dll Child return code was: 1
We got Python 3.9 now so this probably needs to be adjusted:
%files -n mingw32-python3-%{pkgname} %{mingw32_python3_sitearch}/cv2-cpython-%{python_version_nodots}.dll
%files -n mingw64-python3-%{pkgname} %{mingw64_python3_sitearch}/cv2-cpython-%{python_version_nodots}.dll
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Should rather be
%files -n mingw32-python3-%{pkgname} %{mingw32_python3_sitearch}/cv2-cpython-%{mingw32_python3_version_nodots}.dll
and
%files -n mingw64-python3-%{pkgname} %{mingw64_python3_sitearch}/cv2-cpython-%{mingw64_python3_version_nodots}.dll
I've sent a PR to mingw-python3 to add these macros: https://src.fedoraproject.org/rpms/mingw-python3/pull-request/1
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #7 from Sandro Mani manisandro@gmail.com --- Spec URL: https://smani.fedorapeople.org/review/mingw-opencv.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-opencv-4.2.0-2.fc33.src.rpm
%changelog * Sat Jun 27 2020 Sandro Mani manisandro@gmail.com - 4.3.0-2 - Use %%{mingw32,64_python3_version_nodots}
* Sun May 31 2020 Sandro Mani manisandro@gmail.com - 4.3.0-1 - Update to 4.3.0
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- Missed this:
# RUN opencv-clean.sh TO PREPARE TARBALLS FOR FEDORA
- You need to add the script to generate the tarball as a Source, it should end up in the SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #9 from Sandro Mani manisandro@gmail.com --- Ups yes indeed
Spec URL: https://smani.fedorapeople.org/review/mingw-opencv.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-opencv-4.2.0-3.fc33.src.rpm
%changelog * Tue Jun 30 2020 Sandro Mani manisandro@gmail.com - 4.3.0-3 - Add opencv-clean.sh to sources
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #10 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-opencv
https://bugzilla.redhat.com/show_bug.cgi?id=1839256
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-07-01 17:23:57
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com