[Bug 1374957] New: Review Request: python-colorspacious - Perform colorspace conversions accurately and easily
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
Bug ID: 1374957 Summary: Review Request: python-colorspacious - Perform colorspace conversions accurately and easily Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dominik@greysector.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspa... SRPM URL: https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspa... Description: Colorspacious is a powerful, accurate, and easy-to-use library for performing colorspace conversions.
In addition to the most common standard colorspaces (sRGB, XYZ, xyY, CIELab, CIELCh), we also include: color vision deficiency ("color blindness") simulations using the approach of Machado et al (2009); a complete implementation of CIECAM02; and the perceptually uniform CAM02-UCS / CAM02-LCD / CAM02-SCD spaces proposed by Luo et al (2006).
Fedora Account System Username: rathann
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
--- Comment #1 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspa... SRPM URL: https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspa...
* Thu Sep 22 2016 Dominik Mierzejewski dominik@greysector.net 1.0.0-3 - use a simpler patch (by QuLogic) - add missing build dependency for building HTML docs
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
Tim Flink tflink@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tflink@redhat.com Assignee|nobody@fedoraproject.org |tflink@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
Tim Flink tflink@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Tim Flink tflink@redhat.com --- Looks good to me. Apologies on the delayed review.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 19 files have unknown license. Detailed output of licensecheck in /home/tflink/code/packages/reviews/1374957-python- colorspacious/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/lib/python3.5 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- colorspacious-doc , python2-colorspacious , python3-colorspacious [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-colorspacious-doc-1.0.0-3.fc26.noarch.rpm python2-colorspacious-1.0.0-3.fc26.noarch.rpm python3-colorspacious-1.0.0-3.fc26.noarch.rpm python-colorspacious-1.0.0-3.fc26.src.rpm python-colorspacious-doc.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python-colorspacious-doc.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python-colorspacious-doc.noarch: W: spelling-error %description -l en_US sRGB -> Sr python-colorspacious-doc.noarch: W: spelling-error %description -l en_US xyY -> xylem python-colorspacious-doc.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python-colorspacious-doc.noarch: W: spelling-error %description -l en_US al -> AL, la, Al python2-colorspacious.noarch: W: spelling-error Summary(en_US) colorspace -> color space, color-space, colors pace python2-colorspacious.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python2-colorspacious.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python2-colorspacious.noarch: W: spelling-error %description -l en_US sRGB -> Sr python2-colorspacious.noarch: W: spelling-error %description -l en_US xyY -> xylem python2-colorspacious.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python2-colorspacious.noarch: W: spelling-error %description -l en_US al -> AL, la, Al python3-colorspacious.noarch: W: spelling-error Summary(en_US) colorspace -> color space, color-space, colors pace python3-colorspacious.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python3-colorspacious.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python3-colorspacious.noarch: W: spelling-error %description -l en_US sRGB -> Sr python3-colorspacious.noarch: W: spelling-error %description -l en_US xyY -> xylem python3-colorspacious.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python3-colorspacious.noarch: W: spelling-error %description -l en_US al -> AL, la, Al python-colorspacious.src: W: spelling-error Summary(en_US) colorspace -> color space, color-space, colors pace python-colorspacious.src: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python-colorspacious.src: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python-colorspacious.src: W: spelling-error %description -l en_US sRGB -> Sr python-colorspacious.src: W: spelling-error %description -l en_US xyY -> xylem python-colorspacious.src: W: spelling-error %description -l en_US et -> ET, wt, rt python-colorspacious.src: W: spelling-error %description -l en_US al -> AL, la, Al 4 packages and 0 specfiles checked; 0 errors, 27 warnings.
Rpmlint (installed packages) ---------------------------- python-colorspacious-doc.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python-colorspacious-doc.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python-colorspacious-doc.noarch: W: spelling-error %description -l en_US sRGB -> Sr python-colorspacious-doc.noarch: W: spelling-error %description -l en_US xyY -> xylem python-colorspacious-doc.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python-colorspacious-doc.noarch: W: spelling-error %description -l en_US al -> AL, la, Al python2-colorspacious.noarch: W: spelling-error Summary(en_US) colorspace -> color space, color-space, colors pace python2-colorspacious.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python2-colorspacious.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python2-colorspacious.noarch: W: spelling-error %description -l en_US sRGB -> Sr python2-colorspacious.noarch: W: spelling-error %description -l en_US xyY -> xylem python2-colorspacious.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python2-colorspacious.noarch: W: spelling-error %description -l en_US al -> AL, la, Al python3-colorspacious.noarch: W: spelling-error Summary(en_US) colorspace -> color space, color-space, colors pace python3-colorspacious.noarch: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace python3-colorspacious.noarch: W: spelling-error %description -l en_US colorspaces -> color spaces, color-spaces, colors paces python3-colorspacious.noarch: W: spelling-error %description -l en_US sRGB -> Sr python3-colorspacious.noarch: W: spelling-error %description -l en_US xyY -> xylem python3-colorspacious.noarch: W: spelling-error %description -l en_US et -> ET, wt, rt python3-colorspacious.noarch: W: spelling-error %description -l en_US al -> AL, la, Al 3 packages and 0 specfiles checked; 0 errors, 20 warnings.
Requires -------- python-colorspacious-doc (rpmlib, GLIBC filtered):
python2-colorspacious (rpmlib, GLIBC filtered): python(abi) python2-numpy
python3-colorspacious (rpmlib, GLIBC filtered): python(abi) python3-numpy
Provides -------- python-colorspacious-doc: python-colorspacious-doc
python2-colorspacious: python-colorspacious python2-colorspacious python2.7dist(colorspacious) python2dist(colorspacious)
python3-colorspacious: python3-colorspacious python3.5dist(colorspacious) python3dist(colorspacious)
Source checksums ---------------- https://files.pythonhosted.org/packages/source/c/colorspacious/colorspacious... : CHECKSUM(SHA256) this package : 4952a629eb87059d7946c05bd4214413af26915e811c6f9ecb369c1775bb48de CHECKSUM(SHA256) upstream package : 4952a629eb87059d7946c05bd4214413af26915e811c6f9ecb369c1775bb48de
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1374957 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-colorspacious
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- python-colorspacious-1.0.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ad3ba918f9
https://bugzilla.redhat.com/show_bug.cgi?id=1374957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-10-08 22:47:11
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-colorspacious-1.0.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla