[Bug 544869] New: Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: udunits2 - A library for manipulating units of physical quantities

https://bugzilla.redhat.com/show_bug.cgi?id=544869

Summary: Review Request: udunits2 - A library for manipulating
                    units of physical quantities
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://www.auroralinux.org/people/spot/review/new/udunits2.spec
SRPM URL:
http://www.auroralinux.org/people/spot/review/new/udunits2-2.1.11-1.fc13.src...
Description: 
The Unidata units utility, udunits2, supports conversion of unit specifications
between formatted and binary forms, arithmetic manipulation of unit
specifications, and conversion of values between compatible scales of
measurement.

(NOTE: udunits v1 is already in Fedora, but v2 is incompatible in notable ways.
I am the maintainer of udunits v1. We will have multiple applications dependent
on both versions of udunits for the foreseeable future.)

[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544869

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Orion Poplawski   2009-12-31 12:14:47 EDT ---
    *  rpmlint

udunits2.i686: W: shared-lib-calls-exit /usr/lib/libudunits2.so.0.0.0
exit@GLIBC_2.0

A number to UCAR libraries do this - often only when a certain flag is set. 
Probably worth pinging upstream about though.  Not blocking the review though.

* naming - okay
    * NamingGuidelines
    * licensing - MIT
    * osi approved? yes
    * included? yes
    * correct mentioned in specfile? yes

specfile

* American English - yes
    * legible - yes
    * BuildRequires - good
    * Locales - NA
    * shared libraries: ldconfig - yes
    *  %clean section with rm -rf ${RPM_BUILD_ROOT} - yes
    * macros - consistent
    * sources - checksums match upstream
    * relocatable? Prefix: /usr? - NA
    * files and directories  - good
    * owns all created directories - yes
    * all files listed in %files - yes
    * permissions? - good
    * deffattr? - yes
    * no .la files - yes
     * no conflicts with other packets - checked okay with udunits
    * -devel - yes
    * headers - yes
    * static libraries - NA
    * .so without suffix when .so.suffix existent - nope
    * .pc files - NA
    * permissable content - yes
    * doc - yes
    * large doc in -doc package - NA
    * must not affect runtime - good

* mock build - yes
    * sane scriptlets - yes
    * subpackages with fully versioned dependency - yes

Looks good.  Approved.

[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544869

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Orion Poplawski   2010-01-06 12:55:20 EDT ---
New Package CVS Request
=======================
Package Name: udunits2
Short Description: A library for manipulating units of physical quantities
Owners: spot orion
Branches: F-12 F-11 EL-5 EL-4
InitialCC:

[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544869

--- Comment #3 from Tom "spot" Callaway   2010-01-06 13:00:50 EDT ---
Sorry for not getting to this sooner.

[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544869

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #4 from Kevin Fenzi   2010-01-06 16:38:17 EDT ---
cvs done.

[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544869

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #5 from Orion Poplawski   2010-01-06 18:12:31 EDT ---
Checked in and built.  Thanks all...