[Bug 2164880] New: Review Request: python-irc - Full-featured Python IRC library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Bug ID: 2164880 Summary: Review Request: python-irc - Full-featured Python IRC library for Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: omosnacek@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 2164874, 2164875 Target Milestone: --- Classification: Fedora
Spec URL: https://gitlab.com/omos/fedora-package-review/-/raw/a397bf2bcf69dab2a8447cce... SRPM URL: https://download.copr.fedorainfracloud.org/results/omos/python-irc/srpm-buil... Description: This library provides a low-level implementation of the IRC protocol for Python. It provides an event-driven IRC client framework. It has a fairly thorough support for the basic IRC protocol, CTCP, and DCC connections. Fedora Account System Username: omos
Copr build: https://copr.fedorainfracloud.org/coprs/omos/python-irc/build/5312120/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2164874 [Bug 2164874] Review Request: python-jaraco-stream - Routines for dealing with data streams https://bugzilla.redhat.com/show_bug.cgi?id=2164875 [Bug 2164875] Review Request: python-jaraco-logging - Support for Python logging facility
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5312142 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Ondrej Mosnáček omosnacek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://gitlab.com/omos/fedora-package-review/-/raw/a397bf2bcf69dab2a8447cce... SRPM URL: https://download.copr.fedorainfracloud.org/results/omos/python-irc/fedora-ra... Description: This library provides a low-level implementation of the IRC protocol for Python. It provides an event-driven IRC client framework. It has a fairly thorough support for the basic IRC protocol, CTCP, and DCC connections. Fedora Account System Username: omos
Copr build: https://copr.fedorainfracloud.org/coprs/omos/python-irc/build/5312120/
https://bugzilla.redhat.com/show_bug.cgi?id=2164880 Bug 2164880 depends on bug 2164874, which changed state.
Bug 2164874 Summary: Review Request: python-jaraco-stream - Routines for dealing with data streams https://bugzilla.redhat.com/show_bug.cgi?id=2164874
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2164880 Bug 2164880 depends on bug 2164875, which changed state.
Bug 2164875 Summary: Review Request: python-jaraco-logging - Support for Python logging facility https://bugzilla.redhat.com/show_bug.cgi?id=2164875
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #2 from Ondrej Mosnáček omosnacek@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/jaraco/% | |{projname}
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5554418 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #4 from Ondrej Mosnáček omosnacek@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5563171 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com Status|NEW |ASSIGNED URL|https://github.com/jaraco/% |https://github.com/jaraco/i |{projname} |rc Flags| |fedora-review? Assignee|nobody@fedoraproject.org |pemensik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Petr Menšík pemensik@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 52 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2164880-python- irc/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: python3-irc-20.1.0-1.fc39.noarch.rpm python-irc-20.1.0-1.fc39.src.rpm ============================================================ rpmlint session starts ============================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe6x7a5m0')] checks: 31, packages: 2
============================= 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s =============================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/i/irc/irc-20.1.0.tar.gz : CHECKSUM(SHA256) this package : b6f737932dd4791f3b18e319de7b7daf02d2285a6bea263d101f4d8e553807ec CHECKSUM(SHA256) upstream package : b6f737932dd4791f3b18e319de7b7daf02d2285a6bea263d101f4d8e553807ec
Requires -------- python3-irc (rpmlib, GLIBC filtered): python(abi) python3.11dist(jaraco-collections) python3.11dist(jaraco-functools) python3.11dist(jaraco-logging) python3.11dist(jaraco-stream) python3.11dist(jaraco-text) python3.11dist(more-itertools) python3.11dist(pytz) python3.11dist(tempora)
Provides -------- python3-irc: python-irc python3-irc python3.11-irc python3.11dist(irc) python3dist(irc)
Diff spec file in url and in SRPM --------------------------------- --- /home/pemensik/fedora/rawhide/2164880-python-irc/srpm/python-irc.spec 2023-03-11 22:20:22.125943735 +0100 +++ /home/pemensik/fedora/rawhide/2164880-python-irc/srpm-unpacked/python-irc.spec 2023-01-26 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global modname irc %global projname %{modname} @@ -63,3 +73,4 @@
%changelog -%autochangelog +* Thu Jan 26 2023 John Doe packager@example.com - 20.1.0-1 +- Uncommitted changes
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2164880 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, PHP, R, SugarActivity, Haskell, Ocaml, C/C++, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #7 from Petr Menšík pemensik@redhat.com --- Created attachment 1949913 --> https://bugzilla.redhat.com/attachment.cgi?id=1949913&action=edit licensecheck.txt
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-irc
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
--- Comment #9 from Ondrej Mosnáček omosnacek@gmail.com --- Thanks for the review!
(In reply to Petr Menšík from comment #6)
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
Added a commit that adds a comment explaining the "Disable linters" patch: https://src.fedoraproject.org/rpms/python-irc/pull-request/1
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-f86f9ff8f6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f86f9ff8f6
https://bugzilla.redhat.com/show_bug.cgi?id=2164880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-03-15 10:16:58
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-f86f9ff8f6 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com