https://bugzilla.redhat.com/show_bug.cgi?id=2219683
Bug ID: 2219683 Summary: Review Request: rust-maybe-async - Procedure macro to unify SYNC and ASYNC implementation Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async.spec SRPM URL: https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async-0.2.7-1.f...
Description: A procedure macro to unify SYNC and ASYNC implementation.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2219683
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Not sure what's happening here:
ERROR: 'Error HTTP Error 403: Forbidden downloading https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async-0.2.7-1.f...'
https://bugzilla.redhat.com/show_bug.cgi?id=2219683
--- Comment #3 from blinxen h-k-81@hotmail.com --- For some reason the parent directory (rust-maybe-async) did not have execute permissions. Should be fine now.
Side note: The correct term is "procedural macro", not "procedure macro".
Nice catch, will updated the summary and description.
https://bugzilla.redhat.com/show_bug.cgi?id=2219683
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
It would be great if you could review one of my packages in return.
https://bugzilla.redhat.com/show_bug.cgi?id=2219683
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-maybe-async
https://bugzilla.redhat.com/show_bug.cgi?id=2219683
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-07-05 17:51:12
--- Comment #6 from blinxen h-k-81@hotmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e48f7130eb
package-review@lists.fedoraproject.org