[Bug 1039138] New: Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Bug ID: 1039138
           Summary: Review Request: key-mon - A screencast utility that
                    displays your keyboard and mouse status
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

# Spec URL # 
https://github.com/ryanlerch/my-fedora-package-reviews/blob/master/key-mon/k...

# SRPM URL # 
https://github.com/ryanlerch/my-fedora-package-reviews/raw/master/key-mon/ke...

# Description #
Key-mon is useful for teaching since it shows the current status of your
keyboard and mouse and you use them in another application. No longer do
you need to say 'Now I'm pressing the Ctrl-D key', your students can just
see the keystroke for themselves.

# Fedora Account System Username #
ryanlerch

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Christopher Meng  ---
I like this package, it's really useful for me!

1. Release:            0%{?dist}

Remember to change it to 1 in SCM ;)

2. Source0:            http://key-mon.googlecode.com/files/key-mon-1.16.tar.gz

As gcode will shut down the download section from 2014 as well as this is a
python package, you can find it in the Package Index(pypi):

https://pypi.python.org/pypi/key-mon

So please change the Source0 to:

https://pypi.python.org/packages/source/k/key-mon/key-mon-%%7Bversion%7D.zip

3. BuildRequires:      desktop-file-utils
%description

Leave a blank line between each other.

4. for lib in %{buildroot}%{python2_sitelib}/keymon/*.py; do
 sed '1{@^#!/usr/bin/python@d}' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

Well, please do this in %prep, don't do that after %build

5. %doc only has an reStructuredText file of README, please also include
COPYING.

6. You should ship manpage also. Also seems it's useless ;)

7. From the homepage, you've missed some Requires:

pygtk2
python-xlib
librsvg2

8. Patch binary key-mon to %{__python2} as well.

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #2 from Ryan Lerch  ---
(In reply to Christopher Meng from comment #1)

new SRPM and SPEC are available here:
https://github.com/ryanlerch/my-fedora-package-reviews/tree/master/key-mon
> I like this package, it's really useful for me!
> Release:            0%{?dist}
>
> Remember to change it to 1 in SCM ;)

Done in commits:
https://github.com/ryanlerch/my-fedora-package-reviews/commit/aa242b098373eb...
https://github.com/ryanlerch/my-fedora-package-reviews/commit/09225aec49e5b9...
> Source0:
>
> http://key-mon.googlecode.com/files/key-mon-1.16.tar.gz
>
> As gcode will shut down the download section from 2014 as well as this is a
> python package, you can find it in the Package Index(pypi):
>
> https://pypi.python.org/pypi/key-mon
>
> So please change the Source0 to:
>
> https://pypi.python.org/packages/source/k/key-mon/key-mon-%%7Bversion%7D.zip

done in commit:
https://github.com/ryanlerch/my-fedora-package-reviews/commit/013e61f21c6c88...
> BuildRequires:      desktop-file-utils
>
> %description
>
> Leave a blank line between each other.

https://github.com/ryanlerch/my-fedora-package-reviews/commit/4d54c39eb164b3...
> for lib in %{buildroot}%{python2_sitelib}/keymon/*.py; do
>
> sed '1{@^#!/usr/bin/python@d}' $lib > $lib.new &&
>  touch -r $lib $lib.new &&
>  mv $lib.new $lib
> done
>
> Well, please do this in %prep, don't do that after %build

https://github.com/ryanlerch/my-fedora-package-reviews/commit/7ce990a0cccc76...
> %doc only has an reStructuredText file of README, please also include
>
> COPYING.

https://github.com/ryanlerch/my-fedora-package-reviews/commit/b25e83b7646ee0...
> You should ship manpage also. Also seems it's useless ;)

https://github.com/ryanlerch/my-fedora-package-reviews/commit/271e5d29e69cb2...
> From the homepage, you've missed some Requires:
>
> pygtk2
> python-xlib
> librsvg2

Added in
https://github.com/ryanlerch/my-fedora-package-reviews/commit/b837a259fd5ffb...

however, this does now cause RPMLINT to spew the following errors:
"""
Rpmlint
-------
Checking: key-mon-1.16-1.fc20.noarch.rpm
          key-mon-1.16-1.fc20.src.rpm
key-mon.noarch: E: explicit-lib-dependency librsvg2
key-mon.noarch: E: explicit-lib-dependency python-xlib
2 packages and 0 specfiles checked; 2 errors, 0 warnings.
"""
> Patch binary key-mon to %{__python2} as well.

Done in
https://github.com/ryanlerch/my-fedora-package-reviews/commit/f0d823db351ecf...

however, i did check the key-mon file in the bin directory before i added the
above commit and the first line was already "#!/usr/bin/python2". Is rpm
already doing this patching for me?

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Christopher Meng  ---
Then you don't need to patch it any more. %__python2 executable had done works
for you.

PACKAGE APPROVED.

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #4 from Christopher Meng  ---
You forget this one.

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Ryan Lerch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]          |[e-mail]
              Flags|needinfo?([e-mail] |fedora-cvs?
                   |)                           |

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #5 from Ryan Lerch  ---
New Package SCM Request
=======================
Package Name: key-mon
Short Description: A screen cast utility that displays your keyboard and mouse
status
Owners: ryanlerch
Branches: f19 f20

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #7 from Fedora Update System  ---
key-mon-1.16-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/key-mon-1.16-1.fc19

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #8 from Fedora Update System  ---
key-mon-1.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/key-mon-1.16-1.fc20

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #9 from Christopher Meng  ---
Please update to 1.17! :(

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Ryan Lerch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
              Flags|needinfo?([e-mail] |
                   |)                           |
        Last Closed|                            |2014-02-21 09:40:53

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

--- Comment #10 from Ryan Lerch  ---
(In reply to Christopher Meng from comment #9)
> Please update to 1.17! :(

I saw that before i Pushed the update, however looking at the release notes, it
seems that update does not actaully *fix* anything, just add a few more themes,
so i decided to push the package with 1.16, and work  on the updating it soon.

from the key-mon release notes:

Jan 07, 2014 v 1.17
--------------------
* Added hi-color icons (thanks [e-mail]).
* Added big-letters theme (thanks eko).
* Bumped the version.

regards,
ryanlerch

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |key-mon-1.16-1.fc20
         Resolution|CURRENTRELEASE              |ERRATA

--- Comment #11 from Fedora Update System  ---
key-mon-1.16-1.fc20 has been pushed to the Fedora 20 stable repository.

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|key-mon-1.16-1.fc20         |key-mon-1.16-1.fc19

--- Comment #12 from Fedora Update System  ---
key-mon-1.16-1.fc19 has been pushed to the Fedora 19 stable repository.

[Bug 1039138] Review Request: key-mon - A screencast utility that displays your keyboard and mouse status

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039138

James Hogarth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from James Hogarth  ---
*** Bug 592628 has been marked as a duplicate of this bug. ***