[Bug 544299] New: Review Request: gnome-color-manager - Color management for the GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-color-manager - Color management for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=544299
Summary: Review Request: gnome-color-manager - Color management for the GNOME desktop Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rhughes@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://people.freedesktop.org/~hughsient/temp/gnome-color-manager.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/gnome-color-manager-2.29.1-0.1... Description:
gnome-color-manager is a session program that makes it easy to manage, install and generate color profiles in the GNOME desktop.
This project has the following features:
* Setting output gamma tables (with local brightness and adjustments) to any Xrandr output (falling back to the per-screen methods for drivers that do not yet support Xrandr 1.3).
* Setting of settings at session start, and when monitors are hotplugged.
* Easy install of vendor supplied ICC or ICM files, just by double clicking on the file.
* Easy display calibration using an external calibration device, and scanner calibration using a inexpensive IT 8.7 target. For calibration, the ArgyllCMS package is required.
* Integration X11 by setting the per-screen and per-output _ICC_PROFILE atom, which makes applications such as the GIMP use a color managed output.
* Easy to use DBus interface for applications to query what ICC profiles should be used for a specific device. This is session activated and is only started when it is needed, and quits after a small period of idleness.
For more information, please see http://projects.gnome.org/gnome-color-manager/
Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544299
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |yaneti@declera.com AssignedTo|nobody@fedoraproject.org |yaneti@declera.com Flag| |fedora-review+
--- Comment #1 from Yanko Kaneti yaneti@declera.com 2009-12-04 16:32:55 EDT --- Licenses match. Some strange variations of .. See the * GNU General Public License for more details. line, which I think other than breaking automated license checkers don;t change the spirit,
Source little hard to tell if it matches because its not an official release tarball and the steps to reproduce it are not included (yeah I know that it comes from git.gnome.org), would be nice to have some basic instruction in the spec file. Builds in mock. Installs without fuss. Runs fine as far as I can tell.
The purpose of gcm-session is a unclear to me on a cursory glance.
$rpmlint gnome-color-manager-2.29.1-0.1.20091204git.fc13.x86_64.rpm gnome-color-manager.x86_64: W: spelling-error-in-description en_US colour gnome-color-manager.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gcm-apply.desktop 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Can be ignored, although I think the British spelling is not necessary in a package called gnome-_color_-manager
- The GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL bits are redundant since --disable-schemas-install seems to be handled properly
- the gtk-update-icon-cache run in %post should probably be moved to %posttrans as per the packaging snippets guidelines
- The scrollkeeper bits aren't necessary since it has been obsoleted by rarian.
Looks ok. Issues not fatal but would be nice if addressed. APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544299
--- Comment #2 from Richard Hughes rhughes@redhat.com 2009-12-07 04:31:20 EDT --- New Package CVS Request ======================= Package Name: gnome-color-manager Short Description: Color management for the GNOME desktop Owners: rhughes Branches: F-12 InitialCC: rhughes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544299
Richard Hughes richard@hughsie.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544299
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-12-07 11:31:43 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544299
Richard Hughes richard@hughsie.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Richard Hughes richard@hughsie.com 2009-12-07 12:17:42 EDT --- Package imported. Thanks to all.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla