Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jp2a - an utility for converting JPEG images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Summary: Review Request: jp2a - an utility for converting JPEG images to ASCII Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: morpheusv@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://morpheusv.fedorapeople.org/jp2a.spec SRPM URL: http://morpheusv.fedorapeople.org/jp2a-1.0.6-1.fc15.src.rpm Description: jp2a is a small command-line utility for converting JPEG images to ASCII art.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Andres morpheusv@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
yanchuan yanchuan@nfs-china.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yanchuan@nfs-china.com
--- Comment #1 from yanchuan yanchuan@nfs-china.com 2011-05-30 11:13:25 EDT --- Hi Andres, There are some problems with your package. (1)There is only one percent sign in your comment, but macros are expanded first, so you need to double it.See here: https://fedoraproject.org/wiki/How_to_create_an_RPM_package (2)The license must be specific instead of just "GPL". (3)The summary doesn't begin with a capital letter. Maybe you need run rpmlint first.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
--- Comment #2 from Andres morpheusv@gmail.com 2011-06-03 07:10:28 EDT ---
thanks for making observations, You can find the new spec at
http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a.spec http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a-1.0.6-2.fc15.src.rpm
this is a result the rpmlint SPECS/jp2a.spec: 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #3 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2011-06-03 10:58:07 EDT --- you're already sponsored by toshio at fudcon-panama , removing FE-NEEDSPONSOR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(morpheusv@gmail.c | |om)
--- Comment #4 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2011-06-03 14:07:05 EDT --- Can you post here a link to a koji scratch build ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Andres morpheusv@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(morpheusv@gmail.c | |om) |
--- Comment #5 from Andres morpheusv@gmail.com 2011-06-04 19:16:36 EDT --- this is the link koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3111554
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
--- Comment #6 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2011-06-05 09:11:12 EDT --- look at buildlog, I think BuildRequires is missing for curl-devel and ncurses-devel
checking for curl-config... no checking for curl_easy_init in -lcurl... no configure: WARNING: I need a working libcurl (use --with-curl-config=PATH); download-support will be disabled
checking for tgetent in -lterminfo... no configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
--- Comment #7 from Andres morpheusv@gmail.com 2011-06-11 22:44:14 EDT --- has built libcurl-devel. It has been tested to install and uninstall the package in a test in a PC and has been installed successfully.
you can find the new spec at: http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a.spec http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a-1.0.6-3.fc15.src.rpm
this is the link koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3126525
I'll watch for comments or approval.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
--- Comment #8 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2011-06-16 01:38:31 EDT --- I still see the warning about curl
http://koji.fedoraproject.org/koji/getfile?taskID=3126526&name=build.log
configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
--- Comment #9 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2011-06-16 01:39:42 EDT --- I use macros in this way %{name}-%{version}
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@uos.de
--- Comment #10 from Martin Gieseking martin.gieseking@uos.de 2011-07-28 15:21:42 EDT --- Some more notes:
- I agree, BR ncurses-devel is missing and should be added. It's required to get the current terminal size. Without it, default values are used.
- Adapt Source0 according to http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net
- Choose a more appropriate Group, e.g. Applications/Text
- Add file COPYING to the package.
- Be a bit more specific in %files, i.e. replace %{_mandir}/man1/* with %{_mandir}/man1/%{name}.1*
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla