[Bug 197461] New: Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

Summary: Review Request: perl-Class-InsideOut
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://home.comcast.net/~ckweyl/perl-Class-InsideOut.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-InsideOut-1.00-0.fc5.src.rpm

Description: 
This is a simple, safe and streamlined toolkit for building inside-out
objects. Unlike most other inside-out object building modules already on CPAN,
this module aims for minimalism and robustness:

* Does not require derived classes to subclass it
* Uses no source filters, attributes or CHECK blocks
* Supports any underlying object type including foreign
  inheritance
* Does not leak memory on object destruction
* Overloading-safe
* Thread-safe for Perl 5.8 or better
* mod_perl compatible
* Makes no assumption about inheritance or initializer needs

[Bug 197461] Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-InsideOut

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-03 15:31 EST -------
Good:
+ Tarball match with upstream.
+ rpmlint doesn't complaints source rpm.
+ Local build works fine.
+ Package contains verbatin copy of the license.
+ rpmlint doesn't complaint the binary rpm.

Bad:
- Perl have not to be inclussion in the BR.

[Bug 197461] Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-InsideOut

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

------- Additional Comments From [e-mail]  2006-07-05 14:08 EST -------
Is the inclusion of perl a blocker for approval?  The review guidelines say:

"- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines; inclusion of
those as BuildRequires is optional. Apply common sense."

[Bug 197461] Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-InsideOut

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

------- Additional Comments From [e-mail]  2006-07-05 14:26 EST -------
(In reply to comment #2)
> Is the inclusion of perl a blocker for approval?

s/of perl a/of perl in BR a/: no.  On the other hand, FWIW, in this case there
are various other perl(Foo::Bar) build dependencies which are unlikely to
suddenly change so that the main perl package would not be pulled in.

[Bug 197461] Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-InsideOut

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-06 11:53 EST -------
 ihave read the Packaging Guidelines again. The packages in the exception list
may be listed as a BR optional.

So that this is not a blocker.

I will APPROVED your package now.

[Bug 197461] Review Request: perl-Class-InsideOut

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-InsideOut

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197461

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-07-06 23:29 EST -------
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching 
+Close bug

Thanks for the review!