Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: php-pear-Config -Configuration file manipulation for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Summary: Review Request: php-pear-Config -Configuration file manipulation for PHP Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bjohnson@symetrix.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~bjohnson/php-pear-Config.spec SRPM URL: http://fedorapeople.org/~bjohnson/php-pear-Config-1.10.11-1.fc10.src.rpm Description: The PHP Config package provides methods for configuration manipulation. * Creates configurations from scratch * Parses and outputs different formats (XML, PHP, INI, Apache...) * Edits existing configurations * Converts configurations to other formats * Allows manipulation of sections, comments, directives... * Parses configurations into a tree structure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com AssignedTo|nobody@fedoraproject.org |fedora@famillecollet.com Flag| |fedora-review?
--- Comment #1 from Remi Collet fedora@famillecollet.com 2009-02-22 02:29:54 EDT --- First Notes :
- As optional deps are available it should be usefull to add it Requires: php-pear(XML_Parser) php-pear(XML_Util)
- I prefer the use of %{name}.xml rather than %{pear_name}.xml (see recent change to PHP Guidelines, this will avoid conflict with package from other channel)
- rpmlint is silent
- A comment about running test-suite will be usefull # pear run-tests -p Config Running 16 tests ... FAIL [ 3/16] test for bug 3051[/usr/share/pear/test/Config/test/bug3051.phpt] ... FAIL [16/16] regression test for bug #10185[/usr/share/pear/test/Config/test/bug10185.phpt] wrote log to "/root/run-tests.log" TOTAL TIME: 00:01 14 PASSED TESTS 0 SKIPPED TESTS 2 FAILED TESTS: /usr/share/pear/test/Config/test/bug3051.phpt /usr/share/pear/test/Config/test/bug10185.phpt
Have you encounter and investigate this issue ? (at least, reported upstream)
- %file must be fixed, should be %defattr(-,root,root,-) %doc %{pear_name}-%{version}/docdir/%{pear_name}/* %{pear_xmldir}/%{pear_name}.xml %{pear_testdir}/%{pear_name} %{pear_phpdir}/Config*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
--- Comment #2 from Bernard Johnson bjohnson@symetrix.com 2009-02-25 19:23:38 EDT --- (In reply to comment #1)
First Notes :
- As optional deps are available it should be usefull to add it
Requires: php-pear(XML_Parser) php-pear(XML_Util)
added
- I prefer the use of %{name}.xml rather than %{pear_name}.xml (see recent
change to PHP Guidelines, this will avoid conflict with package from other channel)
I did not find anything in the PHP guidelines, but I think I understand your intention. Please check and see if my updates to the package achieve this.
- A comment about running test-suite will be usefull
14 PASSED TESTS 0 SKIPPED TESTS 2 FAILED TESTS: Have you encounter and investigate this issue ? (at least, reported upstream)
Two of the tests are badly written and fail. There is no problem with the functionality of the package.
- %file must be fixed, should be
%{pear_phpdir}/Config*
fixed
Spec URL: http://fedorapeople.org/~bjohnson/php-pear-Config.spec SRPM URL: http://fedorapeople.org/~bjohnson/php-pear-Config-1.10.11-2.fc10.src.rpm
* Wed Feb 25 2009 Bernard Johnson bjohnson@symetrix.com - 1.10.11-2 - add dependencies for php-pear(XML_Parser) and php-pear(XML_Util) - change from %%{pear_name}.xml to %%{name}.xml to avoid channel conflicts - changes %%files section from %%{pear_phpdir}/* to %%{pear_phpdir}/Config* - note regarding test suite failures added
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Remi Collet fedora@famillecollet.com 2009-02-26 11:37:38 EDT ---
Two of the tests are badly written and fail. There is no problem with the functionality of the package.
This should be reported upstream
REVIEW:
+ rpmlint is ok php-pear-Config.src: I: checking php-pear-Config.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name + spec file name + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + no license file in sources is provided + sources match the upstream sources ec85ece7ddd28a0a139c0699481c0116 Config-1.10.11.tgz + Source URL ok + build on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (fedora-rawhide-x86_64) + test suite : see previous comment + scriptlets ok + Final Requires ok /bin/sh /usr/bin/pear php-pear(PEAR) php-pear(XML_Parser) php-pear(XML_Util) + Final Provides ok php-pear(Config) = 1.10.11 php-pear-Config = 1.10.11-2.fc8
php-pear(PEAR) should be removed from Requires as already required by php-pear(XML_Parser) and php-pear(XML_Util)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Bernard Johnson bjohnson@symetrix.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Bernard Johnson bjohnson@symetrix.com 2009-03-01 12:17:02 EDT --- (In reply to comment #3)
Two of the tests are badly written and fail. There is no problem with the functionality of the package.
This should be reported upstream
Reported
php-pear(PEAR) should be removed from Requires as already required by php-pear(XML_Parser) and php-pear(XML_Util)
I will remove this after the import. Thanks for the review!
New Package CVS Request ======================= Package Name: php-pear-Config Short Description: Configuration file manipulation for PHP Owners: bjohnson Branches: F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-03-02 19:14:52 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-03-07 12:31:11 EDT --- php-pear-Config-1.10.11-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pear-Config-1.10.11-3.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-03-09 19:07:42 EDT --- php-pear-Config-1.10.11-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |1.10.11-3.fc10 Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org