[Bug 432921] New: Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

Summary: Review Request: fldigi - Digital modem program for
                    Linux.
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/fldigi.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/fldigi-2.09-2.fc8.src.rpm
Description: fldigi is a modem program which supports most of the digital modes used by hamradio operators today. You can also use the program for calibrating your sound card to WWV or doing a frequency measurement test. The program also comes with a CW decoder. fldigi is written with the help of the Fast Light Toolkit X GUI.

Package builds against rawhide, is waiting for https://admin.fedoraproject.org/updates/F8/FEDORA-2008-1308 so it can be built for F8.

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-02-15 19:35 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: GPLv2+ (from source)
%doc License: N/A
Spec file language: English
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F7 FAILED (not targeted),
 - F8 OK,
 - rawhide OK,
 - EL5 FAILED (not targeted)

Applicable Package Guidelines:
 - -debuginfo package: OK
 - .desktop file: Upstream Make (Automake) does not call desktop-file-install

Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

APPROVED

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-02-15 19:37 EST -------
Mark as Review done

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-02-15 19:45 EST -------
New Package CVS Request
=======================
Package Name: fldigi
Short Description: Digital modem program for Linux
Owners: bjensen,sconklin
Branches: F-8
InitialCC: sindrebp
Cvsextras Commits: Yes

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-02-15 22:28 EST -------
cvs done.

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-02-15 23:05 EST -------
- When installing desktop files, desktop-file-install must be called
  ("desktop-file-install usage" of
    http://fedoraproject.org/wiki/Packaging/Guidelines )

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

------- Additional Comments From [e-mail]  2008-02-16 11:03 EST -------
(In reply to comment #5)
> When installing desktop files, desktop-file-install must be called
> ("desktop-file-install usage" of
>   http://fedoraproject.org/wiki/Packaging/Guidelines )

I will review this and make the change before the next build.

Thank you for looking.

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

------- Additional Comments From [e-mail]  2008-02-16 16:38 EST -------
fldigi-2.09-3.fc8 has been submitted as an update for Fedora 8

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

------- Additional Comments From [e-mail]  2008-02-16 16:39 EST -------
Change made. Tagged, built for devel and F-8, and pushed to F-8.

Thanks!

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-02-16 18:44 EST -------
Thank you Steve, Mamoru, Jeroen and Kevin

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

------- Additional Comments From [e-mail]  2008-02-18 22:18 EST -------
fldigi-2.09-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 432921] Review Request: fldigi - Digital modem program for Linux.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fldigi - Digital modem program for Linux.

https://bugzilla.redhat.com/show_bug.cgi?id=432921

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |CLOSED
         Resolution|NEXTRELEASE                 |CURRENTRELEASE
   Fixed In Version|                            |2.09-3.fc8