Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Summary: Review Request: clex - A free file manager with a full- screen user interface Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kairoaraujo@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://kairo.freeshell.org/devel/fedora/clex/clex.spec SRPM URL: http://kairo.freeshell.org/devel/fedora/clex/clex-3.17-1.fc8.src.rpm Description: CLEX (pronounced KLEKS) is a file manager with a full-screen user interface. It displays directory contents including the file status details and provides features like command history, filename insertion, or name completion in order to help users to create commands to be executed by the shell.
CLEX is a versatile tool for system administrators and all users that utilize the enormous power of the command line. Its unique one-panel user interface enhances productivity and lessens the probability of mistake. There are no built-in commands, CLEX is an add-on to your favorite shell.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
kairoaraujo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-28 20:27 EST ------- The Requires line is redundant, rpmbuild will pick it automatically. The "INSTALL" file can be removed from the %doc list, it is intended for those who install from source. Since Fedora provides directly the binary, it is useless. Those who will build from source will find it inside the tar.gz
Everything else seems OK, runs fine in FC-7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
ianweller@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ianweller@gmail.com
------- Additional Comments From ianweller@gmail.com 2008-01-29 00:51 EST ------- As far as I can tell, this package follows all of the MUSTs in the package review guidelines. manuel's comments should be followed however.
The package also follows every single SHOULD item on the review guidelines list, except for "The package should compile and build into binary rpms on all supported architectures." This somebody else will need to do -- but it looks like it will probably happen.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-29 03:21 EST ------- Ian: you can use koji to do scratch builds for architectures that you cannot build for locally. "koji build --scratch <other mandatory args>". Feel free to do a "informal" review if you are interested. I did not assign this bug to me on purpose, my review is already completed but I want to leave an opportunity for other people looking for sponsorship.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-01-29 06:10 EST ------- New revision: Spec URL: http://kairo.freeshell.org/devel/fedora/clex/clex.spec SRPM URL: http://kairo.freeshell.org/devel/fedora/clex/clex-3.17-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-29 06:21 EST ------- Do you have a specific reason to insist in keeping the "Requires" ? It's not wrong, but it is useless, rpmbuild will add it automatically
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-01-29 06:43 EST ------- If specified in BuildRequires, rpmbuild will add it automatically. It's the rule?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-29 07:15 EST ------- BuildRequires is an indication for rpm specifying what resources are needed in order to _build_ the package. Requires is an indication of resources (or "dependencies") needed to _install_ (or use) the package. After building a package, rpmbuild will "take a look" at the files which are about to be packaged and create the list of dependencies, taking into consideration for instance the libs which are called. Quite often this automatic list covers all the needs of the application.
Please try to make time and read the resources available in the wiki, starting from http://fedoraproject.org/wiki/PackageMaintainers and most especially the docs from the "Packaging" section. The two books listed under "Further readings" are a must.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-01-29 07:45 EST ------- New revision: Spec URL: http://kairo.freeshell.org/devel/fedora/clex/clex.spec SRPM URL: http://kairo.freeshell.org/devel/fedora/clex/clex-3.17-3.fc8.src.rpm
I understood the differences of BuildRequires and Requires. I'm studying about this and other subjects.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From ianweller@gmail.com 2008-01-29 18:17 EST ------- I'll get a koji build done on my computer as soon as I have time, which hopefully will be tomorrow. If anyone else wants to do it, by all means go ahead.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From ianweller@gmail.com 2008-01-30 00:41 EST ------- I apparently can't figure out koji. According to documents and whatnot, it's either I need an account on fedora's koji server, which would mean I need sponsored... (not yet but hopefully soon) or I would need to set up my own koji server, which I really don't have time for.
But regardless, it appears to be a solid package. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-30 02:30 EST ------- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on:devel/x86_64 [x] Rpmlint output: source RPM:empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 05ff8cb880ca74395f75f5c8ade87e7637064d65 /tmp/clex-3.17.tar.gz [x] Package is not known to require [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64& F7/x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on:only x86_64 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [x] File based requires are sane.
=== Issues === 1. none
================ *** APPROVED *** but pending sponsorhip ================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | Flag|fedora-review? |fedora-review+
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-26 03:27 EST ------- Removing "sponsorship needed" flag, I will sponsor Kairo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-03-26 13:58 EST ------- New Package CVS Request ======================= Package Name: clex Short Description: A free file manager with a full-screen user interface Owners: kairo Branches: F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-26 14:15 EST ------- Kairo, you must first complete the sponsorship process.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-26 14:29 EST ------- Please follow these two links, depending on which phase you are (probably the first link below is the first one you have to visit): http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8956... http://fedoraproject.org/wiki/PackageMaintainers/Join#head-0dbf12f9c493a3f20...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-03-26 15:40 EST ------- I made this process in the past. I have account in Fedora Account System and CLA done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-26 16:04 EST ------- In this case I assume you need to proceed with step 4 from http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8956... (-> look for the cvsextras group, and click Apply under Status)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From kairoaraujo@gmail.com 2008-03-26 16:29 EST ------- I made this for cvsextras in the past too. cvsextras and fedorabugs with unapproved status.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
kairoaraujo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From kairoaraujo@gmail.com 2008-03-28 21:50 EST ------- New Package CVS Request ======================= Package Name: clex Short Description: A free file manager with a full-screen user interface Owners: kairo Branches: F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-29 14:48 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: clex - A free file manager with a full-screen user interface
https://bugzilla.redhat.com/show_bug.cgi?id=430603
------- Additional Comments From wolfy@nobugconsulting.ro 2008-04-17 18:58 EST ------- closing the bug, the package has been built and pushed to rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ndowens04@gmail.com
--- Comment #22 from Nathan Owe ndowens04@gmail.com 2011-07-28 22:12:59 EDT --- Package Change Request ====================== Package Name: clex Owners: ndowens InitialCC:
The package was orphaned, and I am interested in adopting. Updated package version and SPEC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #23 from Nathan Owe ndowens04@gmail.com 2011-07-28 22:14:56 EDT --- Package Change Request ====================== Package Name: clex Un-retire: f15 Owners: ndowens
InitialCC:
The package was orphaned, and I am interested in adopting. Updated package version and SPEC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #24 from Nathan Owe ndowens04@gmail.com 2011-07-28 23:04:59 EDT --- Package Change Request ====================== Package Name: clex Un-retire: f15 f14 Owners: ndowens
InitialCC:
The package was orphaned, and I am interested in adopting. Updated package version and SPEC
Sorry. I found out that this package compiles fine on f14 so I decided to take it up as well and update it. Also updating f14 will fix bug #527268
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #25 from Nathan Owe ndowens04@gmail.com 2011-07-28 23:08:00 EDT --- Actually bug #527269
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #26 from Jon Ciesla limb@jcomserv.net 2011-07-29 07:57:09 EDT --- Unretired, take ownership in pkgdb.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #27 from Nathan Owe ndowens04@gmail.com 2011-07-29 21:54:49 EDT ---
I am unable to push changes to f15 and f14, says that I am denied and ACL page of the package says orphaned. So it seems I am the owner of the master but not f14 and f15.
Thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #28 from Jason Tibbitts tibbs@math.uh.edu 2011-07-29 22:21:31 EDT --- I unretired the f14 and f15 branches for you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #29 from Nathan Owe ndowens04@gmail.com 2011-07-29 22:24:20 EDT --- Thank you :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #30 from Nathan Owe ndowens04@gmail.com 2011-08-21 21:46:00 EDT --- Package Change Request ====================== Package Name: clex New Branches: f16 Owners: ndowens InitialCC:
Add f16 branch please
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #31 from Jon Ciesla limb@jcomserv.net 2011-08-22 05:50:37 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE | Flag|fedora-review+, fedora-cvs+ | Keywords| |Reopened
--- Comment #32 from Nathan Owe ndowens04@gmail.com 2012-01-20 13:50:48 EST --- #fedora-devel said package needs to be re-reviewed since I am having issue with getting it to build for f16.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Nathan Owe ndowens04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wolfy@nobugconsulting.ro |ndowens04@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #33 from Fedora Update System updates@fedoraproject.org 2012-04-08 21:24:10 EDT --- clex-4.6.4-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/clex-4.6.4-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #34 from Nathan Owe ndowens04@gmail.com 2012-04-08 21:32:28 EDT --- Can somebody please re-review this package so maybe it will be unblocked from dist-f16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
--- Comment #35 from Jason Tibbitts tibbs@math.uh.edu 2012-04-09 18:40:26 EDT --- Nobody is going to re-review a ticket in this state. I only happened to see it by chance. If you would like a re-review, please file a new review request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=430603
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #36 from Fedora Update System updates@fedoraproject.org 2012-04-11 12:58:53 EDT --- Package clex-4.6.4-1.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing clex-4.6.4-1.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-5674/clex-4.6.4-1.fc15 then log in and leave karma (feedback).
package-review@lists.fedoraproject.org