https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Bug ID: 2155325 Summary: Review Request: rust-smartstring - Compact inlined strings Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-smartstring.spec SRPM URL: https://salimma.fedorapeople.org/rust-smartstring-1.0.1-1.fc37.src.rpm
Description: Compact inlined strings.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2155327
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2155327 [Bug 2155327] Review Request: rust-rxml - Minimalistic, restricted XML 1.0 parser which does not include dangerous XML features
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=95572567
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |POST
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MPL-2.0+) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
You might want to add a comment as to why you're removing the criterion dev-dependency, like here: https://src.fedoraproject.org/rpms/rust-unicode-xid/blob/rawhide/f/rust-unic...
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
Will add the comment when importing
❯ fedpkg request-repo rust-smartstring 2155325 https://pagure.io/releng/fedora-scm-requests/issue/49952
❯ fedpkg request-branch --repo rust-smartstring --all-releases https://pagure.io/releng/fedora-scm-requests/issue/49953 https://pagure.io/releng/fedora-scm-requests/issue/49954
❯ fedpkg request-branch --repo rust-smartstring epel9 https://pagure.io/releng/fedora-scm-requests/issue/49955
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-smartstring
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-ae11e26767 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-815ee95850 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-815ee95850
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-74ed908696 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-74ed908696
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-01-04 01:24:03
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-74ed908696 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-815ee95850 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2155325
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com