[Bug 481594] New: Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-pygooglechart -  A complete Python wrapper for the Google Chart API

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Summary: Review Request: python-pygooglechart -  A complete
                    Python wrapper for the Google Chart API
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://stahnma.fedorapeople.org/reviews/python-pygooglechart.spec
SRPM URL:
http://stahnma.fedorapeople.org/reviews/python-pygooglechart-0.2.1-1.fc11.sr...
Description: pygooglechart is a complete Python wrapper for the Google Chart
API.
See http://pygooglechart.slowchop.com/

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Jochen Schmitt   2009-01-26 15:17:02 EDT ---
Good:
+ Basename of the SPEC file patches with package name
+ Package name fits naming guidelines
+ Package is written in English
+ Could download upstream package via spectoll -g
+ Package contains the most current release of the software
+ Source tar ball in package matches with upstream
(md5sum: ec6e1ddd678485c7971c8c0b5dd3cec6)
+ Package contains no patches
+ Package has proper BRs
+ Package will build as noarch
+ Package contains a valid license tag
+ GPLv3+ is a valid OSS license
+ consistently usage of rpm macros.
+ Package contains no subpackages
+ Small %doc stanza, so we need no separate doc subpackage
+ Local buidl works fine
+ Local install works fine
+ Try to run the samples scripts works fine
+ Locel uninstall works fine
+ Build on koni works fine
+ Rpmlint is silent on SRPM and binary rpm.
+ Buildroot will been cleaned on the beginning of %clean and %install
+ Package contains %clean stanza
+ Files have proper files permission
+ All files belong to the package
+ No files from the package is claimed by an other package.
+ Proper %changelog

Bad:
- Upstream package contains a verbatin package of the license text which
was no put into the %doc stanza
- I have found a test/test.py files, so it may be nice, if you can create
a %check stanza in which this script may be execute as a testsuite.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #2 from Michael Stahnke   2009-01-26 22:26:23 EDT ---
http://stahnma.fedorapeople.org/reviews/python-pygooglechart-0.2.1-2.fc11.sr...
http://stahnma.fedorapeople.org/reviews/python-pygooglechart.spec

Updated per your requests.  Note the %check section will skip some test because
from what I could tell PyQrCodec is not packaged for for Fedora, so I couldn't
make it a BR.  Everything builds fine and all other tests (and the test file in
general) do pass.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #3 from Jochen Schmitt   2009-01-27 10:52:44 EDT ---
Good:
+ Package contains verbatin copy of the license text
+ Package contains a %check stanza
+ Local build works fine

Bad:
- Koji build fails. Please refer to
http://koji.fedoraproject.org/koji/taskinfo?taskID=1086077
This is caused by the PyQrCodec issue, If you are unable to fix it, we should
remove the %scheck stanza.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #4 from Michael Stahnke   2009-01-27 11:23:24 EDT ---
Yes, it appears that trying to connect to the internet is the problem through
Koji.  The unit tests attempt to contact GoogleCharts.  I actually don't think
it's PyQrCodec.  Either way, the %check has to go.

Rebuilt:
http://stahnma.fedorapeople.org/reviews/python-pygooglechart-0.2.1-3.fc11.sr...
http://stahnma.fedorapeople.org/reviews/python-pygooglechart.spec

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #5 from Jochen Schmitt   2009-01-27 11:38:49 EDT ---
Sorry, I have got a 404 error.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #6 from Michael Stahnke   2009-01-27 15:03:07 EDT ---
http://stahnma.fedorapeople.org/reviews/python-pygooglechart-0.2.1-3.fc11.sr...

Sorry, accidentally uploaded the fc10 one instead of fc11.

Fixed now.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Jochen Schmitt   2009-01-28 10:25:04 EDT ---
Good:
+ Package has comment about why the test script could not used.
+ Local build works fine.
+ Build on koji works fine

*** APPROVED ***

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Michael Stahnke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Michael Stahnke   2009-01-28 22:05:26 EDT ---
New Package CVS Request
=======================
Package Name: python-pygooglechart
Short Description: A complete Python wrapper for the Google Chart API
Owners: stahnma
Branches: F9, F10, EL4, EL5
InitialCC:

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #9 from Kevin Fenzi   2009-01-30 01:19:00 EDT ---
cvs done.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #10 from Jochen Schmitt   2009-03-03 12:25:06 EDT ---
Please close this bug, if you have push this new package on bodhi.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Michael Stahnke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #11 from Fedora Update System   2009-03-04 11:22:17 EDT ---
python-pygooglechart-0.2.1-3.fc9 has been pushed to the Fedora 9 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |0.2.1-3.fc9

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

--- Comment #12 from Fedora Update System   2009-03-04 11:27:23 EDT ---
python-pygooglechart-0.2.1-3.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481594

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|0.2.1-3.fc9                 |0.2.1-3.fc10