[Bug 449328] New: Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=449328

Summary: Review Request: cluttermm - C++ wrapper for clutter
                    library
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.poolshark.org/src/cluttermm.spec
SRPM URL: http://www.poolshark.org/src/cluttermm-0.5.1-1.fc9.src.rpm

Description:
Cluttermm is a C++ wrapper library for clutter: an OpenGL-based
library for creating fast, visually rich and animated graphical user
interfaces.

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-02 04:24 EST -------
Patch filed upstream at

http://bugzilla.gnome.org/show_bug.cgi?id=536181

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-03 02:00 EST -------
package doesn't build in mock:
...
checking for CLUTTERMM...
configure: error: Package requirements (gtkmm-2.4 >= 2.10.9
                  clutter-0.6) were not met:
No package 'gtkmm-2.4' found
...

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-03 02:13 EST -------
Well that was embarassing. Here's the fix.

Spec URL: http://www.poolshark.org/src/cluttermm.spec
SRPM URL: http://www.poolshark.org/src/cluttermm-0.5.1-2.fc9.src.rpm

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-03 19:03 EST -------
(In reply to comment #3)
> Well that was embarassing. Here's the fix.

Hate to say it, but it still fails to build.  Looks like a file your trying to
package as documentation doesn't exist.  Here's a link to a scratch build log:
http://koji.fedoraproject.org/koji/getfile?taskID=644003&name=build.log

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-03 22:41 EST -------
(In reply to comment #4)
> (In reply to comment #3)
> > Well that was embarassing. Here's the fix.
>
> Hate to say it, but it still fails to build.  Looks like a file your trying to
> package as documentation doesn't exist.  Here's a link to a scratch build log:
> http://koji.fedoraproject.org/koji/getfile?taskID=644003&name=build.log

This seems "touch" problem we are discussing on fedora-devel-list
starting on:
https://www.redhat.com/archives/fedora-devel-list/2008-June/msg00153.html

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-04 05:17 EST -------
Right, no koji builds until this is fixed.

For the record, it builds for me on F-9 i386, F-9 x86_64 and F10 i386.

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

------- Additional Comments From [e-mail]  2008-06-04 12:45 EST -------
By the way coreutils-6.12-1.fc10 is now untagged and I guess
now koji build succeeds.

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-06-04 21:43 EST -------
MD5Sum:
74ea582eccf312885bd190758018b5a2  cluttermm-0.5.1.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces the following warnings that can be ignored:
  cluttermm-cairo.i386: W: no-documentation
  cluttermm-gtk.i386: W: no-documentation
* Package installs and uninstalls cleanly

Bad:
* Looking at the pkg-config files for some of your devel subpackages, it looks
like your missing a couple of requires.  The cluttermm-cairo-devel package looks
like it's missing a requires on cairomm-devel. The cluttermm-gtk-devel package
looks like it's missing a requires on gtkmm24-devel.  Please verify this before
importing it into CVS.

+1 APPROVE

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-06-05 00:17 EST -------
Yes, you're correct on the missing requires.

New Package CVS Request
=======================
Package Name: cluttermm
Short Description: C++ wrapper for clutter library
Owners: denis
Branches: F-8 F-9
Cvsextras Commits: yes

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-06-05 12:19 EST -------
cvs done.

[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library

https://bugzilla.redhat.com/show_bug.cgi?id=449328

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-06-06 02:36 EST -------
Brian, thanks for the quick review again.