[Bug 849496] New: Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

Bug ID: 849496
        QA Contact: [e-mail]
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: [e-mail],
                    [e-mail]
          Assignee: [e-mail]
           Summary: Review Request: webbit - Event-based WebSocket and
                    HTTP server for Java
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: [e-mail]
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL: http://fedorapeople.org/~dcallagh/webbit/webbit.spec
SRPM URL: http://fedorapeople.org/~dcallagh/webbit/webbit-0.4.14-1.fc18.src.rpm
Description: Webbit is an event-based WebSocket and HTTP server for Java.
Fedora Account System Username: dcallagh

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |652183 (FE-JAVASIG)
              Flags|                            |needinfo?(dcallagh@redhat.c
                   |                            |om)

--- Comment #1 from Jason Tibbitts  ---
I am triaging old review tickets.  I can't promise a review if you reply, but
by closing out the stale tickets we can devote extra attention to the ones
which aren't stale.

Ths package fails to build for me.  Here's a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5505769

I suspect it needs some updating to meet current Java packaging guidelines. 
For example, the javadoc subpackage is mandatory.  I'm no Java expert, though.

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

Dan Callaghan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dcallagh@redhat.c |
                   |om)                         |

--- Comment #2 from Dan Callaghan  ---
Created attachment 761917
  --> https://bugzilla.redhat.com/attachment.cgi?id=761917&action=edit
rawhide build log for webbit-0.4.15-1 with test failure

I've updated the package:

http://fedorapeople.org/~dcallagh/webbit/webbit.spec
http://fedorapeople.org/~dcallagh/webbit/webbit-0.4.15-1.fc18.src.rpm

I believe it meets all guidelines now, however the build is failing in Rawhide
for me because of a test failure. It seems to be related to the newer netty
version in F19/Rawhide (I don't see the test failure in F18). If anyone has any
ideas what's going wrong here I'd appreciate some help...

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from gil cattaneo  ---
excuse me, which version of Fedora you want to use this package?
regards

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

--- Comment #4 from Dan Callaghan  ---
(In reply to gil cattaneo from comment #3)
> excuse me, which version of Fedora you want to use this package?

I'm not sure I understand the question... I was planning to build this for all
current Fedora releases (F18 and newer I suppose, since F17 is almost EOL).

But I still haven't had a chance to look into the test failures related to
netty from comment 2.

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

--- Comment #5 from Dan Callaghan  ---
I filed an upstream issue about this test failure in rawhide:

https://github.com/webbit/webbit/issues/121

The master branch of webbit is using netty 3.6.5 but it breaks with netty 3.6.6
(in rawhide). Neither I nor the webbit author could figure out why.

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail] |
                   |project.org                 |
                 CC|                            |[e-mail]

--- Comment #6 from gil cattaneo  ---
please, these BRs must be removed are alredy requred by "java tools"
BuildRequires:  jpackage-utils
BuildRequires:  maven-compiler-plugin
BuildRequires:  maven-install-plugin
BuildRequires:  maven-jar-plugin
BuildRequires:  maven-javadoc-plugin
BuildRequires:  maven-resources-plugin
BuildRequires:  maven-surefire-plugin

also these for the same reason
Requires:       java
Requires:       jpackage-utils

if you want install in /usr/share/java instead of /usr/share/java/webbit
you can use
%mvn_file org.webbitserver:%{name} %{name}
OR
%mvn_file :%{name} %{name}
OR
%mvn_file : %{name}
this is possible only for those package which provides artifacts <= 2
regards

[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=849496

Dan Callaghan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady