[Bug 2318408] New: Review Request: python-sqlmodel - SQL databases in Python, designed for simplicity, compatibility, and robustness
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Bug ID: 2318408 Summary: Review Request: python-sqlmodel - SQL databases in Python, designed for simplicity, compatibility, and robustness Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedoraproject.org/python-sqlmodel.spec SRPM URL: https://music.fedoraproject.org/python-sqlmodel-0.0.22-1.fc40.src.rpm Description:
SQLModel is a library for interacting with SQL databases from Python code, with Python objects. It is designed to be intuitive, easy to use, highly compatible, and robust.
SQLModel is based on Python type annotations, and powered by Pydantic and SQLAlchemy.
The key features are:
• Intuitive to write: Great editor support. Completion everywhere. Less time debugging. Designed to be easy to use and learn. Less time reading docs. • Easy to use: It has sensible defaults and does a lot of work underneath to simplify the code you write. • Compatible: It is designed to be compatible with FastAPI, Pydantic, and SQLAlchemy. • Extensible: You have all the power of SQLAlchemy and Pydantic underneath. • Short: Minimize code duplication. A single type annotation does a lot of work. No need to duplicate models in SQLAlchemy and Pydantic.
Fedora Account System Username: music
This is by the same author as FastAPI and Typer, and has the same odd structure with regular and -slim versions; see https://src.fedoraproject.org/rpms/python-fastapi and https://src.fedoraproject.org/rpms/python-typer.
This is an optional test dependency for python-fastapi.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Ben Beasley code@musicinmybrain.net --- Correction:
Spec URL: https://music.fedorapeople.org/python-sqlmodel.spec SRPM URL: https://music.fedorapeople.org/python-sqlmodel-0.0.22-1.fc40.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8280409 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |benson_muite@emailplus.org Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 693 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-sqlmodel/2318408- python-sqlmodel/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9152 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-sqlmodel , python3-sqlmodel-slim [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-sqlmodel-0.0.22-1.fc42.noarch.rpm python3-sqlmodel-slim-0.0.22-1.fc42.noarch.rpm python-sqlmodel-0.0.22-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_bjzk083')] checks: 32, packages: 3
python3-sqlmodel.noarch: W: python-leftover-require python3-sqlmodel-slim python3-sqlmodel.noarch: W: no-documentation ========= 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 15 filtered, 0 badness; has taken 4.9 s ==========
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
python3-sqlmodel.noarch: W: python-leftover-require python3-sqlmodel-slim python3-sqlmodel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 11 filtered, 0 badness; has taken 1.2 s
Source checksums ---------------- https://github.com/fastapi/sqlmodel/archive/0.0.22/sqlmodel-0.0.22.tar.gz : CHECKSUM(SHA256) this package : b9bffd6db6c4a5428e23f4d53dec305c45ec19e58875a0ed1061e963748b2ee2 CHECKSUM(SHA256) upstream package : b9bffd6db6c4a5428e23f4d53dec305c45ec19e58875a0ed1061e963748b2ee2
Requires -------- python3-sqlmodel (rpmlib, GLIBC filtered): (python3.13dist(pydantic) < 3~~ with python3.13dist(pydantic) >= 1.10.13) (python3.13dist(sqlalchemy) < 2.1~~ with python3.13dist(sqlalchemy) >= 2.0.14) python(abi) python3-sqlmodel-slim
python3-sqlmodel-slim (rpmlib, GLIBC filtered): (python3.13dist(pydantic) < 3~~ with python3.13dist(pydantic) >= 1.10.13) (python3.13dist(sqlalchemy) < 2.1~~ with python3.13dist(sqlalchemy) >= 2.0.14) python(abi)
Provides -------- python3-sqlmodel: python-sqlmodel python3-sqlmodel python3.13-sqlmodel python3.13dist(sqlmodel) python3dist(sqlmodel)
python3-sqlmodel-slim: python-sqlmodel-slim python3-sqlmodel-slim python3.13-sqlmodel-slim python3.13dist(sqlmodel-slim) python3dist(sqlmodel-slim)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2318408 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, PHP, Haskell, SugarActivity, R, Ocaml, C/C++, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Would be nice to have some documentation, but not a blocker. Seems only webpages can be generated directly from what is provided. b) Consider adding %doc SECURITY.md c) Approved d) Is it possible to complete review of https://bugzilla.redhat.com/show_bug.cgi?id=2322082
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- python-typer and python-fastapi spec files have reasons for the unusual package splits. Maybe helpful to add similar comments in the current spec file or refer to the other two packages.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- Thank you for the review!
(In reply to Benson Muite from comment #4)
python-typer and python-fastapi spec files have reasons for the unusual package splits. Maybe helpful to add similar comments in the current spec file or refer to the other two packages.
I have
# This package corresponds to two PyPI projects (sqlmodel-slim, and sqlmodel) # co-developed in one repository. Since the two are versioned identically and # released at the same time, it makes sense to build them from a single source # package.
at the top of the spec file, which is almost identical to the comments in the python-fastapi and python-typer spec files. Is there a different comment that you had in mind?
https://release-monitoring.org/project/283800/
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sqlmodel
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ee7e26e3 (python-sqlmodel-0.0.22-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ee7e26e3
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-11-19 20:26:28
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ee7e26e3 (python-sqlmodel-0.0.22-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-44fe4d6b74 (python-sqlmodel-0.0.22-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-44fe4d6b74
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7f399c958d (python-sqlmodel-0.0.22-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f399c958d
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #11 from Benson Muite benson_muite@emailplus.org --- The split between the files is not clear, For the other two packages, the main reason seems to be to provide a command line interface, so the slim package contains all the working code. The full package adds syntactic sugar that may/may not get in the way of the user.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #12 from Ben Beasley code@musicinmybrain.net --- (In reply to Benson Muite from comment #11)
The split between the files is not clear, For the other two packages, the main reason seems to be to provide a command line interface, so the slim package contains all the working code. The full package adds syntactic sugar that may/may not get in the way of the user.
The -slim thing, and particularly the way it is implemented, is decidedly idiosyncratic to the primary developer of these three packages, but it’s not something we can really opt out of downstream. We need dependencies on python3dist(sqlmodel), python3dist(sqlmodel-slim), or a future python3dist(sqlmodel-slim[standard]) to each be satisfiable, non-conflicting, and bring in the correct set of dependencies.
Right now, python3-sqlmodel and python3-sqlmodel-slim have the same external dependencies,
(python3.13dist(pydantic) < 3~~ with python3.13dist(pydantic) >= 1.10.13) (python3.13dist(sqlalchemy) < 2.1~~ with python3.13dist(sqlalchemy) >= 2.0.14)
but in https://github.com/fastapi/sqlmodel/pull/916 upstream writes,
“In the future SQLModel will include the standard default recommended packages, and sqlmodel-slim will come without those recommended standard packages and with a group of optional dependencies sqlmodel-slim[standard], equivalent to sqlmodel, for those that want to opt out of those packages.”
You can see this with python3-typer and python3-typer-slim:
$ rpm -q --requires -p results_python-typer/0.13.1/1.fc41/python3-typer-slim-0.13.1-1.fc41.noarch.rpm | grep -v rpmlib python(abi) = 3.13 python3.13dist(click) >= 8 python3.13dist(typing-extensions) >= 3.7.4.3 $ rpm -q --requires -p results_python-typer/0.13.1/1.fc41/python3-typer-slim+standard-0.13.1-1.fc41.noarch.rpm | grep -v rpmlib python(abi) = 3.13 python3-typer-slim = 0.13.1-1.fc41 python3.13dist(rich) >= 10.11 python3.13dist(shellingham) >= 1.3 $ rpm -q --requires -p results_python-typer/0.13.1/1.fc41/python3-typer-0.13.1-1.fc41.noarch.rpm | grep -v rpmlib python(abi) = 3.13 python3-typer-cli = 0.13.1-1.fc41 python3-typer-slim = 0.13.1-1.fc41 python3.13dist(click) >= 8 python3.13dist(rich) >= 10.11 python3.13dist(shellingham) >= 1.3 python3.13dist(typing-extensions) >= 3.7.4.3
The PyPI wheels for sqlmodel and sqlmodel-slim contain the same code as each other but have potentially different dependencies, with sqlmodel’s being a superset of sqlmodel-slim‘s. This is true of typer and typer-slim, and of fastapi and fastapi-slim: both wheels ship the same code. In Fedora, we could have python3-sqlmodel and python3-sqlmodel-slim co-own %{python3_sitelib}/sqlmodel and all of its contents, but since python3-sqlmodel is supposed to have all the dependencies python3-sqlmodel-slim does (and possibly more), using a dependency is just as correct, has no real disadvantages, and has fewer caveats around differing versions and file conflicts.
I agree that this is all a very weird way of handling optional dependencies, and it’s somewhat confusing, but it is a very intentional upstream design decision, and the naming and arrangement of the subpackages is just a direct reflection of what upstream publishes.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7f399c958d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7f399c958d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f399c958d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-44fe4d6b74 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-44fe4d6b74 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-44fe4d6b74
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3f4d4c0d43 (python-fastapi-0.115.5-3.fc41, python-jiter-0.7.1-1.fc41, and 5 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f4d4c0d43
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3f4d4c0d43 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3f4d4c0d43` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f4d4c0d43
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3f4d4c0d43 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3f4d4c0d43` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f4d4c0d43
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7f399c958d (python-sqlmodel-0.0.22-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2318408
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3f4d4c0d43 (python-fastapi-0.115.5-3.fc41, python-jiter-0.7.1-1.fc41, and 5 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com