[Bug 2217080] New: Review Request: ocaml-ppx-globalize - Generate functions to copy local values to the global heap
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
Bug ID: 2217080 Summary: Review Request: ocaml-ppx-globalize - Generate functions to copy local values to the global heap Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-globalize/ocaml-ppx-globalize.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-globalize/ocaml-ppx-globalize-0.16... Fedora Account System Username: jjames Description: Ppx_globalize is a ppx rewriter that generates functions to copy local values to the global heap.
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |rjones@redhat.com Doc Type|--- |If docs needed, set a value CC| |rjones@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
--- Comment #1 from Richard W.M. Jones rjones@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables.
(Although not very relevant for OCaml packages)
[x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 7 files have unknown license. Detailed output of licensecheck in /var/tmp/2217080-ocaml-ppx-globalize/licensecheck.txt
Seems to be SPDX "MIT", and that matches the code.
[x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise.
Sort of. It actually uses the %dune_build macro which is correct for OCaml packages using dune.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml: [x]: This should never happen
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged.
Yes the latest (and in fact only) version is 0.16.0
[x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ocaml-ppx-globalize-0.16.0-1.fc38.x86_64.rpm ocaml-ppx-globalize-devel-0.16.0-1.fc38.x86_64.rpm ocaml-ppx-globalize-debuginfo-0.16.0-1.fc38.x86_64.rpm ocaml-ppx-globalize-debugsource-0.16.0-1.fc38.x86_64.rpm ocaml-ppx-globalize-0.16.0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzjksbyxg')] checks: 31, packages: 5
ocaml-ppx-globalize-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppx_globalize/ppx_globalize.a ocaml-ppx-globalize.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ppx_globalize/ppx_globalize.cmxs
RWMJ: These are used internally by the OCaml compiler.
ocaml-ppx-globalize.x86_64: W: no-documentation ocaml-ppx-globalize-devel.x86_64: W: no-documentation
RWMJ: There is literally no useful documentation, even upstream. Which is a problem, but an upstream one.
5 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.1 s
Rpmlint (debuginfo) ------------------- Checking: ocaml-ppx-globalize-debuginfo-0.16.0-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpiz897lys')] checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4
ocaml-ppx-globalize-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppx_globalize/ppx_globalize.a ocaml-ppx-globalize.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ppx_globalize/ppx_globalize.cmxs ocaml-ppx-globalize-devel.x86_64: W: no-documentation ocaml-ppx-globalize.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.2 s
Source checksums ---------------- https://github.com/janestreet/ppx_globalize/archive/v0.16.0/ppx_globalize-0.... : CHECKSUM(SHA256) this package : 426855d04be2c15beb70884fd2e6d662000f63bcca0166f5629e369e645fec97 CHECKSUM(SHA256) upstream package : 426855d04be2c15beb70884fd2e6d662000f63bcca0166f5629e369e645fec97
Requires -------- ocaml-ppx-globalize (rpmlib, GLIBC filtered): ocaml(Astlib) ocaml(Astlib__) ocaml(Astlib__Ast_402) ocaml(Astlib__Ast_403) ocaml(Astlib__Ast_404) ocaml(Astlib__Ast_405) ocaml(Astlib__Ast_406) ocaml(Astlib__Ast_407) ocaml(Astlib__Ast_408) ocaml(Astlib__Ast_409) ocaml(Astlib__Ast_410) ocaml(Astlib__Ast_411) ocaml(Astlib__Ast_412) ocaml(Astlib__Ast_413) ocaml(Astlib__Ast_414) ocaml(Astlib__Ast_500) ocaml(Astlib__Location) ocaml(Astlib__Longident) ocaml(Astlib__Parse) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Bytes) ocaml(Base__Bytes0) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either) ocaml(Base__Either0) ocaml(Base__Either_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Hashable) ocaml(Base__Hashable_intf) ocaml(Base__Hasher) ocaml(Base__Identifiable) ocaml(Base__Identifiable_intf) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Map) ocaml(Base__Map_intf) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_enumerate_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__With_return) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parsetree) ocaml(Path) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Ast_traverse0) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Versions) ocaml(Ppxlib_traverse_builtins) ocaml(Primitive) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Sexplib0__Sexp_conv_grammar) ocaml(Sexplib0__Sexp_grammar) ocaml(Sexplib0__Sexpable) ocaml(Shadow_stdlib) ocaml(Shape) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Array) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__BytesLabels) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Map) ocaml(Stdlib__MoreLabels) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Obj) ocaml(Stdlib__Printexc) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__StdLabels) ocaml(Stdlib__String) ocaml(Stdlib__StringLabels) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml(Stdppx) ocaml(Subst) ocaml(Type_immediacy) ocaml(Types) ocaml(Warnings) rtld(GNU_HASH)
ocaml-ppx-globalize-devel (rpmlib, GLIBC filtered): ocaml(Astlib) ocaml(Astlib__) ocaml(Astlib__Ast_402) ocaml(Astlib__Ast_403) ocaml(Astlib__Ast_404) ocaml(Astlib__Ast_405) ocaml(Astlib__Ast_406) ocaml(Astlib__Ast_407) ocaml(Astlib__Ast_408) ocaml(Astlib__Ast_409) ocaml(Astlib__Ast_410) ocaml(Astlib__Ast_411) ocaml(Astlib__Ast_412) ocaml(Astlib__Ast_413) ocaml(Astlib__Ast_414) ocaml(Astlib__Ast_500) ocaml(Astlib__Location) ocaml(Astlib__Longident) ocaml(Astlib__Parse) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Bytes) ocaml(Base__Bytes0) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either) ocaml(Base__Either0) ocaml(Base__Either_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Hashable) ocaml(Base__Hashable_intf) ocaml(Base__Hasher) ocaml(Base__Identifiable) ocaml(Base__Identifiable_intf) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Map) ocaml(Base__Map_intf) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_enumerate_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__With_return) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parsetree) ocaml(Path) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Ast_traverse0) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Versions) ocaml(Ppxlib_traverse_builtins) ocaml(Primitive) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Sexplib0__Sexp_conv_grammar) ocaml(Sexplib0__Sexp_grammar) ocaml(Sexplib0__Sexpable) ocaml(Shadow_stdlib) ocaml(Shape) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Array) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__BytesLabels) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Map) ocaml(Stdlib__MoreLabels) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Obj) ocaml(Stdlib__Printexc) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__StdLabels) ocaml(Stdlib__String) ocaml(Stdlib__StringLabels) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml(Stdppx) ocaml(Subst) ocaml(Type_immediacy) ocaml(Types) ocaml(Warnings) ocaml-base-devel(x86-64) ocaml-ppx-globalize(x86-64) ocaml-ppxlib-devel(x86-64) ocamlx(Base) ocamlx(Base__Int) ocamlx(Base__List) ocamlx(Base__Map) ocamlx(Base__Option) ocamlx(Base__String) ocamlx(CamlinternalOO) ocamlx(Ppxlib) ocamlx(Ppxlib__Ast_builder) ocamlx(Ppxlib__Ast_pattern) ocamlx(Ppxlib__Ast_traverse) ocamlx(Ppxlib__Attribute) ocamlx(Ppxlib__Deriving) ocamlx(Ppxlib__Loc) ocamlx(Ppxlib__Location) ocamlx(Stdlib)
ocaml-ppx-globalize-debuginfo (rpmlib, GLIBC filtered):
ocaml-ppx-globalize-debugsource (rpmlib, GLIBC filtered):
Provides -------- ocaml-ppx-globalize: ocaml(Ppx_globalize) ocaml-ppx-globalize ocaml-ppx-globalize(x86-64)
ocaml-ppx-globalize-devel: ocaml(Ppx_globalize) ocaml-ppx-globalize-devel ocaml-ppx-globalize-devel(x86-64) ocamlx(Ppx_globalize)
ocaml-ppx-globalize-debuginfo: debuginfo(build-id) ocaml-ppx-globalize-debuginfo ocaml-ppx-globalize-debuginfo(x86-64)
ocaml-ppx-globalize-debugsource: ocaml-ppx-globalize-debugsource ocaml-ppx-globalize-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2217080 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Generic, C/C++, Shell-api, Ocaml Disabled plugins: SugarActivity, Haskell, fonts, R, PHP, Java, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
--- Comment #2 from Richard W.M. Jones rjones@redhat.com --- I feel this package might be really useful to me, if only I understood what it actually does. There is no documentation at all upstream!
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Richard W.M. Jones rjones@redhat.com --- *** Packaged APPROVED for Fedora ***
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
--- Comment #4 from Jerry James loganjerry@gmail.com --- Thank you for the review. Yes, the lack of documentation is annoying. Apparently you can add '[%globalize]' to various declarations to have the values generated on the heap. Some examples would be nice.
I will wait to build this until we create the OCaml 5.0.0 side tag.
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-globalize
https://bugzilla.redhat.com/show_bug.cgi?id=2217080
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |ocaml-ppx-globalize-0.16.0- | |4.fc39 Resolution|--- |NEXTRELEASE Last Closed| |2023-07-13 23:23:37
--- Comment #6 from Jerry James loganjerry@gmail.com --- This package has been built in Rawhide.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com