[Bug 2219471] New: Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Bug ID: 2219471 Summary: Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-prodash.spec SRPM URL: https://blinxen.fedorapeople.org/rust-prodash-25.0.0-1.fc39.src.rpm
Description: A dashboard for visualizing progress of asynchronous and possibly blocking tasks.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
--- Comment #1 from blinxen h-k-81@hotmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102890139
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/pr | |odash
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6138349 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Some of the subpackages fail to install due to missing dependencies:
===
Problem 1: conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch Problem 2: conflicting requests - nothing provides (crate(crosstermion) >= 0.11.0 with crate(crosstermion) < 0.12.0~) needed by rust-prodash+crosstermion-devel-25.0.0-1.fc39.noarch Problem 3: conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 4: conflicting requests - nothing provides (crate(crosstermion/crossterm) >= 0.11.0 with crate(crosstermion/crossterm) < 0.12.0~) needed by rust-prodash+render-line-crossterm-devel-25.0.0-1.fc39.noarch Problem 5: conflicting requests - nothing provides (crate(crosstermion/color) >= 0.11.0 with crate(crosstermion/color) < 0.12.0~) needed by rust-prodash+render-line-devel-25.0.0-1.fc39.noarch Problem 6: conflicting requests - nothing provides (crate(crosstermion/termion) >= 0.11.0 with crate(crosstermion/termion) < 0.12.0~) needed by rust-prodash+render-line-termion-devel-25.0.0-1.fc39.noarch Problem 7: conflicting requests - nothing provides (crate(crosstermion/input-async-crossterm) >= 0.11.0 with crate(crosstermion/input-async-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch - nothing provides (crate(crosstermion/tui-react-crossterm) >= 0.11.0 with crate(crosstermion/tui-react-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch Problem 8: conflicting requests - nothing provides (crate(crosstermion/input-async) >= 0.11.0 with crate(crosstermion/input-async) < 0.12.0~) needed by rust-prodash+render-tui-devel-25.0.0-1.fc39.noarch Problem 9: conflicting requests - nothing provides (crate(crosstermion/tui-react-termion) >= 0.11.0 with crate(crosstermion/tui-react-termion) < 0.12.0~) needed by rust-prodash+render-tui-termion-devel-25.0.0-1.fc39.noarch Problem 10: conflicting requests - nothing provides (crate(tui-react/default) >= 0.20.0 with crate(tui-react/default) < 0.21.0~) needed by rust-prodash+tui-react-devel-25.0.0-1.fc39.noarch Problem 11: package rust-prodash+unit-human-devel-25.0.0-1.fc39.noarch requires crate(prodash/human_format) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 12: package rust-prodash+unit-duration-devel-25.0.0-1.fc39.noarch requires crate(prodash/compound_duration) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch
===
I would recommend to remove features you don't need, and fix the rest. For example, I would drop crosstermion / tui / tui-react dependencies if possible - they frequently publish breaking releases, keeping up with them is quite painful.
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
--- Comment #4 from blinxen h-k-81@hotmail.com --- I deactivated all features which don't build / install. I kept the rest even though I don't need all features. `gix` only requires the `progress-tree` feature.
Updated files can be found under:
Spec URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash.spec SRPM URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash-25.0.0-1.fc39.src...
P.S I will review some of your packages later in return for reviewing my package reviews :D
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1974160 --> https://bugzilla.redhat.com/attachment.cgi?id=1974160&action=edit The .spec file difference from Copr build 6138349 to 6144146
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6144146 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
It would be great if you added a comment in the spec file to describe what the patch does (something like "remove unused optional features with missing dependencies").
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prodash
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4a0d885d08 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4a0d885d08
https://bugzilla.redhat.com/show_bug.cgi?id=2219471
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-07-06 04:12:09
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4a0d885d08 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com