[Bug 429202] New: lqr library for gimp-lqr-plugin

List overview All Threads
Download

newer

older

[Bug 431188] New: Review Request:...

[Bug 291741] New: Review Request:...

Red Hat Bugzilla

17 Jan 2008 17 Jan '08

3:59 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=429202

Summary: lqr library for gimp-lqr-plugin Product: Fedora Version: rawhide Platform: i386 OS/Version: Linux Status: NEW Severity: low Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: alex@tvtransilvania.ro QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://tvtransilvania.ro/ics/Fedora/9/liblqr.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/9/liblqr-1-0.1.0-1.fc9.i386.rpm

The LiquidRescale (lqr) library provides a C/C++ API for performing non-uniform resizing of images by the seam-carving technique.

This package is a part of the LiquidRescale plugin for The GIMP.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by thread

Red Hat Bugzilla

17 Jan 17 Jan

4:05 p.m.

New subject: [Bug 429202] lqr library for gimp-lqr-plugin

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: lqr library for gimp-lqr-plugin

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From tibbs@math.uh.edu 2008-01-17 17:05 EST ------- The SRPM URL does not point to an srpm.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:09 p.m.

New subject: [Bug 429202] lqr library for gimp-lqr-plugin

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: lqr library for gimp-lqr-plugin

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-01-17 17:09 EST ------- Pardon me. SRPM:http://tvtransilvania.ro/ics/Fedora/9/liblqr-1-0.1.0-1.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

18 Jan 18 Jan

7:53 a.m.

New subject: [Bug 429202] lqr library for gimp-lqr-plugin

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: lqr library for gimp-lqr-plugin

https://bugzilla.redhat.com/show_bug.cgi?id=429202

mtasaka@ioa.s.u-tokyo.ac.jp changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:54 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

mtasaka@ioa.s.u-tokyo.ac.jp changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:21 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-18 11:21 EST ------- The license of this software is actually GPLv3. It is okay for this software, however this causes a problem on gimp-lqr-plugin (see bug 314871)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:28 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-18 11:28 EST ------- Actually I want to know why the upstream released this as GPLv3 before checking this package.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

31 Jan 31 Jan

8:59 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-31 09:59 EST ------- Once the license issue on bug 314871 is resolved, I will try to start to check this package.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

19 Feb 19 Feb

2:30 p.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-02-19 15:30 EST -------

Spec URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1-0.1.0-2.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

20 Feb 20 Feb

11:47 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-20 12:47 EST ------- For general packaging guidelines you can refer to: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

For 0.1.0-2:

* spec file name - must coincide with the name of main package, i.e. spec file must have the name "liblqr-1.spec".

* Group tag - Usually the library related rpm has "Group: System Environment/Libraries" and its -devel subpackage usually has "Group: Development/Libraries".

* Requires/BuildRequires - "BuildRequires: glib" is not needed. GIMP uses glib2, liblqr-1 also uses glib2 not glib (GLib 1). Also liblqr-1 has "BuildRequies: gimp-devel", which also pulls glib2 automatically.

- "Requires: pkgconfig" must be removed from main package. The main package is not for development and pkgconfig must not be needed.

- Also "Requires: gimp" is not needed for main package. This library does not need gimp itself, only gimp-libs is needed and such dependency are automatically treated by rpmbuild.

- -devel subpackage does not need "Requires: gimp-devel". From installed pkgconfig .pc file and header files, only "glib2-devel" (and also pkgconfig) is needed as Requires for -devel subpackage

- Also -devel subpackage must have "Requires: %{name} = %{version}-%{release}"

* License - For this package there is no reason that -devel subpackage should have different License tag.

* macros usage consistency - If you want to use %__rm , please also use %__make %__install for consistency.

* symlink for linkage - %{_libdir}/libXXXX.so should be in -devel package (%{_libdir}/libXXXX.so.X symlink should be in main package). This type of errors can be detected by using rpmlint commands (in rpmlint package). ------------------------------------------------------------- [tasaka1@localhost liblqr-1]$ rpmlint *0.1.0-2*rpm liblqr-1.i386: W: devel-file-in-non-devel-package /usr/lib/liblqr-1.so ....... -------------------------------------------------------------

* Directory ownership issue - Please make it sure that all directories which are created when installing a rpm are owned by the rpm. For this package the directory %{_includedir}/lqr-1/, %{_includedir}/lpr must be owned by -devel subpackage.

! By the way, when you write: ------------------------------------------------------------- %files devel %{_includedir}/lqr-1/ ------------------------------------------------------------- This contains the directory %{_includedir}/lqr-1 and all files/directories/etc under %{_includedir}/lqr-1.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:59 p.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-02-20 13:59 EST ------- Spec URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1-0.1.0-3.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

21 Feb 21 Feb

11:23 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-21 12:23 EST ------- For 0.1.0-3:

* Description - The %description of -devel package is wrong. -------------------------------------------------------------- %description devel The libqr-devel package contains the static libraries and header files ^^^^^^^^^^^^^^^^ --------------------------------------------------------------

* .so symlink location (In reply to comment #7)

...

symlink for linkage

%{_libdir}/libXXXX.so should be in -devel package (%{_libdir}/libXXXX.so.X symlink should be in main package). This type of errors can be detected by using rpmlint commands (in rpmlint package).

[tasaka1@localhost liblqr-1]$ rpmlint *0.1.0-2*rpm liblqr-1.i386: W: devel-file-in-non-devel-package /usr/lib/liblqr-1.so .......

- Please check your rpms by rpmlint to detect generic packaging errors. For newest rpm: --------------------------------------------------------------- liblqr-1-devel.i386: E: library-without-ldconfig-postin /usr/lib/liblqr-1.so.0.0.0 liblqr-1-devel.i386: E: library-without-ldconfig-postun /usr/lib/liblqr-1.so.0.0.0 --------------------------------------------------------------- What I said was: - %_libdir/liblqr-1.so.0.0.0 and %_libdir/liblqr-1.so.0 must be in main package - %_libdir/liblqr-1.so must be moved to -devel package.

* BuildRequires - Well, I rechecked BuildRequires and actually glib2-devel is sufficient for BuildRequires (gimp-devel is not needed for BuildRequires)

* Typo - Please fix below (by the way with this typo rebuild actually fails....) --------------------------------------------------------------- find %buildroot -name *.la -exec %rm -f {} ; ^^^^ ---------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:23 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

mtasaka@ioa.s.u-tokyo.ac.jp changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

25 Feb 25 Feb

3:29 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-02-25 04:29 EST ------- Thanks Mamoru for your time, here are the new files. Spec URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1-0.1.0-4.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:57 p.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-25 13:57 EST ------- Created an attachment (id=295827) --> (https://bugzilla.redhat.com/attachment.cgi?id=295827&action=view) Patch for pkgconfig .pc file to remove unneeded directory

For 0.1.0-4:

3 issues

* undefined non-weak symbols ----------------------------------------------------------------- [root@localhost liblqr-1]# rpmlint liblqr-1 liblqr-1-devel liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 g_free liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 sqrt liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 log liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 exp liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 g_try_malloc liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 g_try_malloc0 ----------------------------------------------------------------- - liblqr-1.so contains undefined non-weak symbols. You can check this by $ ldd -r /usr/lib/liblqr-1.so.

As this library is to be used for linkage from other packages, such symbols cannot be allowed because leaving such symbols causes linkage failure.

The following fixes this issue: ------------------------------------------------------------------ %build export LDFLAGS="`pkg-config --libs glib-2.0` -lm" %configure %{__make} %{?_smp_mflags} ------------------------------------------------------------------

* Unneeded libdir in .pc file - On i386, /usr/lib/pkgconfig/lqr-1.pc contains the line: ------------------------------------------------------------------ 10 Libs: -L${libdir}/lqr-1 -llqr-1 ------------------------------------------------------------------ But no libraries are installed under %{_libdir}/lqr-1 so -L${libdir}/lqr-1 is unneed. Please apply the patch attached.

* %buildroot v.s. $RPM_BUILD_ROOT - Please choose one and don't use both.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

29 Feb 29 Feb

5:32 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-02-29 06:32 EST ------- Spec URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/devel/liblqr-1-0.1.0-5.fc9.src.rpm

I have a clean rpmlint report now.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:22 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-29 11:22 EST ------- Please change the permission of files in srpm to 0644.

- This package (liblqr-1) is okay - Your another review request (bug 314871) needs fixing on some points, however I hope it can be approved after some fixes.

------------------------------------------------------------------------- This package (liblqr-1) is APPROVED by me -------------------------------------------------------------------------

Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". At a point a mail should be sent to sponsor members which notifies that you need a sponsor. At the stage, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 7/8, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1 Mar 1 Mar

7:43 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-01 08:43 EST ------- Now I am sponsoring you. Please follow "Join" wiki again.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:24 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From alex@tvtransilvania.ro 2008-03-01 09:24 EST ------- New Package CVS Request ======================= Package Name: liblqr-1 Short Description: LiquidRescale library Owners: ics Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:48 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

alex@tvtransilvania.ro changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:34 p.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-03-01 13:34 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2 Mar 2 Mar

10:27 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

alex@tvtransilvania.ro changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:34 a.m.

New subject: [Bug 429202] Review Request: liblqr-1 - LiquidRescale library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: liblqr-1 - LiquidRescale library

https://bugzilla.redhat.com/show_bug.cgi?id=429202

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-02 11:34 EST ------- Please don't forget to rebuild this package also on F-7/8. Also, for F-7/8, please request the rebuilt packages to push to stable on: https://admin.fedoraproject.org/updates/

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6351

Age (days ago)

6396

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla