https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Bug ID: 2279594 Summary: Review Request: ptyxis - A container oriented terminal Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nmontero@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nmontero.fedorapeople.org/ SRPM URL: https://nmontero.fedorapeople.org/ Description: Ptyxis is a terminal which attempts to simplify what it means to be a terminal in the age of operating systems which are themselves containers. Fedora Account System Username: nmontero
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Nieves nmontero@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |low Severity|medium |low
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
--- Comment #3 from Parag AN(पराग) panemade@gmail.com --- Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- Nieves, package is not building because of missing build dependency on libportal-gtk4 package. You may want to add it as in SPEC file
%global libportal_gtk4_version 0.7.1 BuildRequires: pkgconfig(libportal-gtk4) >= %{libportal_gtk4_version}
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #5 from Nieves nmontero@redhat.com --- (In reply to Parag AN(पराग) from comment #4)
Nieves, package is not building because of missing build dependency on libportal-gtk4 package. You may want to add it as in SPEC file
%global libportal_gtk4_version 0.7.1 BuildRequires: pkgconfig(libportal-gtk4) >= %{libportal_gtk4_version}
Sorry for that. I added the lines, let me know if there's something else should be added/modified.
Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Nieves nmontero@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm Description: Ptyxis is a terminal which attempts to simplify what it means to be a terminal in the age of operating systems which are themselves containers. Fedora Account System Username: nmontero
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- You need to update SRPM file also. Always update SPEC and SRPM at same time. I tried new updated SRPM file and found its failing to build.
See this rawhide scratch build -> https://koji.fedoraproject.org/koji/taskinfo?taskID=117469363
You may want to fix the compilation errors.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- This also needs "Requires: hicolor-icon-theme".
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #8 from Michael Catanzaro mcatanza@redhat.com --- Please also build with -Dgeneric=terminal to remove the Ptyxis branding, so we can use it as the default terminal in Fedora Workstation. (And no need to use -Ddevelopment=false, because that's already the upstream default setting.)
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #9 from Nieves nmontero@redhat.com --- (In reply to Michael Catanzaro from comment #8)
Please also build with -Dgeneric=terminal to remove the Ptyxis branding, so we can use it as the default terminal in Fedora Workstation. (And no need to use -Ddevelopment=false, because that's already the upstream default setting.)
Sure, I will modify it.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #10 from Nieves nmontero@redhat.com --- Both spec and srpm files are already updated on fedora people: Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm
The package is already building and ready to continue
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://gitlab.gnome.org/ch | |ergert/ptyxis
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7671470 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|low |medium
--- Comment #12 from Jens Petersen petersen@redhat.com --- This is licensecheck.txt (without the Unknown or generated files):
GNU General Public License v2.0 or later ---------------------------------------- ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-accel-dialog.c
GNU General Public License v3.0 or later ---------------------------------------- ptyxis-46.1-build/ptyxis-46.1/agent/org.gnome.Ptyxis.Agent.xml ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent-compat.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent-impl.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent-impl.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent-util.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent-util.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-agent.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-container-provider.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-container-provider.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-distrobox-container.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-distrobox-container.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-podman-container.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-podman-container.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-podman-provider.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-podman-provider.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-process-impl.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-process-impl.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-run-context.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-run-context.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-session-container.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-session-container.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-toolbox-container.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-toolbox-container.h ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-unix-fd-map.c ptyxis-46.1-build/ptyxis-46.1/agent/ptyxis-unix-fd-map.h ptyxis-46.1-build/ptyxis-46.1/src/eggshell.c ptyxis-46.1-build/ptyxis-46.1/src/eggshell.h ptyxis-46.1-build/ptyxis-46.1/src/main.c ptyxis-46.1-build/ptyxis-46.1/src/org.gnome.Ptyxis.gschema.xml.in ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-application.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-application.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-client.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-client.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-close-dialog.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-close-dialog.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-container-menu.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-container-menu.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-find-bar.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-find-bar.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-find-bar.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-inspector.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-inspector.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette-preview-color.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette-preview-color.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette-preview.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette-preview.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-palette.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-parking-lot.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-parking-lot.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-preferences-list-item.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-preferences-list-item.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-preferences-window.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-preferences-window.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-preferences-window.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-editor.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-editor.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-editor.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-menu.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-menu.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-row.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-row.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile-row.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-profile.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-session.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-session.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-settings.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-settings.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-accel-dialog.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-accel-dialog.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-row.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-row.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcut-row.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcuts.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-shortcuts.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab-monitor.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab-monitor.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab-notify.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-tab.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-terminal.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-terminal.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-terminal.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-title-dialog.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-title-dialog.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-title-dialog.ui ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-user-palettes.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-user-palettes.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-util.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-util.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-window-dressing.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-window-dressing.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-window.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-window.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-window.ui ptyxis-46.1-build/ptyxis-46.1/src/terminal-regex.h
GNU Lesser General Public License v3.0 or later ----------------------------------------------- ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-action-group.h ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-theme-selector.c ptyxis-46.1-build/ptyxis-46.1/src/ptyxis-theme-selector.h
GNU Library General Public License v2 or later ---------------------------------------------- ptyxis-46.1-build/ptyxis-46.1/src/gdkhsla.c ptyxis-46.1-build/ptyxis-46.1/src/gdkhslaprivate.h
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Michael Catanzaro mcatanza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mcatanza@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Michael Catanzaro mcatanza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review-
--- Comment #13 from Michael Catanzaro mcatanza@redhat.com --- Package Review ==============
This looks pretty good and almost ready. I see only minor stuff to fix:
- SPDX license expression needs to include all of the licenses found by licensecheck - Indentation is wrong here: Requires: hicolor-icon-theme - Man page is missing, which is not a blocker, but you should create an upstream issue report to request a man page - Please use rpmautospec instead of manual release and changelog - This is version 46.1, but the latest stable version is 46.4. Should update to at least that version. (47.alpha is also available now.) - Remove all the Requires for the libraries; they are redundant because RPM already generates Requires for shared libraries for you, e.g.:
libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit)
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [-]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "GNU Library General Public License v2 or later", "GNU Lesser General Public License v3.0 or later", "GNU General Public License v2.0 or later". 326 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/ptyxis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/tr/LC_MESSAGES, /usr/share/icons/hicolor/scalable, /usr/share/locale/pt_BR, /usr/lib, /usr/src/debug, /usr/src, /usr/bin, /usr/share/glib-2.0, /usr/libexec, /usr/share/icons, /usr/share/locale/it, /usr/share/metainfo, /usr, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/it/LC_MESSAGES, /usr/share/icons/hicolor, /usr/share/locale/nl, /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/symbolic/apps, /usr/share, /usr/share/icons/hicolor/symbolic, /usr/share/locale, /usr/share/doc, /usr/share/icons/hicolor/scalable/apps, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/tr, /usr/share/licenses, /usr/share/locale/sv, /usr/share/applications, /usr/share/locale/nl/LC_MESSAGES [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/tr/LC_MESSAGES, /usr/share/icons/hicolor/scalable, /usr/share/locale/pt_BR, /usr/lib, /usr/src/debug, /usr/src, /usr/bin, /usr/share/glib-2.0, /usr/libexec, /usr/share/icons, /usr/share/locale/it, /usr/share/metainfo, /usr, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/it/LC_MESSAGES, /usr/share/icons/hicolor, /usr/share/locale/nl, /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/symbolic/apps, /usr/share, /usr/share/locale/sv/LC_MESSAGES, /usr/share/icons/hicolor/symbolic, /usr/share/locale, /usr/share/doc, /usr/share/icons/hicolor/scalable/apps, /usr/share/locale/tr, /usr/share/licenses, /usr/share/locale/sv, /usr/share/applications, /usr/share/locale/nl/LC_MESSAGES [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 13630 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: ptyxis-46.1-1.fc41.x86_64.rpm ptyxis-debuginfo-46.1-1.fc41.x86_64.rpm ptyxis-debugsource-46.1-1.fc41.x86_64.rpm ptyxis-46.1-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6_i9f94y')] checks: 32, packages: 4
ptyxis.x86_64: W: no-manual-page-for-binary ptyxis ptyxis.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 10) 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 23 filtered, 0 badness; has taken 0.8 s
Rpmlint (debuginfo) ------------------- Checking: ptyxis-debuginfo-46.1-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuv1y36bj')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "ptyxis-debugsource". (none): E: there is no installed rpm "ptyxis". (none): E: there is no installed rpm "ptyxis-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://download.gnome.org/sources/ptyxis/46/ptyxis-46.1.tar.xz : CHECKSUM(SHA256) this package : ee7681e7f3f30e14ee8a371a4222792992f1ef8fc7512355288addf9d697fd62 CHECKSUM(SHA256) upstream package : ee7681e7f3f30e14ee8a371a4222792992f1ef8fc7512355288addf9d697fd62
Requires -------- ptyxis (rpmlib, GLIBC filtered): glib2(x86-64) gtk4(x86-64) hicolor-icon-theme json-glib(x86-64) libadwaita(x86-64) libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libjson-glib-1.0.so.0()(64bit) libjson-glib-1.0.so.0(libjson-glib-1.0.so.0)(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libportal-gtk4.so.1()(64bit) libportal.so.1()(64bit) libvte-2.91-gtk4.so.0()(64bit) rtld(GNU_HASH) vte291-gtk4(x86-64)
ptyxis-debuginfo (rpmlib, GLIBC filtered):
ptyxis-debugsource (rpmlib, GLIBC filtered):
Provides -------- ptyxis: application() application(org.gnome.Ptyxis.desktop) metainfo() metainfo(org.gnome.Ptyxis.metainfo.xml) ptyxis ptyxis(x86-64)
ptyxis-debuginfo: debuginfo(build-id) ptyxis-debuginfo ptyxis-debuginfo(x86-64)
ptyxis-debugsource: ptyxis-debugsource ptyxis-debugsource(x86-64)
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #14 from Jens Petersen petersen@redhat.com --- 46.4 seems to need: %meson -Dgeneric=terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Christian Hergert chergert@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chergert@redhat.com
--- Comment #15 from Christian Hergert chergert@redhat.com --- I just pushed 46.5 which has a ptyxis.1 man page now.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #16 from Jens Petersen petersen@redhat.com --- Since I had already built current ptyxis locally for myself anyway, I pushed it to a copr:
https://copr.fedorainfracloud.org/coprs/petersen/ptyxis/
so more people can try out the latest version.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #17 from Nieves nmontero@redhat.com --- I already updated to 46.5 and made the corrections Michael commented before:
Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #18 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Michael Catanzaro mcatanza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review- |fedora-review+
--- Comment #19 from Michael Catanzaro mcatanza@redhat.com --- Correct link is: https://nmontero.fedorapeople.org/ptyxis-46.5-1.fc41.src.rpm
One remaining problem: the comment above the License field needs to be updated or else removed.
Is the BuildRequires: /usr/bin/appstream-util truly required? Hopefully not? If it's required, then the packaging is OK, but this dependency needs to be removed upstream.
I trust you'll update to rpmautospec when landing so we don't have manual release and changelog management in GNOME packages. (This is not required by Fedora, though.)
I'm going to approve this. Next steps are here: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Proc... (search for "When your package passes the review")
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #20 from Nieves nmontero@redhat.com --- Sorry for that, copy paste typo, here are the good ones (also removed the license comment):
Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.5-1.fc41.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #21 from Michael Catanzaro mcatanza@redhat.com --- To use rpmautospec, replace this:
Release: 1%{?dist}
with:
Release: %autorelease
And then delete the lines after %autochangelog
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
--- Comment #22 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/ptyxis
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2024-11-04 07:37:50
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com