Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-oauth2 - Python support for improved oauth
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Summary: Review Request: python-oauth2 - Python support for improved oauth Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tcallawa@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://auroralinux.org/people/spot/review/new/python-oauth2.spec SRPM URL: http://auroralinux.org/people/spot/review/new/python-oauth2-1.2.1-1.fc14.src... Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2549437 Description:
Oauth2 was originally forked from Leah Culver and Andy Smith's oauth.py code. Some of the tests come from a fork by Vic Fryzel, while a revamped Request class and more tests were merged in from Mark Paschal's fork. A number of notable differences exist between this code and its forefathers:
- 100% unit test coverage. - The DataStore object has been completely ripped out. While creating unit tests for the library I found several substantial bugs with the implementation and confirmed with Andy Smith that it was never fully baked. - Classes are no longer prefixed with OAuth. - The Request class now extends from dict. - The library is likely no longer compatible with Python 2.3. - The Client class works and extends from httplib2. It's a thin wrapper that handles automatically signing any normal HTTP request you might wish to make.
**** PACKAGER NOTE: This is a new dependency for the updated python-twitter package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |645233
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Arun SAG sagarun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sagarun@gmail.com Flag| |fedora-review+
--- Comment #1 from Arun SAG sagarun@gmail.com 2010-10-31 13:20:55 EDT --- [+] OK [X] NOT OKAY [-] NA
[+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [zer0c00l@gnubox SOURCES]$ md5sum oauth2-1.1.3.tar.gz 79ab3c0af3a6295a699f37d0c25239db oauth2-1.1.3.tar.gz
[-] Package needs ExcludeArch [+] BuildRequires correct [-] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [-] Package has a correct %clean section. [+] Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [+] Package is code or permissible content. [-] Doc subpackage needed/used. [-] Packages %doc files don't affect runtime.
[-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [-] .pc files in -devel subpackage/requires pkgconfig [-] .so files in -devel subpackage. [-] -devel package Requires: %{name} = %{version}-%{release} [-] .la files are removed.
[-] Package is a GUI app and has a .desktop file
[+] Package compiles and builds on at least one arch. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates.
[+] No rpmlint output : ignorable [zer0c00l@gnubox oauth2-1.1.3]$ rpmlint ~/rpmbuild/RPMS/noarch/python-oauth2-1.2.1-1.fc13.noarch.rpm python-oauth2.noarch: W: spelling-error Summary(en_US) oauth -> oath, auth, o auth python-oauth2.noarch: W: spelling-error %description -l en_US oauth -> oath, auth, o auth python-oauth2.noarch: W: spelling-error %description -l en_US py -> pt, p, y
[+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [+] check for outstanding bugs on package. (For core merge reviews)
XXX NOTE XXX
Getting deprecation warning from python-httplib2 when importing oauth2 module
In [1]: import oauth2 /usr/lib/python2.6/site-packages/httplib2/__init__.py:44: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import sha
Everything seems fine except deprecation warning.
XXXXXXXX Approved XXXXXXXXXX
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com 2010-11-01 15:48:06 EDT --- That deprecation warning is coming from python-httplib2, not python-oauth2. Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Tom "spot" Callaway tcallawa@redhat.com 2010-11-01 15:49:07 EDT --- New Package SCM Request ======================= Package Name: python-oauth2 Short Description: Python support for improved oauth Owners: spot Branches: f13 f14 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2010-11-03 00:08:06 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2010-11-03 10:07:25 EDT --- python-oauth2-1.2.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2010-11-03 10:07:47 EDT --- python-oauth2-1.2.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-11-03 17:10:39 EDT --- python-oauth2-1.2.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-oauth2'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-11-11 17:18:29 EST --- python-oauth2-1.2.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-oauth2-1.2.1-1.fc13 Resolution| |ERRATA Last Closed| |2010-11-11 17:18:34
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-11-11 17:19:58 EST --- python-oauth2-1.2.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-oauth2-1.2.1-1.fc13 |python-oauth2-1.2.1-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #10 from Rahul Sundaram metherid@gmail.com 2011-07-18 10:46:45 EDT --- Package Change Request ====================== Package Name: python-oauth2 New Branches: el6 Owners: sundaram
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #11 from Rahul Sundaram metherid@gmail.com 2011-07-18 10:47:19 EDT --- Package Change Request ====================== Package Name: python-oauth2 New Branches: el6 Owners: sundaram pjp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645863
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2011-07-18 11:04:17 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org