https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Bug ID: 1936727 Summary: Review Request: ignition-common - AV, Graphics, Events, and much more Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: richmattes@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common-3.10.1... Description: Ignition Common, a component of Ignition Robotics, provides a set of libraries that cover many different use cases. An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Ignition Common contains functionality that spans Base64 encoding/decoding to thread pools.
Fedora Account System Username: rmattes
rpmlint: $ rpmlint ignition-common.spec ../SRPMS/ignition-common-3.10.1-1.fc33.src.rpm ignition-common.spec:77: E: hardcoded-library-path in %{_prefix}/lib/ruby ignition-common.src:77: E: hardcoded-library-path in %{_prefix}/lib/ruby 1 packages and 1 specfiles checked; 2 errors, 0 warnings.
Hard-coded path needed to remove un-needed installed ruby artifacts
Builds can be found on copr - dependencies are too old in rawhide: https://copr.fedorainfracloud.org/coprs/g/robotics-sig/gazebo-latest/package...
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Rich Mattes richmattes@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1694168
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1694168 [Bug 1694168] gazebo-11.0.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - ignition-cmake-devel needs to be updated over 2.0 and ignition-math-devel over 6
- %ldconfig_scriptlets is not needed for Fedora anymore
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
--- Comment #2 from Rich Mattes richmattes@gmail.com --- Thanks for taking a look. You're right that the dependency versions in Fedora are wrong. The entire ignition/gazebo set of packages are version locked and need to be updated at the same time, and this package is required for gazebo-11 and therefore the rest of the ignition packages to be updated. The correct versions are all in the copr I linked, once the new ignition packages are reviewed they'll all be upgraded in rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Some source files have different licenses. Please add them to the license field if they are used and add a comment explaining the license breakdown.
*No copyright* zlib/libpng license ---------------------------------- ignition-common-3.10.1/graphics/src/tinyxml2/tinyxml2.cpp ignition-common-3.10.1/graphics/src/tinyxml2/tinyxml2.h
Boost Software License 1.0 -------------------------- ignition-common-3.10.1/src/FilesystemBoost.cc
Expat License ------------- ignition-common-3.10.1/graphics/src/tiny_obj_loader.h ignition-common-3.10.1/src/win_dirent.h
- Please specify why the patch is needed:
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "Boost Software License 1.0", "Expat License", "BSD 3-clause "New" or "Revised" License", "*No copyright* zlib/libpng license", "BSD 3-clause "New" or "Revised" License [generated file]". 123 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ignition-common/review-ignition- common/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: ignition-common-3.10.1-1.fc35.x86_64.rpm ignition-common-devel-3.10.1-1.fc35.x86_64.rpm ignition-common-doc-3.10.1-1.fc35.noarch.rpm ignition-common-debuginfo-3.10.1-1.fc35.x86_64.rpm ignition-common-debugsource-3.10.1-1.fc35.x86_64.rpm ignition-common-3.10.1-1.fc35.src.rpm ignition-common.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee ignition-common.x86_64: W: spelling-error %description -l en_US protobuf -> prototype ignition-common.x86_64: W: no-manual-page-for-binary ign_remotery_vis ignition-common-devel.x86_64: W: no-documentation ignition-common.src: W: spelling-error %description -l en_US pre -> per, ore, pee ignition-common.src: W: spelling-error %description -l en_US protobuf -> prototype ignition-common.src:74: E: hardcoded-library-path in %{_prefix}/lib/ruby 6 packages and 0 specfiles checked; 1 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
--- Comment #4 from Rich Mattes richmattes@gmail.com --- Thanks for the review, and sorry for the delay. I'm in the process of updating the gazebo-latest copr to provide a place to build a new version of this SRPM.
I've updated to the latest 3.x release (staying with 3.x because gazebo-11 requires version 3), and correct the issues you've identified. I removed some of the non-apache licensed files in %prep, and included notes for the remaining files. The tiny_obj_loader.h file is a local fork of the tinyobjloader package, so I included a bundled virutal provides for it as well (our version of tinyobjloader is too old to build against). I've also added documentation for each patch.
Spec URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common-3.14.0...
Copr build (ignition dependency versions in rawhide are too old, version locked to gazebo-10): https://copr.fedorainfracloud.org/coprs/g/robotics-sig/gazebo-latest/build/3...
rpmlint: $ rpmlint ignition-common.spec ../SRPMS/ignition-common-3.14.0-1.fc35.src.rpm ../RPMS/x86_64/ignition-common{,-devel}-3.14.0-1.fc35.x86_64.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4
ignition-common.x86_64: W: no-manual-page-for-binary ign_remotery_vis ignition-common-devel.x86_64: W: no-documentation ignition-common-devel.x86_64: W: files-duplicate /usr/lib64/cmake/ignition-common3/ignition-common3-config-version.cmake /usr/lib64/cmake/ignition-common3-all/ignition-common3-all-config-version.cmake:/usr/lib64/cmake/ignition-common3-events/ignition-common3-events-config-version.cmake:/usr/lib64/cmake/ignition-common3-graphics/ignition-common3-graphics-config-version.cmake:/usr/lib64/cmake/ignition-common3-profiler/ignition-common3-profiler-config-version.cmake ==================================================== 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 3.9 s ====================================================
The version files are all duplicates of each other because they are auto-generated by CMake and reflect the project's version.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Rich Mattes richmattes@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(richmattes@gmail. | |com) |
--- Comment #6 from Rich Mattes richmattes@gmail.com --- I am still interested in packaging this software.
Product: Fedora Version: rawhide Component: Package Review
Rich Mattes richmattes@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Rich Mattes richmattes@gmail.com's needinfo: Bug 1936727: Review Request: ignition-common - AV, Graphics, Events, and much more https://bugzilla.redhat.com/show_bug.cgi?id=1936727
--- Comment #6 from Rich Mattes richmattes@gmail.com --- I am still interested in packaging this software.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Rich Mattes richmattes@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(richmattes@gmail. | |com) |
--- Comment #8 from Rich Mattes richmattes@gmail.com --- Still interested in this.
Product: Fedora Version: rawhide Component: Package Review
Rich Mattes richmattes@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Rich Mattes richmattes@gmail.com's needinfo: Bug 1936727: Review Request: ignition-common - AV, Graphics, Events, and much more https://bugzilla.redhat.com/show_bug.cgi?id=1936727
--- Comment #8 from Rich Mattes richmattes@gmail.com --- Still interested in this.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |topazus@outlook.com
--- Comment #9 from Felix Wang topazus@outlook.com --- I will try to review the package.
1.
# Bundled gtest and python helper scripts are licensed BSD, but not included in installation # src/FilesystemBoost.cc is licensed under the Boost Software License 1.0 # graphics/src/tiny_obj_loader is licensed MIT # Remaining files are Apache 2 License: ASL 2.0 and Boost and MIT
change the license name to SPDX format
2.
Source0: https://osrf-distributions.s3.us-east-1.amazonaws.com/ign-common/releases/ig...
I suugest use source from its github tag, and update to the latest version. https://github.com/gazebosim/gz-common/releases/tag/ignition-common3_3.17.0
package-review@lists.fedoraproject.org