https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Bug ID: 1395255 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: aurelien@bompard.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zop... SRPM URL: https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zop... Description: his module is already provided by RHEL/CentOS, but only in the Python2 version. I am submitting this package, based on the main one, which only builds the Python3 version, and I'll only request the EPEL7 branch (and later EPEL versions).
Fedora Account System Username: abompard
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Aurelien Bompard aurelien@bompard.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1395244
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1395244 [Bug 1395244] Review Request: python3-zope-event - Zope Event Publication
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yaneti@declera.com Summary|Review Request: <main |Review Request: |package name here> - <short |python3-zope-interface - |summary here> |Zope 3 Interface | |Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Randy Barlow randy@electronsweatshop.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |randy@electronsweatshop.com Assignee|nobody@fedoraproject.org |randy@electronsweatshop.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Randy Barlow randy@electronsweatshop.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aurelien@bompard.org Flags| |needinfo?(aurelien@bompard. | |org)
--- Comment #1 from Randy Barlow randy@electronsweatshop.com --- To pass this, fedora-review wants the COPYRIGHT.txt file to be marked with %license as well.
Optionally, you could remove the .gitignore file that rpmlint is marking as an error, and then you'd have a clean rpmlint.
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Aurelien Bompard aurelien@bompard.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(aurelien@bompard. | |org) |
--- Comment #2 from Aurelien Bompard aurelien@bompard.org --- Ah, my older version of rpmlint did not report that, but now that I'm on F25 it does, nice :-)
Thanks for the review, I fixed both issues.
Spec URL: https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zop... SRPM URL: https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zop...
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Randy Barlow randy@electronsweatshop.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Randy Barlow randy@electronsweatshop.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 81 files have unknown license. Detailed output of licensecheck in /home/rbarlow/reviews/1395255-python3-zope- interface/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.5/site- packages/zope(python3-zope-i18nmessageid, python3-zope-interface) randy: This seems to be how zope is doing things. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 204800 bytes in 16 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -zope-interface-debuginfo randy: This isn't needed. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-zope-interface-4.3.2-1.fc26.x86_64.rpm python3-zope-interface-debuginfo-4.3.2-1.fc26.x86_64.rpm python3-zope-interface-4.3.2-1.fc26.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (debuginfo) ------------------- Checking: python3-zope-interface-debuginfo-4.3.2-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python3-zope-interface (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython3.5m.so.1.0()(64bit) python(abi) rtld(GNU_HASH)
python3-zope-interface-debuginfo (rpmlib, GLIBC filtered):
Provides -------- python3-zope-interface: python3-zope-interface python3-zope-interface(x86-64) python3.5dist(zope.interface) python3dist(zope.interface)
python3-zope-interface-debuginfo: python3-zope-interface-debuginfo python3-zope-interface-debuginfo(x86-64)
Unversioned so-files -------------------- python3-zope-interface: /usr/lib64/python3.5/site-packages/zope/interface/_zope_interface_coptimizations.cpython-35m-x86_64-linux-gnu.so
Source checksums ---------------- https://pypi.io/packages/source/z/zope.interface/zope.interface-4.3.2.tar.gz : CHECKSUM(SHA256) this package : 6a0e224a052e3ce27b3a7b1300a24747513f7a507217fcc2a4cb02eb92945cee CHECKSUM(SHA256) upstream package : 6a0e224a052e3ce27b3a7b1300a24747513f7a507217fcc2a4cb02eb92945cee
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1395255 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-zope-interface
https://bugzilla.redhat.com/show_bug.cgi?id=1395255 Bug 1395255 depends on bug 1395244, which changed state.
Bug 1395244 Summary: Review Request: python3-zope-event - Zope Event Publication https://bugzilla.redhat.com/show_bug.cgi?id=1395244
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |python3-zope-interface-4.3. | |3-1.el7 Resolution|--- |CURRENTRELEASE Last Closed| |2017-05-03 17:36:20
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla