[Bug 1470635] New: Review Request: glslang - OpenGL and OpenGL ES shader front end and validator
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
Bug ID: 1470635 Summary: Review Request: glslang - OpenGL and OpenGL ES shader front end and validator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: leigh123linux@googlemail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://leigh123linux.fedorapeople.org/pub/review/glslang/1/glslang.spec
SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/glslang/1/glslang-3.1-0.1....
Description: glslang is the official reference compiler front end for the OpenGL ES and OpenGL shading languages. It implements a strict interpretation of the specifications for these languages.
Fedora Account System Username: leigh123linux
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
Björn "besser82" Esser besser82@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |besser82@fedoraproject.org Assignee|nobody@fedoraproject.org |besser82@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Björn "besser82" Esser besser82@fedoraproject.org --- Taken
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
Björn "besser82" Esser besser82@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #2 from Björn "besser82" Esser besser82@fedoraproject.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
---> False positive
- Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: glslang-devel. Does not provide -static: glslang-devel. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
---> This is argueable, but since this is a compiler it is fine this way.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated". 1249 files have unknown license. Detailed output of licensecheck in /home/besser82/vm_shared/fedora/review/1470635-glslang/licensecheck.txt
---> Please add ASL-2.0 to License tag.
[x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec.
---> Please document the licensing breakdown in the spec file.
[x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(python- libxml2, libmad, cups-client, efivar-libs, netcdf, rsyslog, policycoreutils-python-utils, qemu-block-gluster, rpm-plugin-selinux, abrt, ghc-transformers, libimagequant, giflib, libreoffice- graphicfilter, trousers, libdb-utils, tracker-miners, xorg-x11-font- utils, OpenEXR-libs, libcom_err, libseccomp, arprec, openblas- openmp64_, p11-kit, libabw, gtkspell, libvirt-daemon-driver-storage- iscsi, libmodman, xdotool, ghc-semigroups, cfitsio, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-Encode, elfutils, python2-cryptography, libevdev, libgpg-error, lvm2-libs, libchromaprint, perl-Digest-SHA, libzstd, gtk-murrine-engine, xdg- desktop-portal-gtk, ghc-mmorph, lua-lpeg, symlinks, openbox-libs, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs, lcms2, qemu- guest-agent, ntfs-3g, libxcb, freexl, libyubikey, sssd-common-pac, openconnect, rtkit, xcb-util-keysyms, orc, m4, libgphoto2, cdparanoia, xcb-util, libwmf-lite, python3-coverage, anaconda-widgets, http- parser, java-1.8.0-openjdk, pulseaudio-utils, libeot, ImageMagick-c++, systemd-bootchart, uniconvertor, python3-scipy, ghc-old-time, ncurses- libs, libidn2, ldns, libreport-plugin-logger, gnome-color-manager, fcoe-utils, xorg-x11-xkb-utils, python-setproctitle, NetworkManager- openvpn, libxkbfile, hplip-libs, libwvstreams, ghc-binary, xmlrpc-c-client, sane-backends-drivers-cameras, python3-hawkey, libwpd, libdc1394, libvirt-daemon-driver-qemu, perl-Time-HiRes, ghc- filemanip, qemu-block-ssh, libwps, gssdp, ghc-zlib, libacl, xorg-x11 -drv-ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi, libgdiplus, libmusicbrainz5, ghc-unix, pptp, sane-backends-drivers- scanners, libXxf86misc, foomatic, minizip, colord-gtk, dbus-x11, libpath_utils, libicu-devel, rpm-build, wodim, libcangjie, libglvnd- gles, rpm-plugin-systemd-inhibit, setroubleshoot, freeglut, gstreamer1, gmime30, ccache, dbus-libs, cinnamon-screensaver, libreoffice-gtk3, libreoffice-gtk2, optipng, librtmp, cairo-gobject, gnome-screenshot, libkkc, gutenprint, openal-soft, usermode, ghc-SHA, cinnamon-desktop, qpdf-libs, linux-atm-libs, libedit, ghc-hashable, chrpath, openssl, python3-cairo, stoken-libs, accountsservice, ghc- containers, isl, ghc-integer-logarithms, hfsplus-tools, ImageMagick, gssproxy, mesa-libGLU, libblockdev-btrfs, libatomic_ops, opencv-core, libmpcdec, gtk-update-icon-cache, python3-iscsi-initiator-utils, libvirt-daemon-driver-interface, NetworkManager, libkate, liblangtag, NetworkManager-glib, NetworkManager-l2tp-gnome, libdatrie, glade-libs, setuptool, libcryptui, guile, mono-devel, gl2ps, pcre-utf16, tree, isdn4k-utils, gvfs-goa, hwloc-libs, gnupg, cronie-anacron, xfsprogs, libcroco, NetworkManager-iodine, plymouth-plugin-label, colord-libs, aalib-libs, gstreamer1-libav, libcddb, totem-pl-parser, gpgmepp, libgcab1, libzhuyin, gvnc, hypervfcopyd, cronie, openblas-threads64, libexttextcat, nano, libreport, gsl, nettle, iodine-client, libcacard, libverto-libev, colord, libpipeline, pkcs11-helper, accountsservice- libs, gnome-system-monitor, findutils, cmark-lib, qt5-qtx11extras, libsss_idmap, libraw1394, lm_sensors, gcc-c++, python3-dbus, iproute- tc, isomd5sum, ghc-vector, libupnp, spice-glib, ghc-pandoc, coolkey, python2-numpy, luajit, libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, rhash, xdg-user-dirs-gtk, ghc-base, libwayland-client, libsmbios, libipt, mdadm, libchamplain, xawtv, xl2tpd, device-mapper, python2-librepo, libXtst, ghc-lifted-base, wine-openal, irqbalance, gnome-terminal, GeoIP, GraphicsMagick, libsigc++20, python2-talloc, libXrandr, newt, samba-winbind-modules, liba52, hplip, wine-twain, ghc-QuickCheck, ghc-zip-archive, crda, libical, sheepdog, qt5-qtdeclarative, vo-amrwbenc, libXfont2, libblockdev-loop, libmfx, libssh2, NetworkManager-adsl, open-vm-tools- desktop, samba-dc-libs, libXcursor, ghc-network-uri, iio-sensor-proxy, dracut, webkitgtk4-plugin-process-gtk2, procps-ng, plymouth-core-libs, telnet, simple-scan, libXpm, xorg-x11-drv-nouveau, texlive-gsftopk- bin, bluez-obexd, zlib, libpeas, pam_krb5, gutenprint-cups, grub2 -tools-efi, avahi, libselinux, ncurses-compat-libs, libassuan, expat, cups-filters, iw, clutter-gtk, userspace-rcu, libgudev, live555, ibus- libpinyin, setroubleshoot-server, make, python3-markupsafe, texlive- bibtex-bin, libnice, libsoup, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol, efivar, gzip, python3-cangjie, keyutils, libipa_hbac, libfdisk, ghc-blaze-html, libdmx, openssl-libs, corosynclib, opencc, libreport-plugin- reportuploader, opencv, libatasmart, ipset, libselinux-python3, keybinder3, deltarpm, fuse-libs, xorg-x11-xauth, libglvnd-glx, gvfs- smb, gtkspell3, libcue, libXrender, json-glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware, sssd-common, NetworkManager- openconnect, libgtop2, btrfs-progs, gcc-gfortran, bind99-libs, imsettings-cinnamon, python3-pycurl, protobuf-c, ghc-unordered- containers, mesa-libglapi, glx-utils, evolution-data-server, PackageKit, perl-MIME-Base64, libass, nemo-extension-xreader, tint2, ghc-time, wpa_supplicant, texlive-lib, ppp, cinnamon-session, setools- python3, libtiger, git, PyPAM, jack-audio-connection-kit, mpg123-libs, opus, ctags, git-core, libxklavier, traceroute, cyrus-sasl-plain, libblockdev-crypto, pcsc-lite-ccid, rp-pppoe, libtheora, attr, mtr, gtksourceview3, plymouth, libcanberra-gtk3, gstreamer1-plugins-bad- free-gtk, mtdev, mailx, systemd-udev, fftw-libs-single, brasero, ghc- stm, libXvMC, wmctrl, python2-pillow, ghc-unix-compat, libXmu, wine- ldap, smartmontools, jasper-libs, librbd1, device-mapper-libs, xorg-x11-xinit, libogg, pyliblzma, libffi, libGLEW, pcre-utf32, python2-hawkey, diffutils, chrony, time, mpfr, ghc-array, tinyxml, cyrus-sasl-md5, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt- daemon-driver-nwfilter, tigervnc-server-minimal, gpgme, ninja-build, hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, gdb- headless, ghc-ghc-boot-th, qemu-block-nfs, libgovirt, libqmi-utils, libmbim-utils, psacct, lame-libs, pycryptopp, gnome-bluetooth-libs, usbredir, wvdial, libtirpc, iptables-libs, fftw, cryptsetup-libs, syslinux-extlinux, python2-gpg, bind-libs, pygobject2, mesa- libwayland-egl, ghostscript-x11, lua-posix, libinput, libreport-cli, libpkgconf, mono-core, python3-dmidecode, abrt-gui-libs, gegl, libosinfo, im-chooser, qt5-qtsvg, libreoffice-calc, xerces-c, libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, gdk-pixbuf2-devel, wine-cms, hdf5, rdma-core, vte291, cinnamon, libgweather, sssd-krb5, wine-opencl, ghc-pcre-light, qemu- block-iscsi, libspatialite, libgrss, libdvbpsi, libsmbclient, ghc-xml, python2-reportlab, transmission-gtk, cinnamon-settings-daemon, libvdpau, compat-openssl10, texlive-metafont-bin, opencore-amr, recordmydesktop, dbus-python, abrt-addon-kerneloops, libgta, network- manager-applet, openCOLLADA, xcb-util-renderutil, sssd-ad, lightdm, nemo, freetype, logrotate, vorbis-tools, cmake-gui, libkadm5, libdnet, ntfsprogs, abrt-libs, protobuf, efibootmgr, libgusb, samba-common- libs, libreswan, libpsl, zeitgeist-libs, python3-rpm, fwupdate-libs, jimtcl, libuser, NetworkManager-libreswan, lz4-libs, graphviz, abrt- retrace-client, opensc, boost-date-time, satyr, caribou-gtk3-module, pixman, gtk2-immodule-xim, rubygem-psych, xorg-x11-drv-vesa, libbluray, cifs-utils, libstdc++, libbabeltrace, libfastjson, numlockx, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-libinput, mesa- libOSMesa, libsss_certmap, libblockdev-mpath, ed, ghc-process, libgcc, gdisk, ilmbase, poppler, pocl, libstemmer, djvulibre-libs, ibus- libzhuyin, fftw-libs-double, texlive-xetex-bin, libconfig, ModemManager, abrt-gui, ibus-m17n, qemu-img, qt5-qtbase-gui, ghc- pretty, ghc-digest, ghc-data-default-instances-dlist, polkit, libuuid, faad2-libs, libarchive, libfreehand, ibus-gtk3, ibus-gtk2, ghc- deepseq, cryptsetup, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, vconfig, mtools, pygtk2, vim-minimal, harfbuzz-icu, libplist, checkpolicy, xdg-user-dirs, libdap, glusterfs- libs, spice-server, gdk-pixbuf2, gupnp, authconfig, libevent, redland, python2-cccolutils, tcpdump, ibus-hangul, opencv-contrib, ghc- utf8-string, libblockdev, librdmacm, lua-socket, dconf, xz-libs, dbus- glib, libdvdnav, xviewer, libcap, libprojectM, libvirt-daemon-driver- storage-zfs, libwbclient, compiler-rt, libvirt-daemon-driver-storage- gluster, numad, GraphicsMagick-c++, libthai, perl-NKF, fakeroot, qt5 -qttools-libs-designer, nss-tools, adcli, gdal-libs, iproute, ghc- aeson, libsmartcols, fakeroot-libs, leptonica, muffin, os-prober, ethtool, texlive-mfware-bin, ghc-directory, libfprint, systemd-libs, cpio, libfdt, util-linux, libburn, imsettings, krb5-libs, gnome- online-accounts, net-tools, enca, libblockdev-part, libpciaccess, clucene-core, libsss_autofs, nemo-fileroller, kmod, libxml++, NetworkManager-pptp, libetonyek, libcanberra-gtk2, sssd-client, libgxps, systemd, libpagemaker, libreport-plugin-bugzilla, libxkbcommon, device-mapper-multipath-libs, yajl, lockdev, ghc- resourcet, cups-filters-libs, geocode-glib, lpsolve, xorg-x11-server- utils, R-core, gnupg2, ghc-parsec, cracklib, evince-libs, libdnf, doxygen, ruby, gnuplot-common, abrt-addon-pstoreoops, gnome-keyring, pulseaudio-libs-glib2, libnice-gstreamer1, netpbm, nm-connection- editor, python-xpyb, python3-pyparted, libudisks2, gstreamer1-plugins- bad-free, NetworkManager-libreswan-gnome, clutter, zenity, chkconfig, java-1.8.0-openjdk-devel, libgnome-keyring, hostname, iscsi-initiator- utils, librados2, libvirt-daemon-driver-storage-mpath, pam, python2-cffi, unixODBC, openldap, zziplib, libXft, gnuplot, ipcalc, SDL, fdupes, speex, libvirt-daemon-driver-storage-logical, ibus- wayland, neon, rest, libsamplerate, python2-lxml, NetworkManager-vpnc- gnome, boost-iostreams, poppler-utils, libwpg, lapack, zfs-fuse, ghc- JuicyPixels, libusbmuxd, perl-Unicode-Normalize, sssd-kcm, libimobiledevice, lzop, NetworkManager-wwan, polkit-pkla-compat, libmtp, cyrus-sasl-lib, librevenge, hexchat, nspr, gjs, python3 -gobject-base, gnupg2-smime, dnsmasq, libXfixes, libblkid, libcdio, NetworkManager-l2tp, rsync, samba-winbind, xapps, rpm, webkitgtk4-jsc, lua-libs, abrt-addon-coredump-helper, soundtouch, xorg-x11-drv-evdev, libpeas-gtk, libXinerama, lirc-libs, ghc-blaze-markup, libteam, vim- enhanced, libcmis, snes9x-gtk, libesmtp, acl, cyrus-sasl-scram, libvirt-daemon-driver-storage-sheepdog, redshift, libphodav, vid.stab, ghc-temporary, libgee, libXxf86vm, mesa-libEGL, clang-libs, redhat- lsb-core, systemd-pam, glpk, ftgl, ghc-transformers-compat, perl- Digest-MD5, gvfs-gphoto2, wlroots, perl-Sort-Key, libvirt-daemon- driver-storage-rbd, nss-util, libsemanage, marisa, arpack, ghc- primitive, mozjs52, systemd-container, libcomps, xplayer, ghc-texmath, at, gtk3-immodule-xim, ghc-data-default-instances-old-locale, libdca, libblockdev-fs, java-1.8.0-openjdk-headless, libnma, gettext, soxr, libutempter, libmetalink, ghc-blaze-builder, slang, qt5-qtwayland, caribou, cryptopp, usbutils, e2fsprogs, libcdio-paranoia, grub2-tools- minimal, cpp, libksba, openblas-serial64_, libwayland-server, virglrenderer, jblas, gdbm, libpurple, osinfo-db-tools, libsndfile, libvisio, tk, ruby-libs, bzip2-libs, NetworkManager-iodine-gnome, texlive-pdftex-bin, teckit, gnutls, jack-audio-connection-kit-example- clients, SuperLU, ghc-transformers-base, device-mapper-persistent- data, ghc-exceptions, ykpers, libselinux-utils, perl-Scalar-List- Utils, dosfstools, openbox, rng-tools, gnome-abrt, libspectre, icedax, keyutils-libs, libproxy, libreoffice-math, libtimezonemap, audit-libs- python3, perl-Data-Dumper, glusterfs-fuse, game-music-emu, vala, plymouth-graphics-libs, pidgin, anaconda-core, python2-sqlalchemy, tesseract, cinnamon-menus, libnfsidmap, perl-XML-Parser, mlocate, tmux, file-libs, grub2-tools, avahi-glib, mokutil, libva, libblockdev- swap, libnetfilter_conntrack, python3-gobject, libev, bash, fprintd- pam, blas, libusbx, polkit-gnome, NetworkManager-openvpn-gnome, qrencode-libs, libICE, drpm, createrepo_c-libs, purple-hangouts, speexdsp, upower, openssh, p7zip, libreoffice-x11, xcb-util-wm, gtk2-devel, atk, dbxtool, gnome-vfs2, alsa-lib, x264-libs, python2-gobject, gtkmm24, xplayer-plparser, PyYAML, libvirt-daemon- driver-storage-disk, brasero-libs, libucil, mesa-dri-drivers, sgpio, python3-abrt, libffado, ghc-highlighting-kate, suitesparse, libopenraw, fribidi, libgnomekbd, libblockdev-kbd, ibus-rawcode, pciutils, libini_config, openssh-clients, libX11, celt051, beignet, kyotocabinet-libs, python3-pwquality, gvfs-mtp, python3-cryptography, gnome-bluetooth, ghc-template-haskell, libnl3, gimp-libs, libnatpmp, libidn, ghc-monad-control, source-highlight, grubby, python3-libreport, epiphany-runtime, libbytesize, libmpeg2, qemu- block-rbd, python3-systemd, libnl3-cli, ibus-libs, python2-libcomps, audit-libs, bluez, wine-alsa, gettext-libs, liborcus, dcraw, libref_array, fwupd, raptor2, rubygem-io-console, libcrypt-nss, plymouth-plugin-two-step, sbc, ghc-random, libhangul, ocl-icd, poppler-glib, potrace, libblockdev-lvm, ibus-kkc, lvm2, harfbuzz, cups, dmraid, pandoc, ghc-syb, python3-wrapt, gvfs-client, NetworkManager-libnm, python2-libs, gnome-boxes, python2-scipy, lrzsz, libglvnd-egl, libunwind, unbound-libs, dhcp-libs, libtalloc, libtar, hypervkvpd, libepoxy, libreoffice-impress, man-db, libvirt-daemon- driver-storage-core, epstool, mesa-libgbm, liblogging-stdlog, timedatex, fltk, xdg-desktop-portal, sssd-nfs-idmap, rasqal, wireless- tools, libdb, passwd, cups-pk-helper, gnome-calculator, kmod-libs, NetworkManager-team, libdv, gutenprint-libs, lm_sensors-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, texlive-tex-bin, ghc-time-locale-compat, libusal, gcc-gdb-plugin, gtkmm30, libgit2, gobject-introspection, libpwquality, fontconfig, libblockdev-dm, ghc-mtl, meanwhile, protobuf-compiler, evince-djvu, grep, libdaemon, flatpak, python3-librepo, pkgconf, json-c, sed, sssd- ipa, perl-threads-shared, glib-networking, samba-libs, kpartx, libpng, ghostscript-core, sane-backends-libs, python3-pillow, ghc-old-locale, ghc-HTTP, cyrus-sasl, hardlink, libcollection, pakchois, libgcrypt, cairomm, perl-Unicode-UTF8, nss-softokn, lasi, python3-numpy, lsof, at-spi2-atk, perl-Variable-Magic, twolame-libs, gucharmap, NLopt, xorg-x11-server-Xorg, python3-libcomps, gfs2-utils, perl-IO, libverto, glibmm24, libXScrnSaver, realmd, libmspub, ncurses, libkml, nfs-utils, graphite2, python3-kerberos, passwdqc-lib, imlib2, libreport-plugin- kerneloops, libde265, metacity, gmp, sssd-krb5-common, uriparser, volume_key-libs, b43-fwcutter, farstream02, ffmpeg-libs, ghc-data- default-class, alsa-plugins-pulseaudio, perl-interpreter, powerline, bluez-cups, gimp, libcurl, libsemanage-python3, coreutils, python- krbV, libcap-ng, gvfs, libgadu, swig, util-linux-user, pinentry, libvirt-daemon-driver-storage-scsi, librepo, lua-filesystem, qemu- common, gsm, libuv, boost-filesystem, libtevent, samba-winbind- clients, ghc-base-compat, purple-facebook, openblas-threads, libglvnd, texlive-kpathsea-bin, gobject-introspection-devel, boost-system, libpcap, openblas-threads64_, im-chooser-common, snappy, clutter-gst3, libxdo, libdrm, genisoimage, rubygem-bigdecimal, pcre2, xmlrpc-c, jsoncpp, perl-TermReadKey, cogl, libpng-devel, python3-PyYAML, libqhull, wine-capi, libmspack, libssh, inkscape, GConf2, glibc, proj, python2-orderedset, ttmkfdir, flatpak-libs, fipscheck, libRmath, mactel-boot, bc, ghc-bytestring, gtk-vnc2, quota, wget, boost-regex, ghc-filepath, libreport-web, libgomp, libexif, libvirt-daemon-driver- secret, gstreamer1-plugins-bad-freeworld, gdk-pixbuf2-xlib, glib2, qemu-system-x86-core, ImageMagick-libs, libwmf, pcre2-utf16, libmnl, gettext-devel, libzmf, libmng, nss, pcre, libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1-plugins-base, spax, cdrdao, pciutils-libs, ghc-attoparsec, libiptcdata, libmpc, libXi, file-roller, openjpeg2, libmatroska, flac-libs, libXt, libXv, rubygem- openssl, rpm-libs, info, libnfnetlink, libmwaw, libiec61883, device- mapper-event, highlight, fftw-libs-quad, qt5-qtbase, ghc-scientific, w3m-img, qpdf, libpskc, linux-atm, weston-libs, ibus, gamin, jwhois, qemu-block-dmg, libsss_sudo, curl, yelp-libs, cmake, ghc-doctemplates, libsass, ccache-swig, fipscheck-lib, python2-pycurl, dos2unix, python3-setproctitle, paps, abrt-tui, lzo-minilzo, harfbuzz-devel, gtk3-devel, abrt-addon-xorg, libdhash, gucharmap-libs, gnome-keyring- pam, sssd-proxy, imsettings-libs, gd, gc, python3-cups, libxshmfence, ncurses-c++-libs, ghc-text, libreport-plugin-systemd-journal, gstreamer1-plugins-ugly-free, atlas, unzip, vlc, gtk2, gtk3, ghc- conduit, libv4l, atkmm, npth, perl-Params-Util, libyaml, tre, xcb- util-image, m17n-lib, mozjs17, texlive-xdvi-bin, libblockdev-mdraid, glusterfs, exiv2-libs, libebml, libunistring, postgresql-libs, reiserfs-utils, gstreamer1-plugins-good, python2-rpm, libasyncns, octave, qemu-block-curl, device-mapper-multipath, c-ares, xmlsec1-openssl, pulseaudio-module-x11, python2-cairo, NetworkManager- pptp-gnome, jansson, bind-utils, ghc-yaml, librsvg2, libsss_nss_idmap, trousers-lib, zip, webrtc-audio-processing, bcache-tools, openblas- Rblas, startup-notification, ghc-data-default-instances-containers, libgeotiff, libpinyin, rfkill, python3-psutil, babl, libstaroffice, pinfo, armadillo, bubblewrap, elfutils-libs, libtasn1, jbigkit-libs, perl-libintl-perl, libe-book, freerdp1.2, alsa-utils, sqlite, tar, sudo, dhcp-client, fprintd, pinentry-gtk, gcc, dwz, compat-lua-libs, xorg-x11-drv-qxl, gcr, ebtables, avahi-libs, xorg-x11-drv-fbdev, popt, pigz, libquvi, gvfs-archive, libqb, libao, ghc-hslua, lz4, kbd, libreoffice-core, wayland-devel, gupnp-igd, libwayland-cursor, openvpn, libpaper, gstreamer1-plugins-ugly, xvidcore, libwacom, lzo, pango, libss, aspell, esmtp, dbus, polkit-libs, perl-threads, perl- Params-Validate, pangomm, mesa-libxatracker, nss-sysinit, openni, nss- mdns, geos, python3-cffi, xviewer-plugins, fftw-libs-long, at- spi2-core, libvirt-daemon-driver-network, glibc-common, liblockfile, rubygem-narray, openblas-openmp64, gnome-autoar, python3-libxml2, libnfs, libgfortran, wine-core, libiscsi, groff-base, texlive- makeindex-bin, ghc-dlist, libusb, mesa-libGL, abrt-addon-ccpp, libldb, python2-gobject-base, NetworkManager-vpnc, libmodplug, libvirt-daemon- driver-nodedev, python3-pygit2, libcanberra, pcsc-lite, PackageKit- gstreamer-plugin, wavpack, xorg-x11-drv-wacom, libsrtp, perl-Package- Stash-XS, samba-client-libs, openssh-server, which, x265-libs, samba- client, libaio, lua-expat, libquadmath, texlive-luatex-bin, libshout, brlapi, createrepo_c, python2-markupsafe, libreport-gtk, liboauth, xmlsec1, isns-utils-libs, ghc-extensible-exceptions, libwsman1, krb5-workstation, perl-libs, mcpp, nmap-ncat, libglvnd-opengl, vlc- core, xapian-core-libs, lksctp-tools, libgltf, usb_modeswitch, tbb, mythes, evolution, NetworkManager-wifi, mjpegtools-libs, kexec-tools, nemo-preview, qd, teamd, libvorbis, lightdm-gobject, ghc-enclosed- exceptions, NetworkManager-openconnect-gnome, rpcbind, pcre-cpp, libodfgen, exiv2, iptables, openblas-openmp, libestr, lua, libpeas- loader-python3, llvm-libs, ogdi, pulseaudio-module-bluetooth, libvirt- libs, valgrind, ghc-cmark, portaudio, passwdqc, ghc-tagged, schroedinger, libattr, ghc-data-default, hyphen, zvbi, webkitgtk4, gnome-software, syslinux, libaec, gts, sssd-ldap, iptstate, glib2-devel, libreport-plugin-ureport, radvd, python3-lxml, python3-libs, glusterfs-cli, perl-PathTools, weston, ipset-libs, bluez-tools, mozjs38, gnome-menus, glusterfs-client-xlators, libreoffice-pyuno, file, libxml2, gmime, libreoffice-ure, iscsi- initiator-utils-iscsiuio, slick-greeter, cyrus-sasl-gssapi, mpage, libnm-gtk, libvirt-daemon, nemo-extensions, protobuf-lite, libsecret, gtk2-engines, cjs, openblas, openblas-serial64, p11-kit-trust, NetworkManager-bluetooth, texlive-dvips-bin, augeas-libs, libsysfs, geoclue2, audit, abrt-dbus, gnome-desktop3, gdk-pixbuf2-modules, binutils, mariadb-common, xen-libs, libisofs, xed, nss-pem, vim- common, python2-kerberos, less, brltty, libvpx, tcl, rpm-build-libs, libnghttp2, ostree-libs, libsolv, exempi, libxkbcommon-x11, libmms, libtdb, python3-gpg, libXdmcp, ghc-haddock-library, perl-Socket, libatomic, libvisual, python3, python2, minicom, unrar, shared-mime- info, SDL2, xreader, libsigsegv, libunicap, caribou-gtk2-module, ghc- network, dvd+rw-tools, shadow-utils, libcgroup, libXaw, libXau, netcf- libs, libgdata, libspiro, dmidecode, libmbim, libjpeg-turbo, spice- gtk3, wine-pulseaudio, libmount, ghc-tagsoup, spice-vdagent, nemo- image-converter, ghc-base64-bytestring, mariadb-libs, libavc1394, lldpad, libtiff, libvncserver, samba-common-tools, libnotify, ima-evm- utils, w3m, tracker, cairo, ghc-tf-random, bind-libs-lite, mesa- libOpenCL, grub2-tools-extra, transmission-common, ghc-pandoc-types, fluidsynth-libs, qscintilla-qt5, taglib, libXext, libblockdev-utils, ModemManager-glib, cinnamon-control-center, bridge-utils, ostree, device-mapper-event-libs, initscripts, hunspell, libieee1284, libndp, pulseaudio, pix, bzip2, elfutils-libelf, nss-softokn-freebl, open-vm- tools, libtool-ltdl, readline, perl-Storable, yelp, xorg-x11-drv- intel, abrt-java-connector, perl-version), /usr/lib/.build-id/a2 (gupnp-igd, ImageMagick-libs, graphviz, opencv-core, cups, libreoffice-core, systemd, ghc-doctemplates, wine-core, glibc, gegl, shadow-utils, gstreamer1-plugins-base, bind99-libs, abrt-addon- coredump-helper, vlc, qt5-qtsvg, ebtables, python2-scipy, unixODBC, tracker-miners, readline, tbb, ldns, audit, evolution-data-server, pulseaudio, gdk-pixbuf2-modules, lockdev, libnl3-cli), /usr/lib /.build-id/c6(poppler-utils, opencv-contrib, perl-XML-Parser, numactl- libs, gnome-system-monitor, libxcb, nss, rpm, gimp, xorg-x11-server- Xorg, systemd, wine-core, w3m, coreutils, atlas, python2-libs, git- core, open-vm-tools, sane-backends-drivers-scanners, libdrm, imlib2, libGLEW, evolution, ruby-libs, nettle, gdk-pixbuf2-modules, python3-scipy, pulseaudio-libs), /usr/lib/.build-id/e1(iptables, parted, linux-atm, weston-libs, pix, opencv-core, gimp, systemd, GConf2, icedax, glibc, wine-core, bcache-tools, hwloc-libs, libusbx, ImageMagick-libs, systemd-libs, sane-backends-drivers-scanners, GraphicsMagick, octave, tbb, abrt-addon-ccpp, xorg-x11-xkb-utils, pulseaudio, java-1.8.0-openjdk-devel, clang-libs) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in glslang- devel , glslang-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used.
---> The scriptlets must be applied by the -devel package.
[-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: glslang-devel-3.1-0.1.20170612.git91c46c6.fc28.x86_64.rpm glslang-debugsource-3.1-0.1.20170612.git91c46c6.fc28.x86_64.rpm glslang-3.1-0.1.20170612.git91c46c6.fc28.src.rpm glslang-devel.x86_64: W: no-dependency-on glslang/glslang-libs/libglslang glslang-devel.x86_64: E: invalid-soname /usr/lib64/libglslang-default-resource-limits.so libglslang-default-resource-limits.so glslang-devel.x86_64: W: no-manual-page-for-binary glslangValidator glslang-devel.x86_64: W: no-manual-page-for-binary spirv-remap glslang-debugsource.x86_64: W: no-documentation glslang.src: W: spelling-error Summary(en_US) shader -> shared, shade, shadier glslang.src: W: spelling-error Summary(en_US) validator -> lavatorial 3 packages and 0 specfiles checked; 1 errors, 6 warnings.
Rpmlint (debuginfo) ------------------- Checking: glslang-devel-debuginfo-3.1-0.1.20170612.git91c46c6.fc28.x86_64.rpm glslang-devel-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory glslang-devel-debuginfo.x86_64: W: invalid-url URL: https://github.com/KhronosGroup <urlopen error [Errno -2] Name or service not known> glslang-devel-debuginfo.x86_64: E: useless-provides debuginfo(build-id) glslang-devel.x86_64: W: no-dependency-on glslang/glslang-libs/libglslang glslang-devel.x86_64: W: invalid-url URL: https://github.com/KhronosGroup <urlopen error [Errno -2] Name or service not known> glslang-devel.x86_64: E: invalid-soname /usr/lib64/libglslang-default-resource-limits.so libglslang-default-resource-limits.so glslang-devel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libglslang-default-resource-limits.so /lib64/libm.so.6 glslang-devel.x86_64: W: no-manual-page-for-binary glslangValidator glslang-devel.x86_64: W: no-manual-page-for-binary spirv-remap glslang-debugsource.x86_64: W: invalid-url URL: https://github.com/KhronosGroup <urlopen error [Errno -2] Name or service not known> glslang-debugsource.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 8 warnings.
Requires -------- glslang-devel (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglslang-default-resource-limits.so()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH)
glslang-debugsource (rpmlib, GLIBC filtered):
Provides -------- glslang-devel: glslang-devel glslang-devel(x86-64) libglslang-default-resource-limits.so()(64bit)
glslang-debugsource: glslang-debugsource glslang-debugsource(x86-64)
Source checksums ---------------- https://github.com/KhronosGroup/glslang/archive/91c46c656720a6e1e71a3411cd1f... : CHECKSUM(SHA512) this package : d71c3f55aacd5362612f2ea4c4d2a2f54150d725ad287ab8ff675b7653c2b0bcabd54a54d16a6cc989e7dc7b4e044ce64b2ba8b62aff2170e224eeb02b59b4a4 CHECKSUM(SHA512) upstream package : d71c3f55aacd5362612f2ea4c4d2a2f54150d725ad287ab8ff675b7653c2b0bcabd54a54d16a6cc989e7dc7b4e044ce64b2ba8b62aff2170e224eeb02b59b4a4
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -k sha512 -m fedora-rawhide-x86_64 -b 1470635 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
===== Solution =====
Package APPROVED!!!
Please fix the outlined issues during import.
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/glslang
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m, | |quantum.analyst@gmail.com Flags| |needinfo?(leigh123linux@goo | |glemail.com)
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This appears to have been built?
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Version|rawhide |27 Fixed In Version| |glslang-3.1-0.3.20171028.gi | |t715c353.fc2 Resolution|--- |CURRENTRELEASE Last Closed| |2018-08-29 03:39:12
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Please re-open if necessary, but I'm pretty sure this has been built.
https://bugzilla.redhat.com/show_bug.cgi?id=1470635
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(leigh123linux@goo | |glemail.com) |
--- Comment #6 from leigh scott leigh123linux@googlemail.com --- .................
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com