[Bug 672709] New: Review Request: perl-Sys-Mmap - Use mmap to map in a file as a Perl variable
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Sys-Mmap - Use mmap to map in a file as a Perl variable
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Summary: Review Request: perl-Sys-Mmap - Use mmap to map in a file as a Perl variable Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tibbs@math.uh.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.math.uh.edu/~tibbs/rpms/perl-Sys-Mmap/perl-Sys-Mmap.spec SRPM URL: http://www.math.uh.edu/~tibbs/rpms/perl-Sys-Mmap/perl-Sys-Mmap-0.14-1.fc15.s... Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2742473 Description: The Mmap module lets you use mmap to map in a file as a perl variable rather than reading the file into dynamically allocated memory. Multiple programs may map the same file into memory, and immediately see changes by each other. Memory may be allocated not attached to a file, and shared with subprocesses.
rpmlint produces no output for me besides a spelling complaint about "subprocesses", and the included tests pass:
t/mmap.t ........... ok t/munmap_errors.t .. ok All tests successful. Files=2, Tests=18, 0 wallclock secs ( 0.03 usr 0.03 sys + 0.06 cusr 0.04 csys = 0.16 CPU) Result: PASS
Note that this is needed as a new dependency for zoneminder, and I intend to branch this only for rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |672707
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nb@fedoraproject.org AssignedTo|nobody@fedoraproject.org |nb@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #1 from Nick Bebout nb@fedoraproject.org 2011-01-25 18:37:07 EST --- [nb@localhost SOURCES]$ md5sum Sys-Mmap-0.14.tar.gz f3a1115b7632ca015532e8ca7134918b Sys-Mmap-0.14.tar.gz [nb@localhost SOURCES]$ md5sum Sys-Mmap-0.14.tar.gz.1 f3a1115b7632ca015532e8ca7134918b Sys-Mmap-0.14.tar.gz.1
[OK] MUST: rpmlint must be run on every package [OK] MUST: The package must be named according to the Package Naming Guidelines [OK] MUST: The spec file name must match the base package %{name} [...] [OK] MUST: The package must meet the Packaging Guidelines [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [OK] MUST: The License field in the package spec file must match the actual license [OK] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc [OK] MUST: The spec file must be written in American English. [OK] MUST: The spec file for the package MUST be legible. [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture [OK] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line [OK] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [OK] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden [OK] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [OK] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [OK] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [OK] MUST: A package must not contain any duplicate files in the %files listing. [OK] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [OK] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [OK] MUST: Each package must consistently use macros. [OK] MUST: The package must contain code, or permissable content. [OK] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [OK] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [OK] MUST: Header files must be in a -devel package. [OK] MUST: Static libraries must be in a -static package. [OK] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [OK] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [OK] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [OK] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [OK] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [OK] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [OK] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [OK] MUST: All filenames in rpm packages must be valid UTF-8.
This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2011-01-25 18:45:00 EST --- Thanks a bunch!
New Package SCM Request ======================= Package Name: perl-Sys-Mmap Short Description: Use mmap to map in a file as a Perl variable Owners: tibbs Branches: InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2011-01-25 19:04:18 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672709
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-01-25 19:22:14
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2011-01-25 19:22:14 EST --- Imported and successfully built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2742528
Thanks again for the review.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla