[Bug 1666545] New: Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Bug ID: 1666545
           Summary: Review Request: python-qdarkstyle - A dark stylesheet
                    for Qt applications
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: http://jonny.fedorapeople.org//python-qdarkstyle.spec
SRPM URL: http://jonny.fedorapeople.org//python-qdarkstyle-2.6.5-1.fc29.src.rpm

Description:
A dark stylesheet for Qt applications.

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

--- Comment #1 from Jonny Heggheim  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=32052203

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1666513

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666513
[Bug 1666513] nothing provides python3.6dist(qdarkstyle) < 3.0 needed by
electrum-3.2.4-1.fc28.noarch

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Hirotaka Wakabayashi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Hirotaka Wakabayashi  ---
Hello, this is an unofficial review. Please read it for your reference.

Summary:
1. Rpmlint 4 errors, 3 warnings.
2. No files under the CC-BY License are included.
3. No Test suites exist.
4. No python3-setuptools in BuildRequires.

Details:
1. Rpmlint
'/usr/bin/env python' MUST NOT be used in shebang lines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_...

python3-qdarkstyle SHOULD contain the manpage of /usr/bin/qdarkstyle.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

Here is the output of rpmlint on the binary rpm package in my fedora29
environment:
```
python3-qdarkstyle.noarch: W: spelling-error Summary(en_US) stylesheet -> style
sheet, style-sheet, stylishness
The value of this tag appears to be misspelled. Please double-check.

python3-qdarkstyle.noarch: W: spelling-error %description -l en_US stylesheet
-> style sheet, style-sheet, stylishness
The value of this tag appears to be misspelled. Please double-check.

python3-qdarkstyle.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/qdarkstyle/__init__.py /usr/bin/env python
This script uses an interpreter which is either an inappropriate one or
located in an inappropriate directory for packaged system software.

python3-qdarkstyle.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/qdarkstyle/__init__.py 644 /usr/bin/env python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-qdarkstyle.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/qdarkstyle/__main__.py /usr/bin/env python
This script uses an interpreter which is either an inappropriate one or
located in an inappropriate directory for packaged system software.

python3-qdarkstyle.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/qdarkstyle/__main__.py 644 /usr/bin/env python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-qdarkstyle.noarch: W: no-manual-page-for-binary qdarkstyle
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 4 errors, 3 warnings.
```

2. No file under the CC-BY License.
I think images are distributed under the CC-BY license, but no images are
included. Does this package need to include them? If not, License: field
value should be 'MIT' only because The License: field refers to the licenses
of the contents of the binary rpm.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...

3. No Test suites.
If upstream provides a test suite and it is practical, you should add it
to the %check section.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites

4. No python3-setuptools in BuildRequires.
upstream uses setuptools to build this package. setuptools is a very common
package, but it is important that your package list all necessary build
dependencies using the BuildRequires: tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#buildrequires

Thanks in advance,
Hirotaka Wakabayashi

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #3 from Robert-André Mauchin  ---
I'll approve this package once Hirotaka Wakabayashi's comments are addressed.

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

--- Comment #5 from Jonny Heggheim  ---
Sorry, this package was forgotten since it was optional by Electrum and
Electron Cash. Would like to include it.

needinfo canceled: [Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Robert-André
Mauchin 🐧 's needinfo:
Bug 1666545: Review Request: python-qdarkstyle - A dark stylesheet for Qt
applications
https://bugzilla.redhat.com/show_bug.cgi?id=1666545

--- Comment #6 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

--- Comment #7 from Robert-André Mauchin 🐧  ---
(In reply to Jonny Heggheim from comment #5)
> Sorry, this package was forgotten since it was optional by Electrum and
> Electron Cash. Would like to include it.

Could you repost a SPEC with Hirotaka Wakabayashi's comment adressed?

[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |DUPLICATE
        Last Closed|                            |2021-07-09 11:28:30

--- Comment #8 from Jonny Heggheim  ---

*** This bug has been marked as a duplicate of bug 1785982 ***