[Bug 1656533] New: Review Request: perl-Types-DateTime - Type constraints and coercions for datetime objects <short summary here>
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Bug ID: 1656533 Summary: Review Request: perl-Types-DateTime - Type constraints and coercions for datetime objects <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: xavier@bachelot.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Types-DateTime.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Types-DateTime-0.002-1.fc29.src.r...
Description: Types::DateTime is a type constraint library suitable for use with Moo/Moose attributes, Kavorka sub signatures, and so forth.
Fedora Account System Username: xavierb
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1656536
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1656536 [Bug 1656536] Review Request: perl-Web-ID - Implementation of WebID
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-Types-DateTime - Type |perl-Types-DateTime - Type |constraints and coercions |constraints and coercions |for datetime objects <short |for datetime objects |summary here> |
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok
FIX: License should be '(GPL+ or Artistic) and Public Domain', because files COPYRIGHT and CREDITS have license Public Domain, See Types-DateTime-0.002/COPYRIGHT line 13-17.
Description is ok Source0 is ok
FIX: Please update URL to use link to metacpan.org https://metacpan.org/release/Types-DateTime/
All tests passed
BuildRequires FIX: Please add following missing build-requires: - coreutils - spec file: line 34 - findutils - spec file: line 34 - make - spec file: line 32 - perl-generators - perl-interpreter - spec file: line 28 - perl(Moose) >= 2.06 - t/02mxtdt.t:31 - perl(Moose::Util::TypeConstraints) - t/02mxtdt.t:26 - perl(strict) - Makefile.PL:1, lib/Types/DateTime.pm:2 - perl(Type::Library) - lib/Types/DateTime.pm:17 - perl(Type::Utils) - lib/Types/DateTime.pm:22 - perl(Type::Standard) - lib/Types/DateTime.pm:21 - perl(warnings) - lib/Types/DateTime.pm:3 - optional - perl(Locale::Maketext) - t/02mxtdt.t:128
$ rpm -qp --requires perl-Types-DateTime-0.002-1.fc30.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 perl run-time dependencies are missing.
$ rpm -qp --provides perl-Types-DateTime-0.002-1.fc30.noarch.rpm | sort | uniq -c 1 perl-Types-DateTime = 0.002-1.fc30 Binary provides are not complete
FIX: Provides and run-time requires were not added due to missing build-requires perl-generators.
$ rpmlint ./perl-Types-DateTime* perl-Types-DateTime.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-Types-DateTime.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok
If you want to add the package to EPEL, please ignore these two TODO TODO: The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be used in all Fedoras. The command is %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras.
Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file.
Not approved
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
--- Comment #2 from Xavier Bachelot xavier@bachelot.org --- Wow, I don't know how I let so much errors get through... All FIX addressed. I want the spec to be compatible with EPEL, so I didn't address the TODOs.
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Types-DateTime.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Types-DateTime-0.002-2.fc29.src.r...
Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com ---
FIX: License should be '(GPL+ or Artistic) and Public Domain', because files COPYRIGHT and CREDITS have license Public Domain, See Types-DateTime-0.002/COPYRIGHT line 13-17. FIX: Please update URL to use link to metacpan.org https://metacpan.org/release/Types-DateTime/
-License: GPL+ or Artistic -URL: http://search.cpan.org/dist/Types-DateTime/ +License: (GPL+ or Artistic) and Public Domain +URL: https://metacpan.org/release/Types-DateTime/
Ok.
BuildRequires FIX: Please add following missing build-requires: - coreutils - spec file: line 34 - findutils - spec file: line 34 - make - spec file: line 32 - perl-generators - perl-interpreter - spec file: line 28 - perl(Moose) >= 2.06 - t/02mxtdt.t:31 - perl(Moose::Util::TypeConstraints) - t/02mxtdt.t:26 - perl(strict) - Makefile.PL:1, lib/Types/DateTime.pm:2 - perl(Type::Library) - lib/Types/DateTime.pm:17 - perl(Type::Utils) - lib/Types/DateTime.pm:22 - perl(Type::Standard) - lib/Types/DateTime.pm:21 - perl(warnings) - lib/Types/DateTime.pm:3 - optional - perl(Locale::Maketext) - t/02mxtdt.t:128
All BRs were added
$ rpm -qp --requires perl-Types-DateTime-0.002-2.fc30.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.8.0 1 perl(DateTime) 1 perl(DateTime::Duration) 1 perl(DateTime::Locale) 1 perl(DateTime::TimeZone) 1 perl(Module::Runtime) 1 perl(Type::Library) 1 perl(Type::Utils) 1 perl(Types::Standard) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are ok
$ rpm -qp --provides perl-Types-DateTime-0.002-2.fc30.noarch.rpm | sort | uniq -c 1 perl(Types::DateTime) = 0.002 1 perl-Types-DateTime = 0.002-2.fc30 Binary provides are ok
The package looks good now. Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Types-DateTime
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Types-DateTime-0.002-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-63e7274895
https://bugzilla.redhat.com/show_bug.cgi?id=1656533
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Types-DateTime-0.002-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-af0cfd43f0
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com