[Bug 469023] New: Review Request: perl-Class-Adapter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Class-Adapter

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Summary: Review Request: perl-Class-Adapter
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Description:
The Class::Adapter class is intended as an abstract base class for creating
any sort of class or object that follows the Adapter pattern.

http://mmaslano.fedorapeople.org/perl-Class-Adapter/perl-Class-Adapter-1.05-... 
http://mmaslano.fedorapeople.org/perl-Class-Adapter/perl-Class-Adapter.spec

[Bug 469023] Review Request: perl-Class-Adapter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Stepan Kasal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 469023] Review Request: perl-Class-Adapter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Stepan Kasal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |perl-Class-Adapter          |perl-Class-Adapter - Perl
                   |                            |implementation of the
                   |                            |"Adapter" Design Pattern

--- Comment #1 from Jason Tibbitts   2008-10-29 11:58:25 EDT ---
Please try to use the template when posting review requests.

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Matej Cepl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]           |[e-mail]
               Flag|                            |fedora-review+

--- Comment #2 from Matej Cepl   2008-11-03 07:02:04 EDT ---
+ GOOD: rpmlint is silent on both source and binary package.
+ GOOD: The package is named according to the Package Naming Guidelines .
+ GOOD: The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ GOOD: The package meets the Packaging Guidelines .
+ GOOD: The package is licensed with a Fedora approved license and meet the
Licensing Guidelines .
+ GOOD: The License field in the package spec file matches the actual license.
+ GOOD: LICENSE file is in %doc.
+ GOOD: The spec file is written in American English.
+ GOOD: The spec file for the package is legible.
+ GOOD: The sources used to build the package matches the upstream source,
as provided in the spec URL.
39b4b06a30b770ae5a7ee42dccdf143e  Class-Adapter-1.05.tar.gz
+ GOOD: The package successfully compiles and build into binary rpms on at
least one supported architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=915478
+ GOOD: noarch, so it compiles everywhere.
+ GOOD: All build dependencies are listed in BuildRequires.
+ GOOD: The spec file MUST handle locales properly.
  No locale support.
+ GOOD: no libraries
+ GOOD: not relocatable
+ GOOD: A package owns all directories that it creates.
  Follows perl guidelines.
+ GOOD: A package must not contain any duplicate files in the %files listing.
+ GOOD: Permissions on files must be set properly.
+ GOOD: Each package have a %clean section.
+ GOOD: Each package consistently use macros.
+ GOOD: The package contains code, or permissable content.
+ GOOD: No large documentation files, so no a -doc subpackage.
+ GOOD: Files registered in %doc does not affect the runtime of the
application.
+ GOOD: No header files.
+ GOOD: No static libraries.
+ GOOD: No pkgconfig(.pc) files.
+ GOOD: The package does not contain library files with a suffix.
+ GOOD: No devel packages.
+ GOOD: No .la libtool archives.
+ GOOD: Packages does not contain GUI applications.
+ GOOD: Packages does not own files or directories owned by other packages.
+ GOOD: Runs rm -rf $RPM_BUILD_ROOT in %install
+ GOOD: All filenames in rpm packages are valid UTF-8.
+ SHOULD: Includes license text.

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

--- Comment #3 from Matej Cepl   2008-11-03 07:02:44 EDT ---
Approved.

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Marcela Maslanova   2008-11-03 07:19:24 EDT ---
New Package CVS Request
=======================
Package Name: perl-Class-Adapter
Short Description: base for creating class follows the Adapter pattern
Owners: mmaslano
Branches: devel
InitialCC: [e-mail]

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #5 from Dennis Gilmore   2008-11-03 13:54:02 EDT ---
cvs done

[Bug 469023] Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469023

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE