[Bug 2161739] New: Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Bug ID: 2161739
           Summary: Review Request: rust-pyo3-log - Logging bridge from
                    pyo3 native extension to python
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://v02460.fedorapeople.org/rust-pyo3-log.spec
SRPM URL: https://v02460.fedorapeople.org/rust-pyo3-log-0.7.0-3.fc38.src.rpm
Description: Logging bridge from pyo3 native extension to python
Fedora Account System Username: v02460

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Kai A. Hiller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2077333
           Doc Type|---                         |If docs needed, set a value
         Depends On|                            |2061101

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2061101
[Bug 2061101] rust-pyo3-0.17.3 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2077333
[Bug 2077333] matrix-synapse-1.75.0rc2 is available

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5240870
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|2061101                     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2061101
[Bug 2061101] rust-pyo3-0.18.0 is available

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Fabio Valentini  ---
Two quick comments:
> echo 'python3-devel'

This should not be necessary - pyo3 (via pyo3-ffi) should already pull in
python3-devel.

There have also been new releases of the pyo3-log crate (v0.8.0 and v0.8.1),
but it looks like matrix-synapse depends on v0.7, so I would continue with the
review of v0.7.0 and only update to a later version once matrix-synapse
requires it?

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #3 from Kai A. Hiller  ---
That sounds good! And you are right – I removed the dependency on
python3-devel.

New version:
Spec URL: https://v02460.fedorapeople.org/rust-pyo3-log.spec
SRPM URL: https://v02460.fedorapeople.org/rust-pyo3-log-0.7.0-4.fc38.src.rpm

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|                            |fedora-review+
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Fabio Valentini  ---
Thanks, looks good to me now!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (we need 0.7.x right now)
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- enable tracking of the package in koschei for all relevant branches

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #5 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pyo3-log

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-ea818e4902 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-ea818e4902

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-02-21 15:55:51

--- Comment #7 from Fedora Update System  ---
FEDORA-2023-ea818e4902 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-2dedbef650 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-2dedbef650

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-08e065d25d has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-08e065d25d

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-08e065d25d has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-08e065d25d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-2dedbef650 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-2dedbef650 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-2dedbef650

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #12 from Fedora Update System  ---
FEDORA-2023-2dedbef650 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

John Wass  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from John Wass  ---
> There have also been new releases of the pyo3-log crate (v0.8.0 and v0.8.1), but it looks like matrix-synapse
> depends on v0.7, so I would continue with the review of v0.7.0 and only update to a later version once
> matrix-synapse requires it?

It looks like pyo3-log @ 0.8.1 changed to a range for it's pyo3 dependency. 
Not having that range, this pyo3-log does not appear to be compatible across
available Fedora pyo3 versions (0.15/0.16/0.17).

A quick test here can be done with `cargo new ...` then `cargo add "pyo3@..."`
and `cargo add "pyo3-log@..."`.

This package, at 0.7.0, is compatible with pyo3 0.17.  At 0.8.1 it could work
across all available Fedora versions.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #14 from Fabio Valentini  ---
Well, for now, the only thing that matters is that it's compatible with what
matrix-synapse needs.
As soon as they update their pyo3-log dependency, we can do so, too.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #15 from John Wass  ---
Ok. If a project needs to use pyo3-log with a currently unsupported pyo3
(0.15), should that request be in a new bz issue?

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #16 from Fabio Valentini  ---
Yes. This is the ticket for the initial package review, which has concluded.
If you need a different version, please file a new bug against the Fedora /
rust-pyo3-log component.

As far as I can tell (since you haven't given me any specifics of what you're
working on), we have two options here:

1. Update rust-pyo3-log to v0.8.1, and add a rust-pyo3-log0.7 compat package
that will be used by matrix-synapse.
2. Add a rust-pyo3-log0.5 compat package (which was the version originally
targeted at pyo3 0.15).

I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions,
but if upstream claims it is ... well.

However: At this point, I'd rather not package any more software that depends
on PyO3 v0.15.
That version has been obsolete for over a year, and I'd rather start to *drop*
software that depends on it than add more ...
What are you working on that only supports pyo3 0.15?

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #17 from John Wass  ---
> If you need a different version, please file a new bug against the Fedora / rust-pyo3-log component.

Ok, thanks. I will note that for future reference.

Wasn't trying to be vague, but wasn't sure if this was the right place for my
details. Just wanted to quote that comment of yours describing the reasoning
behind selecting 0.7, for context.
> What are you working on that only supports pyo3 0.15?

The other project is fapolicy-analyzer, which needs to support Python 3.6,
which Pyo3 dropped support for starting @ 0.16. My Rust components are just now
being bridged into the Python logger, otherwise I would have commented on this
sooner.
> I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions

I can't speak for much other than having plugged 0.8.1 into my project and it
(1) compiles (2) writes the logs as expected.  Happy to help provide additional
feedback if requested.

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #18 from Fabio Valentini  ---
I've checked, and the latest matrix-synapse release also started depending on
v0.8.1.
Since nothing in Fedora currently depends on pyo3-log, I've gone ahead and
submitted updates for the package. :)

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #19 from John Wass  ---
Thank you, this is very helpful!

I had a bz request coming for this, then one of my own bugs skipped line :/

[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

https://bugzilla.redhat.com/show_bug.cgi?id=2161739

--- Comment #20 from Fedora Update System  ---
FEDORA-2023-08e065d25d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.