https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Bug ID: 2118891 Summary: Review Request: rust-deltae - Calculate Delta E between two colors in CIE Lab space Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae-0.3.0-1.fc3...
Description: Calculate Delta E between two colors in CIE Lab space.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=90897834
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2105859
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2105859 [Bug 2105859] Review Request: rust-wezterm-color-types - Types for working with colors
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Looks like this crate bundles its rustdoc-generated docs in "/docs/", which includes JavaScript, fonts, and their licenses.
You'll need to exclude the "/docs/" directory from the installed files ... and I suspect a PR for upstream to add `exclude = ["/docs/"]` to Cargo.toml would be a good idea (since the crate's docs are 2.8 MB and the entire crate is 2.9 MB ...)
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dcavalca@fb.com)
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dcavalca@fb.com) |
--- Comment #3 from Davide Cavalca dcavalca@fb.com --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae-0.3.0-1.fc3...
Changelog: - exclude docs
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks for the update!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-deltae
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2d16b084e8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2d16b084e8
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-10-26 02:56:19
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2d16b084e8 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9ac8750658 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9ac8750658
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd6ef198eb has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd6ef198eb
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-830c7c55c6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-830c7c55c6
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9ac8750658 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-9ac8750658 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9ac8750658
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd6ef198eb has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-fd6ef198eb *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd6ef198eb
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-830c7c55c6 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-830c7c55c6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-830c7c55c6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-830c7c55c6 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd6ef198eb has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2118891
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9ac8750658 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org