https://bugzilla.redhat.com/show_bug.cgi?id=1536782
Bug ID: 1536782 Summary: Review Request: golang-github-cryptix-wav - golang wav reader and writer Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Description: golang wav reader and writer
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com ---
- add examples/ to %doc
- when you package a development snapshot, you must add the commit date in Release:
%global commit 7b3d650b50a50a0137376e392770f372edc3d968 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20171018
Name: golang-%{provider}-%{project}-%{repo} Version: 0 Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
And in %changelog:
* Thu Dec 21 2017 mosquito sensor.wen@gmail.com - 0-0.1.20171018git7b3d650
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
--- Comment #2 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x8...
I fixed it, thank you. Please review again.
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Tests require github.com/cheekybits/is, it would be nice to package it, and add it to the SPEC to run the tests correctly.
Package otherwise approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cryptix-wav
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |golang-github-cryptix-wav
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:32:26
--- Comment #5 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
https://bugzilla.redhat.com/show_bug.cgi?id=1536782
--- Comment #6 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org